Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: multipart/signed;
 boundary=252c76f8d031a49761ce5a41027e81479ffd8306ebe67cb05cd04a5ad947;
 micalg=pgp-sha512; protocol="application/pgp-signature"
Cc:     "Thomas Gleixner" <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>
Subject: Re: [PATCH] x86/alternative: Consistently patch SMP locks in
 vmlinux and modules
From:   "Julian Pidancet" <julian.pidancet@oracle.com>
To:     "Borislav Petkov" <bp@alien8.de>
Content-Transfer-Encoding: quoted-printable
Date:   Thu, 27 Oct 2022 11:42:51 +0200
Message-Id: <CNWLW5AZPIFG.15HUZ3CU0R36S@orcldev>
References: <ed7a508717bb8bec6273c2740418f0dc2df9eeba.1661943721.git.julian.pidancet@oracle.com> <Y1l3lqPTNAcqwtRT@zn.tnic>
In-Reply-To: <Y1l3lqPTNAcqwtRT@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXV1YUR1NGhZK21HNHNURXo2N05XVlFzTUVaNkZmZkMySWpvRnNPQUF4VkEw?=
 =?utf-8?B?RlFjZXBmTWtlRll0ZnJBUWZjRVVqZldyUjM3Y3E2U1EzVGhQZ0ozT01xcWRy?=
 =?utf-8?B?UEVCTlJBZ2Ric2l0dG5JUGpVZmI1SjBqOUpzVnU1aWhVVjN2WDRRQytDVTc0?=
 =?utf-8?B?WFBzeitDTHY3Ly9EckpZTjJYYVZUMFdrZ1A3Z2xkVXVieEFJMjd0OG9BOGwr?=
 =?utf-8?B?NkFlOXJEa3FGdXJxZ0xqcHBwOVFpakxMT0lzN3B2aytrUGc5QUJkSWUwUS9s?=
 =?utf-8?B?T1kvOXVLeDBtSjViNXJPaVBsam1XSWg1QzVHZlZ3SjZ1WGpCUy9ET0o1cXI1?=
 =?utf-8?B?QTJLOElSVXEyWWh2N1NIODhVSFZjY3VoR1UyOHNCR2I5NzdwdnJTandML0pi?=
 =?utf-8?B?bHNQZEhnWUt6V1NFOXQ4NWZQdFczbGdzbmF0enRoSEpMMjZHc1o2bC9ySGdG?=
 =?utf-8?B?VC9OQ1VhM2t0bnNmOFlTODV3SVdwNGdoMmJIeTJMTEhTMUlXZURMb3JkemVO?=
 =?utf-8?B?K3lydlI0UFFJZlZ3RWtkQnYxT2lZOHR0UUEvQzNabzVnbXhMVHdrdTJNRlZy?=
 =?utf-8?B?RXdBSWNKT0c4cVNMTmIwY0xwbUNDQm4zUmpVWXhmd0I3Rzk3em84dGhSTXUx?=
 =?utf-8?B?cTRSMXFyT3VJTVMrNklRdlhkeVNQUXluUUZPNG9YYkdNOWJMcm03enZmUk1q?=
 =?utf-8?B?WE1HbWVVYWEzR1JyYW4vQWtIYnZQMXRDRGUrYjhnWlJObEdoUEVjQTNSL2Ns?=
 =?utf-8?B?TnpWWEtzRndvTGxNdkRxb1lLRFJzNHlNSTNIT2lUL3l5MnhXS1VwL0drZHNm?=
 =?utf-8?B?L0hBQWxtK0VCM0VyUFlQY2xEcjMzUG5ZdVNvcjc4T0hjZ01rMm4zYXp3ZjJn?=
 =?utf-8?B?eXBtS1JCMHBSWm1NKzF1QURpT3dFZThtTWRQNVFWbWFBdkdySTlvS0F6WFJX?=
 =?utf-8?B?eUFmdGdOa2dCUS82WHBJTnUyVm0vbUhVbzNMYUE4S0pVWmlDSW1XbmcwdGN6?=
 =?utf-8?B?QmpVaDU0YVNmcTVsZENiWmNZcjRBandhOTdKc3IvYjBRZzN2S0I2SzJmWm5I?=
 =?utf-8?B?QytYUmhXMFBmWjdMQnduS2ZRRnlJMU1LUWtoczkyaThSVzhEWm9kMEZVamh5?=
 =?utf-8?B?SitvQjVobkx3OTc3MTlTTGJLRVJXdHhaTDZsZlZVQ2VzbTNjMW9JZXlleVZv?=
 =?utf-8?B?THJSblF4MU80OUpkcW1uRU9STXg0M0lnaXdjVlJIUS9mNGJzN29WNVhpcW5Z?=
 =?utf-8?B?c1lCSXBibU5RYWxBRmdobHdNQndoOGVETy85eW9uNkdTVzUrditZMTlTZWtU?=
 =?utf-8?B?ZjZralhrbS9KTEFveWdHRlQrUlJscE9PWjNvaTN6a2ovM25JbGFIR3dkd295?=
 =?utf-8?B?dytqTVhCSjM5L3psRmpMSUNWWHhsOTdoU1hPMXdDRWhhb3BCcFJWdzNZNmZR?=
 =?utf-8?B?M3ZzTDI1Tks5d1FmdHI0ZEhBd3hRTm41bnExOUZkQlkzM0RvQlFjU3Vmbnlj?=
 =?utf-8?B?c2xBRzJaUlR1QTg3ZTdJYnVWMzNTaU0zbjlhclhKUjNGNEN2ZFVWQy9LNFVa?=
 =?utf-8?B?dHRheTZqc0xvam1ibXJGQ2pwMnpHNURjTzVLN2ZTUC9QdXEwdWFxZUtBM2tL?=
 =?utf-8?B?RkhHdkk0QVdiTWhiRkJrb2dmNDJEQmt1UDV3S05XcEtDeUI3OFJocmR1aWZk?=
 =?utf-8?B?YzNBZ1h4S1V0enMvWUpOdC9maG5sSUc1anplMit4WDNCNk5La0c5NFFDSFA0?=
 =?utf-8?B?NFpoanQ0NnM1dXpEbFR1NjVZMWsxSVN1M1gvOVRVV0dXMlE3ZSs2ZFRYV2RF?=
 =?utf-8?B?Z083M3lzL21IemEzL2QvTFk1QnVzcndqQXNMbWtMTTBHdlNtejJIc0RJTXpV?=
 =?utf-8?B?RkluS1B4MkRnOTQzc09INE4xTHhLSHNvOU15Q29wcjQ3eGFmd2FOKzBmc3ZG?=
 =?utf-8?B?cE9RUEMxMEMvQUJ2b2F0Q0psNm14c0MyTlFIT3h4dUpnYTJ2b2w3SU9MbE9u?=
 =?utf-8?B?ZDRSbkZpd3pDN0VybDVoRGtXdzhFMDd3RVNPdndKcjlTS2p4eU5EOXJieldv?=
 =?utf-8?B?NnNUUGd6SEJ5ZlY2cHBiZDRsRnYxNkpWcmNpNmJBbG9CNkNGWndJTWdFQjFQ?=
 =?utf-8?B?a0VYOWpLZm9KR1pFUjhnU2Jpck5ueWp4eExLL0lHSW1WUUdxRkxra1QxR3E5?=
 =?utf-8?Q?bIrm1C0MgrejeXTGstAMTc4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc23b629-7198-4ada-7db6-08dab801bd18
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1001MB2153.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 09:58:03.5042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WUOclGyfY7oZnsSq2/0MnOi+k8ehCh1rj+2PD1Z29CO8WNPazyR8k3egqeYIRr7g0wQp3Wwd2rnySoTw3jqBgd3CIfWgBuY3QnVeyXgb6D4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5151
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_05,2022-10-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=968
 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210270056
X-Proofpoint-GUID: cdHJDjopVFioVhZXVlrzO-OoL1P32Lx2
X-Proofpoint-ORIG-GUID: cdHJDjopVFioVhZXVlrzO-OoL1P32Lx2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--252c76f8d031a49761ce5a41027e81479ffd8306ebe67cb05cd04a5ad947
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Wed Oct 26, 2022 at 20:08, Borislav Petkov wrote:
> On Tue, Aug 30, 2022 at 09:42:37AM +0200, Julian Pidancet wrote:
> > The alternatives_smp_module_add() function restricts patching of SMP
> > lock prefixes to the text address range passed as an argument.
> >
> > For vmlinux, patching all the instructions located between the _text an=
d
> > _etext symbols is allowed. That includes the .text section but also
> > other sections such as .text.hot and .text.unlikely.
> >
> > As per the comment inside the 'struct smp_alt_module' definition, the
> > original purpose of this restriction is to avoid patching the init code
> > which may have been deallocated when the alternatives code run.
> >
> > For modules, the current code only allows patching instructions located
> > inside the .text segment, excluding other sections such as .text.hot or
> > .text.unlikely, which may need patching.
>
> Is this something you noticed by inspection or is there a real failure
> behind it?
>

We do live patching of the kernel code at Ksplice. Before applying a
binary patch we have a safety step that compares the running code with
the code that the binary patch is expected to modify and abort if they
differ.
This problem was picked up by the tools that we developped for this
purpose. We have a workaround for this internally, yet the inconsistency
lies in the kernel, so we thought it best fixed there directly.

> > This change aims to make patching of the kernel core and modules more
>
> Avoid having "This patch" or "This commit" and so on, in the commit
> message. It is tautologically useless.
>
> Also, do
>
> $ git grep 'This patch' Documentation/process
>
> for more details.
>
> > consistent, by allowing all text sections of modules except .init.text
> > to be patched in module_finalize().
> >
> > For that we use mod->core_layout.base/mod->core_layout.text_size as the
>
> Please use passive voice in your commit message: no "we" or "I", etc,
> and describe your changes in imperative mood.
>
> Bottom line is: personal pronouns are ambiguous in text, especially with
> so many parties/companies/etc developing the kernel so let's avoid them
> please.
>

Thanks for your time looking at this. I'll reword the commit description
and submit a v2 shortly.

Regards,

--
Julian

--252c76f8d031a49761ce5a41027e81479ffd8306ebe67cb05cd04a5ad947
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iJEEABYKADkWIQTd3Z6iZzTygRNy7F4XFh3U+bgUcgUCY1pWIRscanVsaWFuLnBp
ZGFuY2V0QG9yYWNsZS5jb20ACgkQFxYd1Pm4FHIOogD/eQAPPmCZ3btzLC1jMnt6
6YDKrlqZUxBtqCnabRlHzOYA/1/pRMC2EobR96f+OMG7FdHJ4557ERuFCfH5Sr/r
a8oI
=Pj5Z
-----END PGP SIGNATURE-----

--252c76f8d031a49761ce5a41027e81479ffd8306ebe67cb05cd04a5ad947--