Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp528614rwi; Thu, 27 Oct 2022 04:40:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6IX2HWBghTdDksHx8HMke3F3JLZrUeA+s03rehcGokH2rOGEnepUm4dE8AmvFRRp4VarYo X-Received: by 2002:a17:902:f691:b0:186:b250:9763 with SMTP id l17-20020a170902f69100b00186b2509763mr18413194plg.62.1666870822587; Thu, 27 Oct 2022 04:40:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666870822; cv=none; d=google.com; s=arc-20160816; b=U9WZDqCRMsQQC2/q3ZJjFPjojb52olqPXajNwUA9/l5czell8/5H/MCJ/H1X1rO+gY YIfWkuwMEvd69CZhfymiuqaI8pEpQ0rXtuXHr2Ap1NvH2NwwQLbtteyem5UMyb/h/IlV zJ3WE9/mSJMGqaAHpEjB6bHJPGVLz0Jyqzmz+duGrY9OwXxVPPuffncFZhU/fJT9AUwn OyQtuTjzRno+fgY99JRk7GFjepQlxijxdEkgj9tw+j0K4kVMwc4SndKPGnmpjZu+PM9F W8dhK6uMMB6CLn6yXHn8RdFSzrapV6cZfbfvvdOGggEulYj/9/yES06PxGM/bZLaiJCQ 5iFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=P1Duupa/Hf3vhhuyAgQglPnF49X9mjD4LnFLeThne74=; b=x08N8p1OiyAMsip3oPMtYgp31Se5v5DPQ7Bsa8aO6p3RpL8O/bPpQkfsz4YqHTlNCm 6pjesMGET/WCvM6ZAa4C3vEo7wLpYO7p7IRWbyE3+PGsXyafA/itD44IKO5NTRtZ0xQ9 L0KbPG/UG94MTqDuI0amhL6L/wVylu6NdGa22qxPYO6MQPoanNTNF1QTkylPiullrqTv iQsvSWzCG5JImtwionOB5GQ6T4qlO7sR4V8oSP1EbwCV1m7h43xHNkZi37yydIdmiyKk OC3DhLECuTY+0hNetWmeoWUx8scWrPTuP7/D7BGTxrBuHCgiWG8kkC8y9VmvcIMd6QM7 xoxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a170902e5ce00b0017808c0aa8bsi1532293plf.115.2022.10.27.04.40.11; Thu, 27 Oct 2022 04:40:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235477AbiJ0KqF (ORCPT + 99 others); Thu, 27 Oct 2022 06:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235458AbiJ0Kpt (ORCPT ); Thu, 27 Oct 2022 06:45:49 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 708B1564C9; Thu, 27 Oct 2022 03:45:45 -0700 (PDT) Received: from frapeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Myj2r2lqGz688p7; Thu, 27 Oct 2022 18:43:48 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by frapeml500005.china.huawei.com (7.182.85.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct 2022 12:45:44 +0200 Received: from [10.195.32.169] (10.195.32.169) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct 2022 11:45:43 +0100 Message-ID: <564eea86-576f-e5ae-3bf0-1990964914e7@huawei.com> Date: Thu, 27 Oct 2022 11:45:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH RFC v3 18/22] scsi: libsas: Queue SMP commands as requests To: Damien Le Moal , , , , , , , , , CC: , , , , References: <1666693096-180008-1-git-send-email-john.garry@huawei.com> <1666693096-180008-19-git-send-email-john.garry@huawei.com> <9376e947-ba53-2fb9-a0af-8435d58347c1@opensource.wdc.com> From: John Garry In-Reply-To: <9376e947-ba53-2fb9-a0af-8435d58347c1@opensource.wdc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.32.169] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2022 02:36, Damien Le Moal wrote: >> + rq = scsi_cmd_to_rq(task->uldd_task); >> + rq->timeout = SMP_TIMEOUT*HZ; > Missing spaces around "*" > ok Thanks, John