Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Oct 2022 13:31:51 +0200
From:   =?utf-8?B?0L3QsNCx?= <nabijaczleweli@nabijaczleweli.xyz>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Haowen Bai <baihaowen@meizu.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/15] pcmcia: synclink_cs: remove dead paranoia_check,
 warn for missing line
Message-ID: <20221027113151.6fllc2chqgcouxh2@tarta.nabijaczleweli.xyz>
References: <9a453437b5c3b4b1887c1bd84455b0cc3d1c40b2.1666822928.git.nabijaczleweli@nabijaczleweli.xyz>
 <051083d29e5812608deb034dfa86ae0c583fee44.1666822928.git.nabijaczleweli@nabijaczleweli.xyz>
 <CAHp75Vd6iWi98WxP6ex5Thvm4QPvYj4C343dogOY_ZqXTgKDGg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="a2k6engvbsijmcqu"
Content-Disposition: inline
In-Reply-To: <CAHp75Vd6iWi98WxP6ex5Thvm4QPvYj4C343dogOY_ZqXTgKDGg@mail.gmail.com>
User-Agent: NeoMutt/20220429
Precedence: bulk


--a2k6engvbsijmcqu
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 27, 2022 at 07:53:34AM +0300, Andy Shevchenko wrote:
> On Thu, Oct 27, 2022 at 1:42 AM =D0=BD=D0=B0=D0=B1 <nabijaczleweli@nabija=
czleweli.xyz> wrote:
> > in that case
> > ("invalid line #%d.")
>=20
> Please, respect English grammar and punctuation, in particular don't
> forget the trailing periods.
>=20
> > +       if (!info) {
> > +               printk(KERN_WARNING "%s(%d):mgslpc_open: "
> > +                       "no device for line #%d.\n",
> > +                       __FILE__, __LINE__, line);
>=20
> Even though the old code uses this awkward style for messages, please
> follow the modern one, i.e.
>=20
>                pr_warn("mgslpc_open: no device for line #%d.\n", line);

Both applied for v2.

=D0=BD=D0=B0=D0=B1

--a2k6engvbsijmcqu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmNabCYACgkQvP0LAY0m
WPFGkRAArZJfVdUYYKf72qXnKyu2jUqvJSc3dqTdPJk7qtON3OkKqGAdor3MYPIm
/3vZ/VXzjAdggtDuSpHBeyPz+FwKuM6Vx0UFJ+NuwRGb1EaqpiChe7B7Mb4v2sdx
Yf+GWBG/sBNrlcIkAOvCGaeW1mAOC/3wgaqPsyPsNLb9n+1q2gkDVLs6uLoyFYbB
JojFBuEaX9zrGGYBell0AYjMa2t6kjw3NSz+uB+hEghPBzSJylGaNbUsIbd5C46z
kxeDtZBxi/c4H7zCtvosqTA6B08rD9oWi+XbLWFyflKbWUk59JCT1DKDVP3JdXBN
lgEeQCKWJUWgLtiSTUn8vL5xxCBEkwD9y3dOnpUMNd4VTEGOfwCF2jJTZ74xYD1M
ixlo7sXDZ0rkNg3lDdS5TzFMUge9hCcR/iIPDm8/8wThBcCV8Z1J+k0qGhvOMwjz
3u7CBdz9qMhKQI6b60qgk3zWHzKzS2I9QZNuVWxiVJePUQ5aRjMPNnw8jhvLWk5Z
4LNkoemRF2qJheUvU+oJl/EVlXNwg/uVG9/7DnIAX+GHsTcY4yqoT8tMhzopALBT
Uiv5c86xi7NsoW7XqlPmqLp8HMih37I2Lx4vQQrTrQ7lO64hqet00ZwTUa+EQiFt
L+OpojRfKbORWS9Cmcm3RIjx/4c5UxZTACfBHSqwiaw1nUeVl1U=
=8WU0
-----END PGP SIGNATURE-----

--a2k6engvbsijmcqu--