Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp653550rwi; Thu, 27 Oct 2022 06:10:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Rm6xvrc1C1pPSWyuOqs60fLn/AxQxS2yPjXV5lvowSW8qZ9NpUHpKLu6YQdJSopj0i5RZ X-Received: by 2002:a05:6a00:24d0:b0:563:6d36:eae8 with SMTP id d16-20020a056a0024d000b005636d36eae8mr49475647pfv.66.1666876219318; Thu, 27 Oct 2022 06:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666876219; cv=none; d=google.com; s=arc-20160816; b=kWUK82B0dWJc2d/jh/8WWusm7TTB3lP+od/RqcQoIPahMSSzNEsuO3OZybryr4Jp/N LatIIapsJDFj7D9cG7i3w/o+7kCZPf87Y4dcRgNv2dkbzqBnNOb2AzTMUJzvZTel3wNI hmXj5KFg3vkV+imTkReq87zowpT+7yWXpF2WFFykYYqAapGRldhny7WxwtGGzknXeHWn TuF9HT2OQh0FpomH9e6PFLGFPvMC0JdywDI80kpp7XlJIFkmEhSsbtC/rip98DQnGAaz Ug6QtMIDgzoEJt0psltDpCHDmYgYF2AaERYxzMp/ampTkDIkSm0MEoIQDHxRhFYIUHqF QWcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mvxMMa5thk9W2tzIR76gNCXAd3x0nQPfKbf+zuJntnc=; b=VxF5o0YAqM2gULJuivo3JfjThDW790IOZXvGkG5L34VY1GVHonxwd1xYnNSBPML4Kl G1yj16j8Kn3EBG04HGOkmA6YKfIzUo3X9VwfVyiVe7htV84tV6MoMQ0OlIQCmnY0tpDh bTBWZVC0vE6Q/C3d/ozwh+Pr8irpdshqIfd+56V5zhMY5mjsvN4P6OfaEqH5HTiNJNBs PGrbSZkSucghB7+qufEZQgJuVPCZ684jONi13BXHkFBHOYNiv6RazQZeU61832tf7KB9 zFrTmcqCkVImyvToU2JZn4MUhuFxxDy1cLyBcW7lX1wux63e1wKWHWNgfRBH0PnFMaH7 5vaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d4UIJiMZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nu1-20020a17090b1b0100b0020388f845e9si6702582pjb.52.2022.10.27.06.10.06; Thu, 27 Oct 2022 06:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d4UIJiMZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234875AbiJ0Mbh (ORCPT + 99 others); Thu, 27 Oct 2022 08:31:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234137AbiJ0Mbf (ORCPT ); Thu, 27 Oct 2022 08:31:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14E39C58B1 for ; Thu, 27 Oct 2022 05:31:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AFFA622BE for ; Thu, 27 Oct 2022 12:31:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5399C433D6; Thu, 27 Oct 2022 12:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666873894; bh=jB3Sy3lQh+g42Om28hBG9fQIjHlM5JaLLJYyHJKWjqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d4UIJiMZIz803b/bD8pE8mTWS4jlKFxUWbFy6b/ooalf6/SBwhR2KLD013OKf2l84 pEmCH7LGUlyOyTevHgooK/A8DOTbW6/QtvAnhcox8o3l+8SfVz2hUJDsft+TaPvqTz Fu025ZDYu7KNjrddMFEgmJCkmL6gyjpQGzaLkWcfhb9W2JtaBSMmX/AZQ4q6pItkzs D6E2/1aLy6dOk27kbUkmJxfgF9pwCM/ssEHxTGsEQr+sxZ3y7XXRXghAtT+ezj7s8Q paWMeMTOuE3+wQw7h/Jbm31FwNRLT/odwnS9zji+/g/nmkXZ8fPKFlmCLucfI3IY0X xlc83wz5aI7YA== Date: Thu, 27 Oct 2022 13:31:28 +0100 From: Mark Brown To: Peter Bergin Cc: james.schulman@cirrus.com, david.rhodes@cirrus.com, tanureal@opensource.cirrus.com, rf@opensource.cirrus.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoc: cs42xx8-i2c.c: add module device table for of Message-ID: References: <20221027115057.442925-1-peter@berginkonsult.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jdB2L9eetq1D28fw" Content-Disposition: inline In-Reply-To: <20221027115057.442925-1-peter@berginkonsult.se> X-Cookie: Forgive and forget. X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jdB2L9eetq1D28fw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2022 at 01:50:56PM +0200, Peter Bergin wrote: > When trying to connect the device with the driver through of > it is not working. The of_device_id is defined in cs42xx8.c > but is not correctly included in cs42xx8-i2c.c. Also add the > matching table for of in the i2c file. >=20 > Signed-off-by: Peter Bergin > --- > sound/soc/codecs/cs42xx8-i2c.c | 7 +++++++ > 1 file changed, 7 insertions(+) This should move the ID table out of cs42xx8.c, not just duplicate it. --jdB2L9eetq1D28fw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNaeh8ACgkQJNaLcl1U h9B8CQf8DD7owUCdSXZJtO0j/G7dVE9/97tFr5nvpkSXlsLfX2B9h8X7EB5RX9WC 6JaI0Ord7nqIj+NZXtxdakI17hpTPZ8Jxm9CDNCb5VHFp9GxAF+wh06Q4JdPysSk IpQ4Hex72fTd3N2HyyXIf5si0GzJ5kGxwyeXinG/ScudKzngfNlA12q+Pt3bfu0H g/9sNqirIYaqgHeacnJ/Ns6KLc/ZK9wLTrEFgu6rsn+CVo3aBmAXeyz38RA2g+lz RqM/3xUYFWgBXtFKw0Mziw4CYMvq5EJ08FJCrbP9SEGDyg010P8YFfnkZrQP+7PJ 3W66WXwqwdbZeuUh3BIDM5bApty4Rg== =zgpj -----END PGP SIGNATURE----- --jdB2L9eetq1D28fw--