Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Oct 2022 15:38:34 +0200
From:   Stanislaw Gruszka <stf_xl@wp.pl>
To:     Joe Perches <joe@perches.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: checkpatch: allow case x: return #x macros
Message-ID: <20221027133834.GA161407@wp.pl>
References: <20221027104934.160513-1-stf_xl@wp.pl>
 <8064d49ffca92adc171f6a954ad9dea2027b8e4d.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8064d49ffca92adc171f6a954ad9dea2027b8e4d.camel@perches.com>
Precedence: bulk

On Thu, Oct 27, 2022 at 04:15:53AM -0700, Joe Perches wrote:
> On Thu, 2022-10-27 at 12:49 +0200, Stanislaw Gruszka wrote:
> > Do not report errors like below:
> > 
> > ./scripts/checkpatch.pl -f drivers/net/wireless/ath/ath10k/wmi.h
> > 
> > ERROR: Macros with complex values should be enclosed in parentheses
> > +#define C2S(x) case x: return #x
> > 
> > since "case x: return #x" macros are already used by some
> > in-kernel drivers.
> > 
> > Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
> > ---
> >  scripts/checkpatch.pl | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 1e5e66ae5a52..4b888b1313d5 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -5901,6 +5901,7 @@ sub process {
> >  			    $dstat !~ /$exceptions/ &&
> >  			    $dstat !~ /^\.$Ident\s*=/ &&				# .foo =
> >  			    $dstat !~ /^(?:\#\s*$Ident|\#\s*$Constant)\s*$/ &&		# stringification #foo
> > +			    $dstat !~ /^case\s*$Ident:\s*return\s*#$Ident$/ &&		# case x: return #x
> 
> I think there needs to be a \s+ not \s* after return
> 
> And try this grep and see how many of these are handled
> 
> $ git grep -P -n '^\s*#\s*define.*\bcase.*#'
> 
> It may be better to just use
> 
> 			    $dstat !~ /^case\b/ &&

Make sense, I'll send v2.

Thanks
Stanislaw