Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Claudiu Manoil <claudiu.manoil@nxp.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net] net: enetc: survive memory pressure without
 crashing
Thread-Topic: [PATCH v2 net] net: enetc: survive memory pressure without
 crashing
Thread-Index: AQHY6TRiZQ8LCqV8m0qJGRg70aV0FK4h0giAgAB6WYA=
Date:   Thu, 27 Oct 2022 14:21:26 +0000
Message-ID: <20221027142125.k27ns6yan4rmxmwo@skbuf>
References: <20221026121330.2042989-1-vladimir.oltean@nxp.com>
 <AM9PR04MB8397AB65FDF4990B9E941F2E96339@AM9PR04MB8397.eurprd04.prod.outlook.com>
In-Reply-To: <AM9PR04MB8397AB65FDF4990B9E941F2E96339@AM9PR04MB8397.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SELkCbGniCAcM9Lx1lRCZiOgGngPYn+wwY2MUM+Eg8TxcZfvAUpGU71kEBDB?=
 =?us-ascii?Q?ZInZcu6hG5HR+Owb900ml0SYx7m2cbEHjdDT0jjKEtbbHoFJJfoYjEcbrFJB?=
 =?us-ascii?Q?S1EyyPCOo53nEPMQJTc+zbDA3bpJvTpLFDustUZ1Qn1kKFMcCpdvLZe1Jpji?=
 =?us-ascii?Q?YysbCP3wxPn0Yn/2cC6ASk/nXv60b4ukOlq4hdYHP6x4P0y8XWUwaHs537/h?=
 =?us-ascii?Q?KxNOumAuO/ZsZJ7Ro4SNcyNVjTqi1pvhY01V756OYgqCSA6fkw0bCdZraW0t?=
 =?us-ascii?Q?3XI9ePrsiq1HsRosmeYHXyZa5m8fP10T2iNMpkhUWUSw2H+G591HXCt4Mu14?=
 =?us-ascii?Q?NNUujSOm4pW7XeEq8kbUayCL7lRWUSFLfJpQ09nNgiAlrPoG5QilSjfiD5+L?=
 =?us-ascii?Q?PB8mwmkwMs/zyQ7krs41fWcvJqWwSR24K9k5NCQ06l3z/WuCpy3XHDJBecSw?=
 =?us-ascii?Q?2EI2ivPDMKp/sgQBCUJxtZ9PlfS5ce6pqiNZfU9DRNrbrAIze/bzkJV/qiEY?=
 =?us-ascii?Q?wZQzIjDUOEmxouQLiAeiW76v6mM/6yrqT14OODvEJhzmE90UxJw9U2dokrni?=
 =?us-ascii?Q?kqHQD3l84XOnQWKOKwlpU04cZFEratzwATaz1sSEAwnc7BSgjJfWEQYsk3Ja?=
 =?us-ascii?Q?e5uGVhcUolrsG3R+RCSHnx5ZAC649rmkwZxYOEFK10YtK/wsaFd8q1IMO2Jg?=
 =?us-ascii?Q?Fl6I2SGFyaFzVQAjrd/sF3h71w9VchUKx/px4ESZCBtcHHZ3twyWaac1Ccsb?=
 =?us-ascii?Q?RCKNcRoa/4cwcQ8WqQcceDaWPvK8dsaNvc7BSgO8Ko7LC3Ij6JeLccD+f+O6?=
 =?us-ascii?Q?sLW3uic/GuKIa+igTK1nbslKmjT/bjgHnxdxlWA/rwJF6/QGZlslFQsk4EcX?=
 =?us-ascii?Q?m/Q2e7vVLaVRtw14jOr91jE0q2Cp3p7jlLR99nnVEFNtUEg6PTWHTS5Vh4pv?=
 =?us-ascii?Q?ukYinfQxNJ7ttX0IUThUq99J/lrPjYApGZApLG+4PyEz1ZqhM1eHIxlewmWO?=
 =?us-ascii?Q?D80d7MuJVUkgIA2OrRBWxlawm5Y/4DRek445cO0g4MXyrQVj0+vnwy0e1idK?=
 =?us-ascii?Q?SBkAV/WaRFqVV/apLh/SOOFK9L5ktcsSw/pv0xoFHKaMSBQNCimNpMru0hhU?=
 =?us-ascii?Q?MiLLRBdn2Ia97kIrQx5qipNFBYpLa0aZS/9ykrn8v9oviyDLZP7jfkuHKCQ4?=
 =?us-ascii?Q?fddbuyUyxWBFuGt4IBlDVoDMCsE/PhTKZFs/dj33zPIxPFHCIsrtEx5RaKTq?=
 =?us-ascii?Q?nMBrRuJ6sz1fpfMjwtH3XPy53JBxqXEcdjv1OQXicD5EVcw40GtyS2iVeYgi?=
 =?us-ascii?Q?S0GEoi8CuBikjjuiqTDB21HMrWAMeqJ1z3Tgr/NoaioT2pRqdDbuS5zUMpmD?=
 =?us-ascii?Q?vSQEFlbEB8zZnIaMQUcm4qKdask8D9gaYYpIs7J3wLgc9Zcvg5bTyO/RdVIV?=
 =?us-ascii?Q?tM6pBZIiC2su2RvaYuFTmRRLiROu6Osi5CEPdQiHo4Z5gDpwGLXrVmNvFwUt?=
 =?us-ascii?Q?FLrvkNw2WUp7RO91J4y/dtHgusDnnhFld4QmcA/fEz57f68rHS8Vkt4nZUxJ?=
 =?us-ascii?Q?o/WdS5+/fiJIuLWv6I4wJwnE+Jh+lOxzK+qXQBHrps/0yC2jHqTqh+FYr4H2?=
 =?us-ascii?Q?3g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <82BD10F6F066204B974DF37AB0D10706@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47756865-710e-4393-f94f-08dab8268869
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 14:21:26.3104
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9O843OJKgE80S7L428b9pia3o9cV2YP+0ere1Yc5HpsOOJi+8BzNXG9ONFs9JgCTeE6lFtKs8HAREQ13v2Zt/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9314
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 27, 2022 at 07:03:31AM +0000, Claudiu Manoil wrote:
> How do you trigger this "extreme case of memory pressure" where no enetc =
buffer
> can be allocated? Do you simulate it?

As far as I understand, making dev_alloc_page() predictably fail in some
particular spot is hard and probabilistic (but possible given enough tries)=
.

The reason I stubled upon this particularly bad handling of low memory
in the enetc driver is because with AF_XDP zero-copy sockets, memory
for RX buffers comes directly from user space, which may simply opt to
not put any buffers in the fill queue (see "xdpsock --txonly" for
example).

The fix for the case where the buffers come from the kernel's page
allocator is simply analogous to that. It would be shady to add this
exact same patch only as part of the XSK work, when it's clear that
existing code suffers from this problem too, even if it's not easy to
trigger it.=