Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp787397rwi; Thu, 27 Oct 2022 07:35:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4HNttEWj+ycJd+4lX9bhu95+dsZe9ZMm09720V7rr2/6qDBaEN43xebL8deX8T9cVyEYGD X-Received: by 2002:a17:906:5dd8:b0:78d:efa7:f78d with SMTP id p24-20020a1709065dd800b0078defa7f78dmr42942800ejv.641.1666881307844; Thu, 27 Oct 2022 07:35:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666881307; cv=none; d=google.com; s=arc-20160816; b=M/hAxzBy5IYOs/EnahYOU9nHnLFx+Pvq5XkGjnDdobmDJwc3PBv7jhJxFnlY7HT7Mk gsc1fQkcfVI/9tn3As/YdSvwgvn7++95G/5dst52K7joxW4NsXe4noTPwYY/iARXJ/nY chOIh7oAANDZ1BKOxXbHn/RQYuuugLxeUqBm2yLSW5Xt7pLWfidYGTzVI6UxPmHE+RLp TIy9o8Q746fOjO6HxfQen1asF1Yoy0G3JbrqCnreiYad7AhdJ7rk3R/Et2S07i0R5f5f Jzm03vQCJgur7icsMOnAFvVUpk/eagDOxxfz5jT19Q9VVvH10Xt8P7opr6opOPawBPg3 A4wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=I4MXDweEqhi63t96mHvtpvGXnL5aO5zq58kCTYtbDNA=; b=A86N3W49KGbWJlTSpElpfG+S5jpmfQgzJUyYF9YaaUvKmjwtXaoTWfwbk0yNK2ouW1 FRwyeLz79YlJR7PVYU5o/ZIzZ8tvI6/4BYptaXiHYKTYXA8Au8Ci22o3T//f0DFWzsTh a5aRJWcv0mwGnE+voDzGF9LH/i1+9tOBZfn2/wIG9EZF4AxKJ9A3CHc+Mg78KDQlKZCb Iww4c2wODQZPrdo+ARZPkdWg/TO112u9KyboHk4y6tlXoJokAMw/TrjE7rdMmPrmxl6q vOJ1JdGJDUsK6tffmlXZ8h4BH2YOlUwzJzLbdDWaHFVTBYf0lm592JjWmpTJZuwkKP8r kSjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I9OOmPBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z6-20020a05640240c600b00457ebe79577si1960381edb.623.2022.10.27.07.34.42; Thu, 27 Oct 2022 07:35:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I9OOmPBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235754AbiJ0OLB (ORCPT + 99 others); Thu, 27 Oct 2022 10:11:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235524AbiJ0OK7 (ORCPT ); Thu, 27 Oct 2022 10:10:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D8B017046F; Thu, 27 Oct 2022 07:10:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B440FB824BC; Thu, 27 Oct 2022 14:10:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E46EEC433D6; Thu, 27 Oct 2022 14:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666879855; bh=8W4kKXd4CergnMT+SQY5tTnVUGd/JGQkiR+wOCiZWec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I9OOmPBtKL1YVsFGD2WB54ztbe3jEuKJrbkcArNFpjW36HM7qFAYuqiBx4FKvgCML Rv0XFkQe5OJA3va69RTMauIg7Pu27qeAGho0NO+ja65q4efQVtUEEAZ2hzILXK4qGq 73/uym5RWi9LuKKfURNYWC3km7LkNzrut4lBj3T8JJZhOZ183PUdNPmEwYEql2+gzi ntVGtj8m6WRy5ZOLCjNcbBbwStEMzOJU6d8RkRnERphPWvxgYTaJLAGv4bt0M2U3Ak 9JBT/27L4iEQSyP982+b16F6AMxSVz0MOAdAXQ/K6Skq8ArAjhT6HV33GKoVrmRFnS DbQpheLvmZk5g== Date: Thu, 27 Oct 2022 16:10:48 +0200 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni , Mauri Sandberg , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/7] PCI: mvebu: add support for orion soc Message-ID: References: <20220718202843.6766-1-maukka@ext.kapsi.fi> <20220905192310.22786-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220905192310.22786-1-pali@kernel.org> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2022 at 09:23:03PM +0200, Pali Roh?r wrote: > Hello! This patch series add support for Orion PCIe controller into > pci-mvebu.c driver. V3 version has completely rewritten pci-mvebu.c code > to parse all physical addresses from device tree files according to > mvebu-pci.txt documentation, allow access to all extended PCIe config > space registers and use modern kernel API pci_remap_cfgspace() and > mvebu_mbus_add_window_by_id() fir mapping PCIe config space. > > Most of Marvell device tree code in pci-mvebu.c is giant magic, but it was > there because this change and it is de-facto API between dts files and > kernel used for a long time. Note that it is misused according to PCI > device tree bindings, but we have to follow this Marvell bindings to do > not introduce backward incompatibility issues for other non-Orion > platforms. > > Mauri tested these changes on DNS323 board with both DT and non-DT builds. > PCIe AER is working too (one of the feature which proved that access to > extended PCIe config registers is working fine). > > After this patch is accepted we are planning to look at existing Orion > arch specific code and covert it to use this new DT based pci-mvebu.c > code. Later this would allow to kill arch specific Orion PCIe code, > which is in arch/arm/plat-orion/pcie.c and parts also in file > arch/arm/mach-orion5x/pci.c (shared with old-PCI bus code). > > This patch series depends on another patches: > https://lore.kernel.org/linux-pci/20220524122817.7199-1-pali@kernel.org/ > https://lore.kernel.org/linux-pci/20220817230036.817-3-pali@kernel.org/ Can this series be rebased please on top of v6.1-rc1 so that we can merge it ? Thanks, Lorenzo > Mauri Sandberg (2): > bus: mvebu-mbus: add configuration space aperture > dt-bindings: PCI: mvebu: Add orion5x compatible > > Pali Roh?r (5): > ARM: orion: Move PCIe mbus window mapping from orion5x_setup_wins() to > pcie_setup() > PCI: mvebu: Remove unused busn member > PCI: mvebu: Cleanup error handling in mvebu_pcie_probe() > PCI: mvebu: Add support for Orion PCIe controller > ARM: dts: orion5x: Add PCIe node > > .../devicetree/bindings/pci/mvebu-pci.txt | 4 +- > arch/arm/boot/dts/orion5x.dtsi | 51 +++++ > arch/arm/mach-orion5x/common.c | 13 -- > arch/arm/mach-orion5x/pci.c | 14 ++ > drivers/bus/mvebu-mbus.c | 26 ++- > drivers/pci/controller/Kconfig | 4 +- > drivers/pci/controller/pci-mvebu.c | 202 ++++++++++++++---- > include/linux/mbus.h | 1 + > 8 files changed, 256 insertions(+), 59 deletions(-) > > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel