Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221023124810.51b1201b@canb.auug.org.au> <a49605d6-6e1f-78c8-9774-423891089052@linux.alibaba.com>
In-Reply-To: <a49605d6-6e1f-78c8-9774-423891089052@linux.alibaba.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 28 Oct 2022 00:02:14 +0900
Message-ID: <CAK7LNARMwzYag=t_0D0Vf14h22NU+RsuqnMve_akOew10On=Wg@mail.gmail.com>
Subject: Re: linux-next: Signed-off-by missing for commit in the
 kbuild-current tree
To:     Dan Li <ashimida@linux.alibaba.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 24, 2022 at 3:34 PM Dan Li <ashimida@linux.alibaba.com> wrote:
>
>
>
> On 10/22/22 18:48, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> >    9a21115ca50e ("Documentation: kbuild: Add description of git for reproducible builds")
> >
> > is missing a Signed-off-by from its committer.
> >
> > Also, I am guessing (I haven't actually done the build, yet) that this
> > will produce a new build warning from (e.g.) "make htmldocs", as the
> > underlining of the new "Git" header line is longer than it should be.
>
> Oh yes, I didn't see a warning when compiling, but it should be aligned
> here, sorry for the typo.
>
> To Masahiro:
> Do I need to submit a V2 to remove the extra underscore here? I'm willing
> to if needed :)
>
> Thanks, Dan.
>
> >


No, worry.


Just in case, the following is what I applied locally.


index 13397f38c358..f2dcc39044e6 100644
--- a/Documentation/kbuild/reproducible-builds.rst
+++ b/Documentation/kbuild/reproducible-builds.rst
@@ -120,7 +120,7 @@ kernel versions by including an arbitrary string
of "salt" in it.
 This is specified by the Kconfig symbol ``CONFIG_BUILD_SALT``.

 Git
------------------------
+---

 Uncommitted changes or different commit ids in git can also lead
 to different compilation results. For example, after executing


-- 
Best Regards
Masahiro Yamada