Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220902141715.1038615-1-imagedong@tencent.com>
 <CANn89iK7Mm4aPpr1-VM5OgicuHrHjo9nm9P9bYgOKKH9yczFzg@mail.gmail.com>
 <20220905103808.434f6909@gandalf.local.home> <CANn89i+qp=gmhx_1b+=hEiHA7yNGkfh46YPKhUc9GFbtNYBZrA@mail.gmail.com>
 <20221027114407.6429a809@gandalf.local.home>
In-Reply-To: <20221027114407.6429a809@gandalf.local.home>
From:   Eric Dumazet <edumazet@google.com>
Date:   Thu, 27 Oct 2022 09:28:42 -0700
Message-ID: <CANn89iL7EvdBhZGtxDOATeznLUwVaFm2gf4XCYeMPXE5CR=BTw@mail.gmail.com>
Subject: Re: [PATCH net-next v2] net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM
To:     Steven Rostedt <rostedt@goodmis.org>,
        Ian Rogers <irogers@google.com>
Cc:     Menglong Dong <menglong8.dong@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        David Miller <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>,
        Ingo Molnar <mingo@redhat.com>,
        Menglong Dong <imagedong@tencent.com>,
        David Ahern <dsahern@kernel.org>,
        Hao Peng <flyingpeng@tencent.com>,
        Dongli Zhang <dongli.zhang@oracle.com>, robh@kernel.org,
        Pavel Begunkov <asml.silence@gmail.com>,
        Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
        Vasily Averin <vasily.averin@linux.dev>,
        LKML <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 27, 2022 at 8:43 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 27 Oct 2022 08:32:02 -0700
> Eric Dumazet <edumazet@google.com> wrote:
>
> > This seems broken again (tried on latest net-next tree)
> >
> > perf script
>
> Do you also have the latest perf and the latest libtraceevent installed?
>

I tried a more recent perf binary we have, but it is also not right.

I guess I will have to request a new perf binary at Google :/

perf5 script
         swapper     0 [030]  4147.704606: skb:kfree_skb: [UNKNOWN EVENT]
 kworker/30:1-ev   308 [030]  4147.704615: skb:kfree_skb: [UNKNOWN EVENT]
         swapper     0 [030]  4148.048173: skb:kfree_skb: [UNKNOWN EVENT]
 kworker/30:1-ev   308 [030]  4148.048179: skb:kfree_skb: [UNKNOWN EVENT]
         swapper     0 [008]  4148.048773: skb:kfree_skb: [UNKNOWN EVENT]
         swapper     0 [030]  4148.112271: skb:kfree_skb: [UNKNOWN EVENT]
 kworker/30:1-ev   308 [030]  4148.112280: skb:kfree_skb: [UNKNOWN EVENT]
         swapper     0 [030]  4148.720149: skb:kfree_skb: [UNKNOWN EVENT]
 kworker/30:1-ev   308 [030]  4148.720155: skb:kfree_skb: [UNKNOWN EVENT]
         swapper     0 [030]  4149.072141: skb:kfree_skb: [UNKNOWN EVENT]
 kworker/30:1-ev   308 [030]  4149.072149: skb:kfree_skb: [UNKNOWN EVENT]