Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1042488rwi; Thu, 27 Oct 2022 10:24:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6yG/rsXNcwgJqUMG6KtwzaPPDyoJF3Szl3vcQNayBEXBpT264XkAArRtWdL8m30gKhG5Sg X-Received: by 2002:a05:6402:5510:b0:459:5ea:9bc0 with SMTP id fi16-20020a056402551000b0045905ea9bc0mr45774552edb.152.1666891444912; Thu, 27 Oct 2022 10:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666891444; cv=none; d=google.com; s=arc-20160816; b=J8URUhxVDu/TF/WHPazhm4EQS1c0xTtAwYu92mDBFU/ESj9VXw325XXbOS0FcqNDPn Q3x7TCWy+WoQahtoLgF5wlavvYHHrsvdBrLbB44V9Pvp2temB7G3npegRrYahyS0DFMl ScXD0jx/Qazn1p0tCi1OK5UwkrtzSTHruw+4hqlx74zcL+fK/R9Lw1/uClkFBAeIPjR/ s7C8p94kq6SHLaXOcMGmhnxkMpfqGMfzOJN92+dMG+3kKMQlRW84wQVKM8SeBVI22utF 0i3np3iV40x93Rz3VxlxVzFmxAcVNZ24mZS4o3CknWtZdVAlFmAHWAGmVJsfQ2oZqdjJ ElmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HICjCe/T3KktXFKRv+wo+yHgKZxC3DJ5boYWFpCcesE=; b=tarkDF3LkRwRG3jwzJr6fL4yHuJ2aTuxPcatW25vK1lxddtQ3oM9eVOSR9nFzeiviO RR4m6u11+jRf2I6tuuVg4caOzKo8k4cT8/KE6aUVMyy5gwH+FSeUq59y7J5BdB477aBT r90+aPsAHTF0HpasleYbgDMrwsfiDrEVbD22Jn/KWQ/N+XFRMhThvxXKfRhoKjmzF8pm 0vCCCZ7PONC5ePzOTiYRL3jn/TwEOALIY/p7hCuxLQlcuFxiWfl2I2VSEjtV+iQWIp5C EeNL7r9M30AT9y3RlImA78XuHXR9WYGFvi50tf9lavnanEqkwZoTTLN9LtVkHK3CeGfn 2PNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=ibo+HdQT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z9-20020a509e09000000b00461b96334eesi1768127ede.500.2022.10.27.10.23.39; Thu, 27 Oct 2022 10:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=ibo+HdQT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236792AbiJ0QxE (ORCPT + 99 others); Thu, 27 Oct 2022 12:53:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235396AbiJ0Qwt (ORCPT ); Thu, 27 Oct 2022 12:52:49 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F4D19D88C; Thu, 27 Oct 2022 09:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HICjCe/T3KktXFKRv+wo+yHgKZxC3DJ5boYWFpCcesE=; b=ibo+HdQTm3+r0wK7uqOdAST2le gsw90CiCXIlAGkIzYEC7A+1vAxYVvC2H0hZ10bgepKdLD3/JvHNjHYDSLBj6+IMEOO2t04AEf1jU5 lu5U0nhrME+intT5DAO17p3zcr7TRGet6GnYJ2BJhLU/oAH8PbQD7ZdsHHdw75fDQWPxqDqypniA2 fTj5J2gsP69L25Yrd0GAmXLnost182Tc7hcAyZJFAw3ovutFVUEzk+DjqTdznsdJ2E+BrW0AIFxFL kvXKgp74xWaP05RzSk/0hHsCaffJDUb4wbrqJOGF1vL51uheP2Y1gdQ8hpRXL7tUPBTLBx0Q9kbfO u8asqKmQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo662-006uvv-BB; Thu, 27 Oct 2022 16:51:10 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5D75330008D; Thu, 27 Oct 2022 18:51:09 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 374FA2C64658F; Thu, 27 Oct 2022 18:51:09 +0200 (CEST) Date: Thu, 27 Oct 2022 18:51:09 +0200 From: Peter Zijlstra To: "Darrick J. Wong" Cc: Yujie Liu , oe-lkp@lists.linux.dev, lkp@intel.com, Thomas Gleixner , linux-kernel@vger.kernel.org, x86@kernel.org, fengwei.yin@intel.com, ying.huang@intel.com, fstests@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [tip:x86/core] [kallsyms] f138918162: WARNING:CPU:#PID:#at_fs/xfs/xfs_message.c:#xfs_buf_alert_ratelimited.cold-#[xfs] Message-ID: References: <202210241614.2ae4c1f5-yujie.liu@intel.com> <2543dfb1-d9dc-0888-dbea-e420a19d732c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > However, I noticed that the callsite in the WARNING: message has changed > from the usual 'asswarn' (which is the caller of WARN_ON) to > 'xfs_buf_alert_ratelimited', which seems totally wrong since XFS log > recovery doesn't touch xfs_buf objects at all. Yeah; and I've meanwhile found more cases where it goes sideways. I'll revert this patch and try an alternative approach. I'll post patches tomorrow or something. Sorry about this.