Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <08c0e91a-a17a-5dad-0638-800a4db5034f@intel.com>
Date:   Thu, 27 Oct 2022 10:35:56 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.0
Subject: Re: [RFD] resctrl: reassigning a running container's CTRL_MON group
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>
CC:     James Morse <james.morse@arm.com>, Tony Luck <tony.luck@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Eranian, Stephane" <eranian@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Babu Moger <Babu.Moger@amd.com>,
        "Gaurang Upasani" <gupasani@google.com>
References: <CALPaoCj-zav4x6H3ffXo_O+RFan8Qb-uLy-DdtkaQTfuxY4a0w@mail.gmail.com>
 <b2e020b1-f6b2-e236-a042-4eb2fd27d8b0@intel.com>
 <IA1PR11MB6097236CFF891041DBA42ECB9B5F9@IA1PR11MB6097.namprd11.prod.outlook.com>
 <Y0BhzKkksSjSeE3W@agluck-desk3.sc.intel.com>
 <81a7b4f6-fbb5-380e-532d-f2c1fc49b515@intel.com>
 <CALPaoCjdeRjyX5L6BBX688ZM21eMwetuL9QLF1+GEDUskGcU2w@mail.gmail.com>
 <76bb4dc9-ab7c-4cb6-d1bf-26436c88c6e2@arm.com>
 <CALPaoCiKUQC+LxDwKQ0gE5AQniJi_nbzrXi_HA9ZBRtiXdw_dg@mail.gmail.com>
 <835d769b-3662-7be5-dcdd-804cb1f3999a@arm.com>
 <CALPaoCgiwtvxZMJ6f-BOTNMPXDbMB8QM42HyCAvYRi4grPiphQ@mail.gmail.com>
 <CALPaoCg2-9ARbK+MEgdvdcjJtSy_2H6YeRkLrT97zgy8Aro3Vg@mail.gmail.com>
 <715e4123-fdb3-a71e-4069-91d16a56a308@arm.com>
 <CALPaoCjUk31HvhaqWKfkLNLyZJzbDLJOnEqTsqn882CToLCGcw@mail.gmail.com>
 <317b4a96-f28d-aab5-57cc-f0222b7e4901@intel.com>
 <CALPaoChNAaoJ7uzuxFFDn-f5nvUCXyJ4jkbETHXNdDpXNnh9pQ@mail.gmail.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <CALPaoChNAaoJ7uzuxFFDn-f5nvUCXyJ4jkbETHXNdDpXNnh9pQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnNHbExZNEw2WDI1bkl1V1ZuVmVjaTZWTnMyMnVWTERDKzUwbmJUQU9idDJ0?=
 =?utf-8?B?N3NOTW01a2F4TDM4ZnRTQ1FJSWRqUHVFdkVmUkFTa0o4bVBSVTVtUlJDZEFs?=
 =?utf-8?B?bktjR1FOZDVkbHdqaTQxOVc3SzRvQ2FKcDdzb0ltNm1nRkVoeTh0MTNsYVE5?=
 =?utf-8?B?N2UzOWJ4VzBaT0FQT0YxSGZBeGxrVVBIZ003SmFIYmd3NENNMWdxTURvTHpn?=
 =?utf-8?B?QlBkbWJXN3U1SEhhT1pFSkNFS0JEN3pybDdDMGpkZkorRlhkdGFxaE1OWFJP?=
 =?utf-8?B?UHJSZDF2K1F6dHJ2VjdzM0tOMWRKYjB3WHpmcjB2UXFIdWg1V2xSS2cwQ2pN?=
 =?utf-8?B?Y01lUFdrdXQwUXNNYUsvd2xOdzRQT2xLSjVWZVJNU0FTa3hBRDNjWGVvbE1K?=
 =?utf-8?B?aEFVWHE5VG95ZlNaVmpYTURUQlNvajU2VHF2a0ovNkcvYW5pRy9WV0hkc2Jl?=
 =?utf-8?B?aWhTSlQrcDFpVWZ6T0xsRWpYZC9iZ1dDWEZVdm1rbnpQZzNjWlJEMStyVWRS?=
 =?utf-8?B?SXNKbkh1TzJCWnlhZk83QjFaQUxENi9uU3phWUpBa2NpSHlJVHZIYzh3UTFS?=
 =?utf-8?B?eWZUQUptTlVTZVBnb2NOMjNGQzREN2g2VDdJUURJaTZ5Y2VpcEpxdFZKMHF1?=
 =?utf-8?B?YitMMU45bndOcGlxT2RoSG5SbTRRMGh0enk2V2h1OEhjL29QTzJ2MHNxaFhS?=
 =?utf-8?B?WmNPM1g0dW9wd0poMXJTMlkvSlpzd2s4YWwvQWdiNHNtUkVNNUFRaUo2RnVV?=
 =?utf-8?B?MGM0VUJVSjZ4eVduckdrUWNoTHZRSzZINEVzUGNadkJDSHNqK1liN2wyKzla?=
 =?utf-8?B?bE1BZkhxUXQ2ak5yZGVHMFcvSkRoNjRmdks4ZDFqUkFDLzhuVXZPZGd5YUFa?=
 =?utf-8?B?RnpHeng5OHZkMUJNMGZwRFlHU29HTzgvaFlmNnptZU1PenM0MzdINkdmVUxi?=
 =?utf-8?B?SE9aM3JXQXhoYmgvWktvVnpVOWd4T2toVDErcGFscklvdUNjWGM0YjJDTXk2?=
 =?utf-8?B?c0I0TjdjK0FveWM4cVRaN1hZUnZyL25pcDRRNS9tWjR5NEgrcHNzN1NJbDhS?=
 =?utf-8?B?NzEvcm14dzhycDQwd25ZZFJsVlh4ODZ3M1NXakhGck0rY3pJUmNaVCs1Ti9p?=
 =?utf-8?B?N3JKSjc0NFNlT0lyemZlblNqNnBtZEY2TkZobnIyUnNwdzhnaG02dnI3S0x5?=
 =?utf-8?B?OE1pMFNSQmNKczlaMGczK2lKZlFwalM1RmI0OU5DVW1KWkRhVTRqOUo3ZWEx?=
 =?utf-8?B?ak9NNlVGSVdPNURzWU1VZmc2cUFnNEVoVzlMZFJxcnJkM3o0cFdGSzZ1WHVI?=
 =?utf-8?B?d2h3Tk5UY0hRSmp0SDlEYm5SQVRxZmhISUpmN2MzQVZKbkNaVGhGcndqWm80?=
 =?utf-8?B?WlFYNXV2YVROaGhRQUZ3dFZsbU1HVGdwOW9ldzRGUzlEeGI3eEZoYnd5a2Jx?=
 =?utf-8?B?VUx1bkpsdGRncFV3Y3VJY1lWM09halBkWWp2L3lETXZEZEt4Y3VXa2FFMTFq?=
 =?utf-8?B?WHllZ0lBVFpldjZlVDFHZEhiVjhiYlpXU2JHWk8zQVdITHljUGZFeUp4d3Rn?=
 =?utf-8?B?WnQzYU1RVnRPenBUSUozd1lQT0ZobWdBZTdiYjdLN3dwWGlvRHBKZTNmYStq?=
 =?utf-8?B?MkZKc1FKNDJhZU51NmZyQ2V1VnhIM3c1czhzRkt2a3dQTkl6d0ZDc3h4Ykw1?=
 =?utf-8?B?ZEEyb2JYMzFGVVMvU0tjYUtQcGQ2NVdmM04vSG1yZEszS28vTW1ydHphcFEy?=
 =?utf-8?B?d1dvM0tSU3QvUmZUak5QSlFsTTRidXRuRDB0NnpCejNCRVYxeFZQVUJQYnd2?=
 =?utf-8?B?elgybXQ0d29odG9EYVhRYURyNldjdzVOeDlQZVROZ3pxS1NOUU5md0FBRkpF?=
 =?utf-8?B?YTNVclhmbjdBejVtMGxsTnY3NFdXcDVrQUtVVW4vc24vYUpKTEVhZk1Zdktt?=
 =?utf-8?B?aVY2SHk2VU5vdlkzN0JDSHJka3dON0tHcmxZMFRnc3dmdmRRd2VjQ2lwREJk?=
 =?utf-8?B?TWFoYnpSamE0RUpUMWh3cUNPOCtjd3l0WUJyK0hPRVR0b3V4RElkeU9VWU5k?=
 =?utf-8?B?RS9GNE1kVnpWWUxrVHJ0RnRqeFBpengxcThJbVFpUDlFYW56S1BHcFhrOFJ3?=
 =?utf-8?B?b05Qc3c4RkduV0JKdVh0dzRNTkpLQWZhVTh6NGtKeUorRE9nSFJxeVlMM0VX?=
 =?utf-8?B?dVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e718ef5b-f459-403e-0ae1-08dab841b638
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 17:35:59.8982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xgLSpm2sY98svTDaatVDLwX9ZhXwP2RV/sz7nhu+GaUlgB25JWTTPEh0GEMLjGljNoKQefFLRhQgoXwmgvjbQsLYM8wicsJUfVBgNdL5ZzA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6750
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 10/27/2022 12:56 AM, Peter Newman wrote:
> On Wed, Oct 26, 2022 at 11:12 PM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>> The original concern is "the stores to t->closid and t->rmid could be
>> reordered with the task_curr(t) and task_cpu(t) reads which follow". I can see
>> that issue. Have you considered using the compiler barrier, barrier(), instead?
>> From what I understand it will prevent the compiler from moving the memory accesses.
>> This is what is currently done in __rdtgroup_move_task() and could be done here also?
> 
> A memory system (including those on x86) is allowed to reorder a store with a
> later load, in addition to the compiler.
> 
> Also because the locations in question can be concurrently accessed by another
> CPU, a compiler barrier would not be sufficient.

This is hard. Regarding the concurrent access from another CPU it seems
that task_rq_lock() is available to prevent races with schedule(). Using this
may be able to prevent task_curr(t) changing during this time and thus the local
reordering may not be a problem. I am not familiar with task_rq_lock() though,
surely there are many details to consider in this area.

Reinette