Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net] net: enetc: survive memory pressure without
 crashing
Thread-Topic: [PATCH v2 net] net: enetc: survive memory pressure without
 crashing
Thread-Index: AQHY6TRiZQ8LCqV8m0qJGRg70aV0FK4iiQEAgAABDIA=
Date:   Thu, 27 Oct 2022 18:02:09 +0000
Message-ID: <20221027180209.qunyi4bdikbtqfho@skbuf>
References: <20221026121330.2042989-1-vladimir.oltean@nxp.com>
 <20221027105824.1c2157a2@kernel.org>
In-Reply-To: <20221027105824.1c2157a2@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UuH8bnZDSSv+DsnMNMwEBAxzWE/4KZGVSSkwU5QoBpryzbZl76nihK85kJ4b?=
 =?us-ascii?Q?PL6NimzwZ4jsNb+wc92+w8+sgzE/BFpf7l/xyI2h1GfrCJP52t6JpS3ov+Ei?=
 =?us-ascii?Q?CNCnndVDWBQrWQR6hmwI5SMLb8acxW+rzfgiw4xk/TYOjN9dkjI0kepm9VeB?=
 =?us-ascii?Q?+Dsv7MkeSfi/gzqKhCxOWsJ7zeJHXYw4Rg+sIZ302oVemZTOwnoVK0aUnYed?=
 =?us-ascii?Q?qYFY+4/IFJT2wcNmxc3+ArPtitUAQRDyAPTC9XkaQZYvomPBU5QZlE+CsS9V?=
 =?us-ascii?Q?YNNrpf1DT43O+2z1xgN+aVa+/klSzADWISfXhVnvZvKQeMcVXPHavetLFsRT?=
 =?us-ascii?Q?zfOZRG+Naw+lTzNDfILX6uVrxYJJRKoi7pVGblPmsYAfq0qG+pvwuByXulUo?=
 =?us-ascii?Q?5ZnvsKDVkyP1ram4U6CqzBsjF+7bURKTn+sxBemDwQSOgrUGBY5+mReqrY/E?=
 =?us-ascii?Q?jYnKxpCRojIX4aokPP/Urwzy9TZtcofzcwL6lGnjogt1uqtv8mvKQlP8FxaW?=
 =?us-ascii?Q?EXvIiSHslrRRqJGtHW1RE3UMQUvhuvcRR/1MK8aMY6atlxMy145vrb6oEeo+?=
 =?us-ascii?Q?SJcjKa8ak6km7RjO2yrNkgsvB4Cw6ECTKR3P0Mi+adomJIiG511pfIKGkVpB?=
 =?us-ascii?Q?5eZoemvlo3YFK0jquTiRfUgG6B1CckHG6D6HNP9T9LLvlYnjy270dxomarX9?=
 =?us-ascii?Q?41KoiN4TFjecKo4+S3YySMpp60qAIqVHQRN0PD02/zLguSNvtYwyMN+MFte0?=
 =?us-ascii?Q?LVgBDZkwVtaGe5JG2S4Z9mY7AUUAaMKF48S0zkkV+QKVeYYjoxIVGCX9Alh4?=
 =?us-ascii?Q?1Z3D0M72d7k7D22SwiOHHsg7nVzFF7ao9lNLcM3K4Uua6rUPDHiE6qHT/4D+?=
 =?us-ascii?Q?DiZ/47BkgJzAqidNahL36kIisNhlwOGjpwHA3atPnrA+nC4uYjkZREgnTrVt?=
 =?us-ascii?Q?2VLsQGTxvdtDsHTOETrXqZms+E3GQJ/IH1iMNPWxp8PN+ZkkFjQoBQuHRaQj?=
 =?us-ascii?Q?aRlP+geMJnMs/5gZtVbg2ph59gRHFuBHtkJCnO/FcUG2d2xNkAoZcXI5Keey?=
 =?us-ascii?Q?x1y+MPISFA7FYnr4XWhlgQeDk0zk03EMQDYdYbqSuXpyCDjf599dWlwfDUwe?=
 =?us-ascii?Q?xKATZwXGVbycvSIhJvVbB9eAdvz+XyCyRM9vHIfPxjKfXzN4WMKnZ6HkYQoi?=
 =?us-ascii?Q?scvpofVT4w/R9it83E9DTFvFlOtKcyT4IEcztqKZXExtuoNpZ2CjTgqJO4dY?=
 =?us-ascii?Q?ON+u2P9TdURfqsHsfM5oA6b5HhUJ/Y/ciyH82P696ylKaVTYxSLKCbrlaLZm?=
 =?us-ascii?Q?kIdtaCQ/bymK3KBvrEEibOlRDnDV/N56umnN58s4cCvqOZPqj0TRhhc8AL6w?=
 =?us-ascii?Q?gCLrKOF7i02Y4+X7f66Cr9R64FSMvTFtS/6zvPFg+PncXoxeMwDMh7MCPg2l?=
 =?us-ascii?Q?xPFOVxUAUxodlWLkBQOJQ8TUqmkKpNUqw6fYEAV/WJyz2e5C6IwhrTcJiEMx?=
 =?us-ascii?Q?i84yu1oB5e7PTV77SjiX4fFLemCEE8sAkhEehd0yz6PEoiQuf2R60n7NaBKT?=
 =?us-ascii?Q?uDAnMgL/0x/PURSpBls02oIckN3RWSfxNE6cd48QCNSzZXJJfhxIlp3CT9yS?=
 =?us-ascii?Q?UQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <95573D1A1420B5469A7DEEF9B791C6E1@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89fd1111-f7fa-48eb-7a75-08dab8455e3c
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 18:02:09.9466
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wxKMoauaUDbVgWgP3rKlz4pYdAZC6tSJWjSC2PauOUhYzBO9zzO10jcugdri4bKhhd2hVhaICZpQwXYKyIPteA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8648
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 27, 2022 at 10:58:24AM -0700, Jakub Kicinski wrote:
> On Wed, 26 Oct 2022 15:13:30 +0300 Vladimir Oltean wrote:
> > To fix this problem, memset the DMA coherent area used for RX buffer
> > descriptors in enetc_dma_alloc_bdr(). This makes all BDs be "not ready"
> > by default, which makes enetc_clean_rx_ring() exit early from the BD
> > processing loop when there is no valid buffer available.
>=20
> IIRC dma_alloc_coherent() always zeros, and I'd guess there is a cocci
> script that checks this judging but the number of "fixes" we got for
> this in the past.
>=20
> scripts/coccinelle/api/alloc/zalloc-simple.cocci ?

Yeah, ok, fair, I guess only the producer/consumer indices were the problem=
,
then. The "junk" I was seeing in the buffer descriptors was the "Ready"
bit caused by the hardware thinking it owns all BDs when in fact it
owned none of them.

Is there a chance the patch makes it for this week's PR if I amend it
really quick?=