Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Oct 2022 11:53:11 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     muchun.song@linux.dev, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: hugetlb_vmemmap: remove redundant list_del()
Message-ID: <Y1rTl/1lgpKwVE8T@monkey>
References: <20221027033641.66709-1-songmuchun@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221027033641.66709-1-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GUFW6iQ3wNC8fzAkHfhaDE8wAvy3sv0JupcJ20Z/CW/PmmJol5kYmmLRxewi?=
 =?us-ascii?Q?ha6ESJ7FoaXjif28ZrfTtBKw7ZblI+yTyOGpOnBymYRsEN0w65WqeuUWzxUn?=
 =?us-ascii?Q?mp2mEVf6RIyLnYla8zMgBL66QB1Uz29TcsfCH1H2IqLn24CHtNvrSgCQo36Q?=
 =?us-ascii?Q?rvnPz3JKCGr39l82cz6ufFvkVDg8/KukwcWvb6uUgtgE+yaX67WVPjnE4ofw?=
 =?us-ascii?Q?t8OuHJrmZNpuXHalUDeiWtfkVxsesnuVMzY3wRnMLVK9Wq1fiC3mzd4fB80w?=
 =?us-ascii?Q?wCs47Qaz+WUH2FXIofyGJMHxAPpJqY7IWhrCeLq7XsyM8hIN3uaQw9IJSS+s?=
 =?us-ascii?Q?yB1b78LtcCxOmTWFwtU7l5LZDQJZuWDsi9RWSuM9Rsgy8TBKlJHa8aNDoQvI?=
 =?us-ascii?Q?Xv5mj5lc9x8VJ8QAPwrfQSObRRTBtZ4KWRPThpwhl07uK/zO09NjFUMoUJxH?=
 =?us-ascii?Q?r1de16ft5Y7ET5AYkWJ1sDfs8/o2D34+GhwDpFf+0fpbWiDXy/NKOmnBp3FW?=
 =?us-ascii?Q?+9NexPCSuzIWoAn0QD969nmHMamNw74hV4NZ9PHD+aPd4U9vnWKu4JaVINTh?=
 =?us-ascii?Q?3ix2uspO7x7L4yV0zmwxiMYJ0tUJ7g4dgKfb16lu3BQXnfa2cSxpxhdRSeln?=
 =?us-ascii?Q?KVOdARfPc+Z1NZpNZHfqiR55I7uWTCf0Vm82ChqxqWc6O1KZ3wBNsTlQaRZk?=
 =?us-ascii?Q?mJE9L4B1qzrPuRPnhXY41NnyLy2RnxJ62CAGRERO4/5w3yTPYEwolxAZ5yHl?=
 =?us-ascii?Q?jF/Da7V5HeFDe4gh68Bq9KkFttyjp5w7MqGw0EzkIb5gNnwOreY0ZtwuKEhn?=
 =?us-ascii?Q?k26MTgcrEQefol9bezaqOMUaVmSEo6JNg/qQOsTui/YmBJDS5mQMxil7xwZq?=
 =?us-ascii?Q?nBXx+bkPQbkBXdLzmGvrISt5lCHw4dIYOQJtJ0CfKMagIxXGcfF9E4v5V0aY?=
 =?us-ascii?Q?ZPoZ5ANJRlH5SkcBIQD/OdQ39zfdYjyWbbd8gj0rxb9Xgq9xH/znlBYGNVO3?=
 =?us-ascii?Q?qUbVdjm74h7teRrlHS4IHQwLo9L2LFbAmcZEauUPQlG5SZOWSzsDKoP4DjH+?=
 =?us-ascii?Q?av0LhVvdvctQCBd9Vf2EhYENrGc7TDzaZJcNNnAC8I5/ZQxWR0eYd7jpdT+h?=
 =?us-ascii?Q?RL6yfXmmqhmS1Jum3dOD0mGH1gSb1lj86pcbR4ZMZqZO1pkjZgNSPkK8JLte?=
 =?us-ascii?Q?Vny2Dso7Euwjm13HgtcISDwkzGpho2FK1wReNQqDJWNpq5IeCcG5rIuq98FN?=
 =?us-ascii?Q?WRzyP9lnyuOCu7Fjse0uRVLiDmgKpFaDnga4JaTu5yevUnjRwvkMN8ozQ7SP?=
 =?us-ascii?Q?I0okSuyqPSPO2BjHnuvE+rEFFU9ds60zvdOS8oD4pPKfws8riH7Xog8+H+9T?=
 =?us-ascii?Q?UkRicrvUQqdnrCJv7vPy5tnw/NUpE1YgSdWWmJl6EtStTWbYE/fUgGupERwo?=
 =?us-ascii?Q?SVd32RKPBHOTToY/k7x95Gtci9dYYkbTiWjL8MqaO1nd0AN4bVMIcPh3abim?=
 =?us-ascii?Q?jOAn4dQ0qTr/igsjocftF0+cQKi9n/jblhl95aWAPPAkCVcsJAhyqC1uQywG?=
 =?us-ascii?Q?Z9GssMOqYVjSYPaNiye8xtAy5m2yLxgsJUxAOiWWlTFdRK/3mttj+m9RKJhM?=
 =?us-ascii?Q?kQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd69ac52-65c9-4808-f576-08dab84c8207
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 18:53:16.6493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EWgz6w0k0fTxRaXPwgBpd7oqX+fdLE4TAM2hLxaTd/b6oKFhKGDiGz7dxu6fUyckXSFydxUHNnWq1ZyOB642Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5153
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=999
 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2210270107
X-Proofpoint-GUID: ITAIWMDmVT18trbCXEEfmIyqu8Sy62Sp
X-Proofpoint-ORIG-GUID: ITAIWMDmVT18trbCXEEfmIyqu8Sy62Sp
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/27/22 11:36, Muchun Song wrote:
> The ->lru field will be assigned to a new value in __free_page().
> So it is unnecessary to delete it from the @list.  Just remove it
> to simplify the code.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb_vmemmap.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz

> 
> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> index 20f414c0379f..c98805d5b815 100644
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -231,10 +231,8 @@ static void free_vmemmap_page_list(struct list_head *list)
>  {
>  	struct page *page, *next;
>  
> -	list_for_each_entry_safe(page, next, list, lru) {
> -		list_del(&page->lru);
> +	list_for_each_entry_safe(page, next, list, lru)
>  		free_vmemmap_page(page);
> -	}
>  }
>  
>  static void vmemmap_remap_pte(pte_t *pte, unsigned long addr,
> -- 
> 2.11.0
>