Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        "Neeraj Upadhyay" <quic_neeraju@quicinc.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] sched: Add helper kstat_cpu_softirqs_sum()
Thread-Topic: [PATCH v2 1/3] sched: Add helper kstat_cpu_softirqs_sum()
Thread-Index: AQHY5hRPGohirfZ+NUCi6rPTBZAIq64imQUw
Date:   Thu, 27 Oct 2022 19:04:53 +0000
Message-ID: <MW5PR84MB18423C3F30D3F789EB48D0A5AB339@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20221022124525.2080-1-thunder.leizhen@huawei.com>
 <20221022124525.2080-2-thunder.leizhen@huawei.com>
In-Reply-To: <20221022124525.2080-2-thunder.leizhen@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kZNNfs0LZBFm6myslkVDvuLJ0QHVvE7UFv8Aka9/gYCaQfGlwETgFLE1Ut4G?=
 =?us-ascii?Q?ssngPmXEsA6NwmW2b6Ibj6213Uh6czcascxnEqqlmkQfhFgcqWwRsbPC+9UP?=
 =?us-ascii?Q?BCaTGSZGOVykSINeobuZIHICZNQNGzPaZ51dNMyYf5G4ZL9DYKd3dN2MieMJ?=
 =?us-ascii?Q?BwYzNwPPtekZ6UD2zMaWIu+KdFirAzTMjbLRFUpq0jh8Hg5X1ZMIIOucYKNc?=
 =?us-ascii?Q?KigdTKGySuHakkc9ZirTiIt9/LUQHYQBBdYO2/n4QTP+vPruAUmEQ5vuOwKv?=
 =?us-ascii?Q?HFsNUxfNQbVsAo05F97nF10fejrK03KAaTwofwFFrduNnM2S4HCpVEyVxiQ4?=
 =?us-ascii?Q?nGlGa5mK/FwIjUZV8o7uqH3ZJvqMwmHOoICZF33rG72rDpbCavzQC5+kn3zN?=
 =?us-ascii?Q?W9/s7NCehQARK2u98wBrytKSzHLmk5nDYyMHvEiiZ+lOHe7Z8guGmWqYql0q?=
 =?us-ascii?Q?sxolubTj7j9EqMsPYeO/HW87ng1F87tgJkUsKngzu1YvY2K2TK3rrzX8aAOl?=
 =?us-ascii?Q?/L+qEheWDzsSAm+q7reRgcuyFDybQJCGfFXT1O7H3/xx0/QkfPxV98GAJqeH?=
 =?us-ascii?Q?l7MLNqIID/KLe10vXiuSttpYKlky1bXR7Vlt8D5RQULexMXaaOKk0iYRh+Ig?=
 =?us-ascii?Q?GbNVolrddO0LzK8R/RhjefBECYuldabEhVrYy7Xiz7oXFnb02zUelDkfPefL?=
 =?us-ascii?Q?+T529wO0qKgr7bb5WXclYFu0YbHItP8LivG0sq898WSxvq5mSDNZEBIcjmCH?=
 =?us-ascii?Q?qrFjh76audishWelZg2Y1yvbNXH+srl44dzLFdvCeEW5Zz7A7hNkA1+CLBp4?=
 =?us-ascii?Q?IZrHULHdvnnI6U6XA/JQth3jQeANOBmfuaMVDaEqaIIjXZ0ikLUmQuU1Qly7?=
 =?us-ascii?Q?3TFOGEfdNb0Kzea2HdRI3Wd/r1wme+EOcPK0PsJ09o7tbeomfc6YrF5v3prm?=
 =?us-ascii?Q?9IyTR/8ZQz8Piq+YeTccCSQMyzvFMW98zbebXGaSSZX6Azz+ZIneZjtnSXVb?=
 =?us-ascii?Q?z0NLYNMhhp2qFXsaeHIsIIssW1bhF7S2bZPA4E2XxhB8Dp5uLAIyk2fKMbr0?=
 =?us-ascii?Q?6X4y6cstQBdgJW8aqgXEyACOsoW0I9q4TCh6RWRoZjK4IMM5nM9SZ8QqynCn?=
 =?us-ascii?Q?PNtyAugJz03nf4NQ02/mFJ7DblgA9FTCHB8F46Lmk/wfflf3UERutiG7VjYY?=
 =?us-ascii?Q?i+3of9HjV5bAbOd+AovWlckKmxbEDYcFUxEgS4F4LJB6F2z49qihwGWPRUde?=
 =?us-ascii?Q?bSpX4UJN0OH7rcovhRyBXtbUBdrKqSvrhM1JYCv1yZya5YPpz90NIxdElHfl?=
 =?us-ascii?Q?ubiKGCzx6pXNHlWWYLtuBm0vk75InBS8Zen7jT9xi0nb48mBSD4qkpQaXslW?=
 =?us-ascii?Q?4pAHV1ob2R1YIyFedkpMxl5oCFiRI31fv4wZJw5VsIZIF+S2ZzzG1ujTejt/?=
 =?us-ascii?Q?m7zAm+n9+oPoAlr4RLS6lEUzMIDXUmY47MJAZbT9yZci0xVGudjYpKlhhO7a?=
 =?us-ascii?Q?lkVVU8pCpFSribyybu3oGSGxmoFwvmx81ipf9Lx0AEIjWKrQ2MTk9v/qbEtt?=
 =?us-ascii?Q?IOnLpPPfw/WCMN0onFs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 5589bc8c-b604-49b9-257b-08dab84e2189
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 19:04:53.5473
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qVHiTpPZKuYaupkRjnrsKcQfr/JesDnWSaGBt4sc9of8KHzZOMJ7jeKdLkB9tBZ8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1782
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: xQz7ykjYaBPxWWw3ZXBmCAwmTA8tn1P6
X-Proofpoint-ORIG-GUID: xQz7ykjYaBPxWWw3ZXBmCAwmTA8tn1P6
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0
 clxscore=1011 mlxlogscore=710 lowpriorityscore=0 malwarescore=0
 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 impostorscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210270108
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Similar to kstat_cpu_irqs_sum(), it counts the sum of all software
> interrupts on a specified CPU.
>=20
> diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h
> @@ -67,6 +67,17 @@ static inline unsigned int kstat_softirqs_cpu(unsigned=
 int irq, int cpu)
>         return kstat_cpu(cpu).softirqs[irq];
>  }
>=20
> +static inline unsigned int kstat_cpu_softirqs_sum(int cpu)
> +{
> +	int i;
> +	unsigned int sum =3D 0;
> +
> +	for (i =3D 0; i < NR_SOFTIRQS; i++)
> +		sum +=3D kstat_softirqs_cpu(i, cpu);
> +
> +	return sum;
> +}

In the function upon which this is based:

irqs_sumstruct kernel_stat {
        unsigned long irqs_sum;
        unsigned int softirqs[NR_SOFTIRQS];
};

static inline unsigned int kstat_cpu_irqs_sum(unsigned int cpu)
{
        return kstat_cpu(cpu).irqs_sum;
}

kstat_cpu_irqs_sum returns an unsigned long as an unsigned int, which
could cause large values to be truncated. Should that return
unsigned long? The only existing caller is fs/proc/stat.c which
puts it into a u64:
        u64 sum =3D 0;
        ...
        sum             +=3D kstat_cpu_irqs_sum(i);

The softirqs field is an unsigned int, so the new function doesn't have
this inconsistency.