Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org, rostedt@goodmis.org, masahiroy@kernel.org
Cc:     linux-trace-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, arnd@arndb.de,
        akpm@linux-foundation.org, eugene.loh@oracle.com,
        kris.van.hees@oracle.com
Subject: [PATCH v9 1/8] kbuild: bring back tristate.conf
Date:   Thu, 27 Oct 2022 20:57:47 +0100
Message-Id: <20221027195754.100039-2-nick.alcock@oracle.com>
In-Reply-To: <20221027195754.100039-1-nick.alcock@oracle.com>
References: <20221027195754.100039-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/FeXlbXKKU9FwLsxQX1ANNfdOcK+vlYoJId+sR6bPd5GNezRuEEJU5CrCHTm?=
 =?us-ascii?Q?HsA3cCJr+GqgTH+q22fFzkXgCY/NxmeFY06aoqdi+GLJACTe5pXVW69XGm+t?=
 =?us-ascii?Q?82Jj3MRE0yLb7wIkrNRYnumKWzqo0IWmwN0DkIC8WPpY09awfe5SvtkZHAvm?=
 =?us-ascii?Q?I+I/WkRqQxVeHcmKO0psETS5Cq/JwCKXbKSKSaUWaAH3AbAADAqzcKorO5zy?=
 =?us-ascii?Q?EZRy9tCr6TqTD8Pltk+284LYB8w31mwgzLU0LEPTmu3eynTeFz/3eDVS1kEX?=
 =?us-ascii?Q?6nTSYLFO8jPDFPbELg1/zCHORae6u38aQrSq7twNm24svgTKCdQmY3hWZer4?=
 =?us-ascii?Q?SBfNpOTzPuO8OV3N+gWjTRMHEri8eRfWVTMzgzpBV+X382r00A4neNBkWKKQ?=
 =?us-ascii?Q?tAUTBHJOaK+r0U+3aTJiwRXPnbGXgM42fmghql4LfoVv+sMF0S1vVUqNjftq?=
 =?us-ascii?Q?n8hhTU65N6bITMjwRuYEu9SrBOBEdGPH4hSjy9XQJfzb+MAXsVtVqnxnzosu?=
 =?us-ascii?Q?99b/FvTFMjc5ZP8HLho8ARCHCK+5HEu4xpDApfOIpaK7FZvMBzmO3W+ixw2e?=
 =?us-ascii?Q?u8tDgLdoNEqCQXAgRGLJoOb1g+I/L7a2xGSOI09+0efD/vMhSN1lKzOR2F9k?=
 =?us-ascii?Q?dvMcmQYMudr5cp6UBmYCHA/3QN715OEI38uuGFuZxDkRg8k2qn76VWw57x04?=
 =?us-ascii?Q?6eVgNCiMZ3KymWCwjZOF6sE3PjjUaKzbhlP+0ggPDos3049uwYzlCL7j6Mq1?=
 =?us-ascii?Q?obvrw9REVEjHl01TrQ9cd9fpwQMz6AbrhBLeOMLizD5CCbL+7EO45n5PnfWS?=
 =?us-ascii?Q?PKXSTCDvxRBKqgtNDbdxAMlLBC4TT8jSWFeIZqXz0Y9l6jM49b93W5+2+57i?=
 =?us-ascii?Q?JNWiScJX9qRFxyfHPQDpDNEEPIAnpciI0nRbsl65d2gzfsQCWeVnVSvfk1VY?=
 =?us-ascii?Q?8mJYEyF5h9cdPf5dAH3P9L9ziE35kncimRu20yqJmUQfv97pez0wzyA+0rky?=
 =?us-ascii?Q?h2OTyMC4u287eFHVRkB5FUN9oScn8sL4+2qsAzamStwikFAVdmpg/gLHqNg0?=
 =?us-ascii?Q?rALAdQXMek2ESNiFJcwQwcHp5ZmP28csiBVLZDMc64Zs+rzmJoDyxhszqbtj?=
 =?us-ascii?Q?OKQ1wv+6p1SirqPx6r2gbAs31UQqgYuAOoCYwaAQzeqWApGemrkyMIa+rdkK?=
 =?us-ascii?Q?Y2UzhZetpECdBM7l33QsC1Jgswt94DHj6tYzepjJWPsz52q/u/wHKiYp+F3H?=
 =?us-ascii?Q?tzEElg7pSmVe8AZwwNIkB5irC8tjOS7wsPc8EN9mMoGZFi5LAK8mpZE3TpgK?=
 =?us-ascii?Q?4QY8GKsdzfXy1uJCgPPZOPWilJQcyD9XDvo09mP/gQsgXvEeUv1AIyRm+q7L?=
 =?us-ascii?Q?Xx68XB9TvfV/xeq9X4FobSQefPYfpUKdp8O1yLg4quQ5CatnzZUi4OiC0nmj?=
 =?us-ascii?Q?O1n4vuoA9pcCAHdaJazaZ7IHR6Ftr7G2N8IsSV4fdPUdjnqd6PZSg5GNFTnu?=
 =?us-ascii?Q?/n2zOomgC0Pk2g1RB9oi1I9enzYu8OmhLzxoRgTBeFZU5hlhu1wOPGiKevtK?=
 =?us-ascii?Q?OhyVfgQopb4YQqBxPgENez7zQyZjzr7QWJ8bK4HqjVZo+aUbwpDWuylcbUHX?=
 =?us-ascii?Q?Zg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a94aa39-c8c6-4c73-6863-08dab8559465
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 19:58:12.9626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G2pwYrsyUNkhJbnhoW8Mufcc8YYthHDLkA7YQ6wkqCkGiXWQEUvHkN03wrenyWHd+jwSEkW3woVYlKXgu1j29g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6042
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 mlxlogscore=999
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210270112
X-Proofpoint-GUID: QztShrEen4mrEhanTBNP1v3u2_RVymMk
X-Proofpoint-ORIG-GUID: QztShrEen4mrEhanTBNP1v3u2_RVymMk
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tristate.conf was dropped because it is not needed to build a
modules.builtin (although dropping it introduces a few false positives
into modules.builtin support), and doing so avoids one round of
recursion through the build tree to build it.  But kallmodsyms support
requires building a mapping from object file name to built-in module
name for all builtin modules: this seems to me impossible to accomplish
without parsing all makefiles under the influence of tristate.conf,
since the makefiles are the only place this mapping is recorded.

So bring it back for this purpose.  (Thanks to the refactoring in
the 5.16 timeframe, this is basically a reimplementation of commit
8b41fc4454e36fbfdbb23f940d023d4dece2de29 rather than a simple
reversion.)

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Reviewed-by: Victor Erminpour <victor.erminpour@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
---

Notes:
    v7: rewrite in terms of the new confdata refactoring
    v8: adjust for changes in 5.17 merge window

 Documentation/kbuild/kconfig.rst |  5 ++++
 Makefile                         |  2 +-
 scripts/kconfig/confdata.c       | 41 +++++++++++++++++++++++++++-----
 3 files changed, 41 insertions(+), 7 deletions(-)

diff --git a/Documentation/kbuild/kconfig.rst b/Documentation/kbuild/kconfig.rst
index 5967c79c3baa..e2c78760d442 100644
--- a/Documentation/kbuild/kconfig.rst
+++ b/Documentation/kbuild/kconfig.rst
@@ -162,6 +162,11 @@ KCONFIG_AUTOCONFIG
 This environment variable can be set to specify the path & name of the
 "auto.conf" file.  Its default value is "include/config/auto.conf".
 
+KCONFIG_TRISTATE
+----------------
+This environment variable can be set to specify the path & name of the
+"tristate.conf" file.  Its default value is "include/config/tristate.conf".
+
 KCONFIG_AUTOHEADER
 ------------------
 This environment variable can be set to specify the path & name of the
diff --git a/Makefile b/Makefile
index d148a55bfd0f..5d26447fecb8 100644
--- a/Makefile
+++ b/Makefile
@@ -793,7 +793,7 @@ $(KCONFIG_CONFIG):
 #
 # Do not use $(call cmd,...) here. That would suppress prompts from syncconfig,
 # so you cannot notice that Kconfig is waiting for the user input.
-%/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h %/generated/rustc_cfg: $(KCONFIG_CONFIG)
+%/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h %/generated/rustc_cfg %/tristate.conf: $(KCONFIG_CONFIG)
 	$(Q)$(kecho) "  SYNC    $@"
 	$(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
 else # !may-sync-config
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index b7c9f1dd5e42..160d12b69957 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -223,6 +223,13 @@ static const char *conf_get_rustccfg_name(void)
 	return name ? name : "include/generated/rustc_cfg";
 }
 
+static const char *conf_get_tristate_name(void)
+{
+	char *name = getenv("KCONFIG_TRISTATE");
+
+	return name ? name : "include/config/tristate.conf";
+}
+
 static int conf_set_sym_val(struct symbol *sym, int def, int def_flags, char *p)
 {
 	char *p2;
@@ -670,8 +677,12 @@ static char *escape_string_value(const char *in)
 
 enum output_n { OUTPUT_N, OUTPUT_N_AS_UNSET, OUTPUT_N_NONE };
 
+#define PRINT_ESCAPE		0x01
+#define PRINT_UPCASE		0x02
+#define PRINT_TRISTATE_ONLY	0x04
+
 static void __print_symbol(FILE *fp, struct symbol *sym, enum output_n output_n,
-			   bool escape_string)
+			   int flags)
 {
 	const char *val;
 	char *escaped = NULL;
@@ -679,6 +690,9 @@ static void __print_symbol(FILE *fp, struct symbol *sym, enum output_n output_n,
 	if (sym->type == S_UNKNOWN)
 		return;
 
+	if (flags & PRINT_TRISTATE_ONLY && sym->type != S_TRISTATE)
+		return;
+
 	val = sym_get_string_value(sym);
 
 	if ((sym->type == S_BOOLEAN || sym->type == S_TRISTATE) &&
@@ -688,29 +702,38 @@ static void __print_symbol(FILE *fp, struct symbol *sym, enum output_n output_n,
 		return;
 	}
 
-	if (sym->type == S_STRING && escape_string) {
+	if (sym->type == S_STRING && flags & PRINT_ESCAPE) {
 		escaped = escape_string_value(val);
 		val = escaped;
 	}
 
-	fprintf(fp, "%s%s=%s\n", CONFIG_, sym->name, val);
+	if (flags & PRINT_UPCASE)
+		fprintf(fp, "%s%s=%c\n", CONFIG_, sym->name, (char)toupper(*val));
+	else
+		fprintf(fp, "%s%s=%s\n", CONFIG_, sym->name, val);
 
 	free(escaped);
 }
 
 static void print_symbol_for_dotconfig(FILE *fp, struct symbol *sym)
 {
-	__print_symbol(fp, sym, OUTPUT_N_AS_UNSET, true);
+	__print_symbol(fp, sym, OUTPUT_N_AS_UNSET, PRINT_ESCAPE);
 }
 
 static void print_symbol_for_autoconf(FILE *fp, struct symbol *sym)
 {
-	__print_symbol(fp, sym, OUTPUT_N_NONE, false);
+	__print_symbol(fp, sym, OUTPUT_N_NONE, 0);
+}
+
+static void print_symbol_for_tristate(FILE *fp, struct symbol *sym)
+{
+	__print_symbol(fp, sym, OUTPUT_N_NONE, PRINT_ESCAPE | PRINT_UPCASE |
+		       PRINT_TRISTATE_ONLY);
 }
 
 void print_symbol_for_listconfig(struct symbol *sym)
 {
-	__print_symbol(stdout, sym, OUTPUT_N, true);
+	__print_symbol(stdout, sym, OUTPUT_N, PRINT_ESCAPE);
 }
 
 static void print_symbol_for_c(FILE *fp, struct symbol *sym)
@@ -1207,6 +1230,12 @@ int conf_write_autoconf(int overwrite)
 	if (ret)
 		return ret;
 
+	ret = __conf_write_autoconf(conf_get_tristate_name(),
+				    print_symbol_for_tristate,
+				    &comment_style_pound);
+	if (ret)
+		return ret;
+
 	/*
 	 * Create include/config/auto.conf. This must be the last step because
 	 * Kbuild has a dependency on auto.conf and this marks the successful
-- 
2.38.0.266.g481848f278