Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Michael Walle <michael@walle.cc>
CC:     Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Heiko Thiery <heiko.thiery@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] Revert "arm64: dts: ls1028a: sl28: use ocelot-8021q
 tagging by default"
Thread-Topic: [PATCH] Revert "arm64: dts: ls1028a: sl28: use ocelot-8021q
 tagging by default"
Thread-Index: AQHY6ffdJD/5Oq16AkSmf/jVUKUJTq4iJNOAgAAGMICAADtnAIAAItaAgAASUwCAABf8gA==
Date:   Thu, 27 Oct 2022 20:36:12 +0000
Message-ID: <20221027203611.e4spuamslzv7ph3n@skbuf>
References: <20221027113248.420216-1-michael@walle.cc>
 <20221027120519.7f3xun66l4lamcq6@skbuf>
 <20221027122727.fhs35eqtzmeen6x4@skbuf>
 <84c5e0a041909615a1ba8a4508131206@walle.cc>
 <20221027180445.74btifpmfhkt74zy@skbuf>
 <3ea25819670c088df0cc6f483ab4fe01@walle.cc>
In-Reply-To: <3ea25819670c088df0cc6f483ab4fe01@walle.cc>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wf5W2bw0EnbUbbJGyJ8UmEwYtByAxm+dNwxHFDO4/xwiOxHkfVsbXpEPil/9?=
 =?us-ascii?Q?8ecH1l0SEpfTgGDiE2DA4nIsKQfDQjLgnQ5FvyHMcCzaFJUYAZkMrRffn1MW?=
 =?us-ascii?Q?4Y2BGNB18SwzHOjtQwT44z6I0Xwhc/Uz4xThofvsE9W1hfz73BfpELR0VacZ?=
 =?us-ascii?Q?jH4zMIbSCNLRaxXbp09Dw9hyDUz0V7LSLqCWmjHPvkXXlpHy6JcsPtnU5Lf9?=
 =?us-ascii?Q?ccWcEpT3mJzmykGMEOHZfrYQe79TaENe2G9Vo79HleU86eTeu5KQ1uXACFYC?=
 =?us-ascii?Q?Q0npML9pfddHtHXPyBg9CZuBEDgR3xvZNqBICFCuyXRK/KdWHw4+kGOY3Rfu?=
 =?us-ascii?Q?K5TZry5ce5kJ/IYZwWpfDJi4NnLvbMn/BjkQE13cvrZyXtmNpHd4HkYmnf37?=
 =?us-ascii?Q?K4MahR/Xe8rIO4nLUsn5nDrQavd5qd5D+Zux0435ZPGMYpRXA/5fN+fDOXww?=
 =?us-ascii?Q?Q0iRjKVpMmcjPJZSBZ5txNI8ZCezEqjZA1LfMz28heK4yPbHggwso9jyqPWI?=
 =?us-ascii?Q?115zgGswNHYb40vRJdfSgqSXffpzSxrbSYcJef7fgfqaZYSkEO0ko8SfAzjA?=
 =?us-ascii?Q?rEFpdU6tylQrS++kXeLiZEGLujxiccnqhWuJQFGwlTSZf6tSGjzWHDHM1EKj?=
 =?us-ascii?Q?HiRiDXgCnTpXvze6AaVM9bk2HJiIlBj4+YziAF3O8SKaEsSe8pCR6nXgL2xs?=
 =?us-ascii?Q?3wcXGTq25ddMT8Bc3joid4pS3vuGSSacifcX70wOpT6BMctmRm3/oHDeQ1rJ?=
 =?us-ascii?Q?1YmyU0z0RUjpsGCJB0cNaU5hBB+7p2CUkUmRj0fK4OWucs2SHhu7nvkZLlCX?=
 =?us-ascii?Q?hSj38NZB/k5NQPRRK7Mo/0Jz+8GOskuS2z4Fp3QDINEZpfYbOGUHrYu7L3Hn?=
 =?us-ascii?Q?H9ha0sKYahwZAV/PYTlk9B+FlIqntwwCsayC973Sw0yiElp31/z/7/3cWHhr?=
 =?us-ascii?Q?HB3ktaYi3ab8wI4OouwnoG+QlbOcbmNrM8qH/FG2Pq4p5WQU3pAtQtyAxfjG?=
 =?us-ascii?Q?y8lJzcsqvuzop21TZamjmwFRSVbtVhHkhj88GJWXEL6a8zjNrmAzp7ujA7l2?=
 =?us-ascii?Q?ETTu9kdhtAcK9dz5Yc+oaouQXJmLqgg76fTpnHiA9shOgGLQdRhAg5B848td?=
 =?us-ascii?Q?hiVWYwWgof7FxATrEO5vNKEucc0hYJeNZLDSysyu1rP5jXFLADign6REOyWU?=
 =?us-ascii?Q?UZ9eD0rvkE+Ggu/BNK1hdH19ZCES0vLRmukCa3DH45FgEfi4K7rHqldoSxqk?=
 =?us-ascii?Q?OuO2clGmfoPL9OvLul29wKaLHR78fowfCNe2ERQVjl+yxnRFNBHCYBCRQi9d?=
 =?us-ascii?Q?YuOC6DY+1wRH3qr/Jujbdp1xWUeGGZH5/yb3xtF1OkDLy3fzg6nsPzjDs7LN?=
 =?us-ascii?Q?e/el8VmgKZm5i5X79hrCC9oh7GZJBjsChEPpeLTzApRrOnuYJfq/AIO/+6T8?=
 =?us-ascii?Q?ZXB2jgn1PzGgDbUejuQrNQHKVD5s57HMHn/KMqjboMPVBq4IYFhSgTrRAzEI?=
 =?us-ascii?Q?4H3h0jkU//bohGFh+Xazl/AaOOGiHer0gbPMvRHSPQzZ81VMyVJPiRRHO53T?=
 =?us-ascii?Q?tEpV1MHCA5wFKKnVJ91YS48U1MyYAs2HL0kURTywE6+kz22+6SVXLNmaFRyi?=
 =?us-ascii?Q?Ow=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0F2FCDC1326C774FBD80B33CB437BE4A@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20b938a0-246e-49a2-89fc-08dab85ae341
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 20:36:12.5480
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YUDlNl42mxvzHM2D8G2OVFF08wEKVHvu3cgssLyuUAF+cMBcDt31LvU5xebEet4NE9ixIC2m5BVnWA5lGGQe0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8334
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 27, 2022 at 09:10:20PM +0200, Michael Walle wrote:
> If one would a new tagger you'd need to add it to
> dsa_tag_proto_names[] as well as adding the tagger source file. Thus,
> two places to keep in sync. And you don't have all the information in
> one place, e.g. the tagger module. The name of the tagger as used in
> sysfs or device tree is then in the core. Just wanted to point that out.
> After all it's up to you as the maintainer to decide ;)

True, there are already 2 places you need to keep in sync, you already
need to add the tagger id to include/net/dsa.h (twice). The header is
shared between taggers, the DSA core and device drivers. A third place
would indeed be a bit too much.

Actually I came to like your idea with 2 modaliases. I prepared a patch
set and I'm in the process of testing it (need to rebuild everything
with modules, which I usually skip). If it works, I'll post it as an RFC
soon.=