Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5e8c70a-3358-513b-c8a5-7a7903f6ea42@quicinc.com>
Date:   Thu, 27 Oct 2022 14:28:37 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v3 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC
 clock bindings
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        "Michael Turquette" <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        "Thomas Gleixner" <tglx@linutronix.de>
CC:     Taniya Das <quic_tdas@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221026190441.4002212-1-quic_molvera@quicinc.com>
 <20221026190441.4002212-2-quic_molvera@quicinc.com>
 <e5009a33-1f71-1fe3-3a06-98bba031fdf0@linaro.org>
 <20221027182449.366AEC433D6@smtp.kernel.org>
 <cb9a2732-0904-4a2b-61a5-a6d65cad58ae@linaro.org>
Content-Language: en-US
From:   Melody Olvera <quic_molvera@quicinc.com>
In-Reply-To: <cb9a2732-0904-4a2b-61a5-a6d65cad58ae@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/27/2022 12:35 PM, Krzysztof Kozlowski wrote:
> On 27/10/2022 14:24, Stephen Boyd wrote:
>> Quoting Krzysztof Kozlowski (2022-10-27 08:54:51)
>>> On 26/10/2022 15:04, Melody Olvera wrote:
>>>> +description: |
>>>> +  Qualcomm global clock control module which supports the clocks, resets and
>>>> +  power domains on QDU1000 and QRU1000
>>>> +
>>>> +  See also:
>>>> +  - include/dt-bindings/clock/qcom,gcc-qdu1000.h
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    items:
>>>> +      - const: qcom,gcc-qdu1000
>>>> +      - const: syscon
>>>> +
>>>> +  clocks:
>>>> +    items:
>>>> +      - description: Board XO source
>>>> +      - description: Sleep clock source
>>>> +      - description: PCIE 0 Pipe clock source
>>>> +      - description: PCIE 0 Phy Auxiliary clock source
>>>> +      - description: USB3 Phy wrapper pipe clock source
>>>> +    minItems: 2
>>> Why the clocks are optional?
>> They should not be optional. They're always there.
> Just to be sure - I refer to last three clocks here as indicated by
> minItems:2.
>
> DTS does not define them, so something here is not complete or correct.
>
DT is incomplete; I don't have that in my current patchset. Will add later when PCIE and
USB nodes are complete.

Thanks,
Melody