Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1360110rwi; Thu, 27 Oct 2022 14:56:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM44o2TT3ViTYHlxl1CSL/ttURMzBWlBKB5NxGvRbEmfYD3fs46PN+hcHi7JNLp2YOB9CGx3 X-Received: by 2002:a63:105e:0:b0:46e:9bac:1c3 with SMTP id 30-20020a63105e000000b0046e9bac01c3mr33666785pgq.388.1666907780713; Thu, 27 Oct 2022 14:56:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666907780; cv=none; d=google.com; s=arc-20160816; b=L5qP5N+jV/fErmtz0i7RDg2GrcEJVk+od/zEyLFOhWMriJ8SdY6dougwuXYaTjrF1y 3tNSFLSPXV+gHNwueyLF+MqNGw8cHEPVk1hINCMqtsFsq1ohbis9Ckrql46KmBWnLG71 g7kBhKwilNeoG00r9De4/iP6/id4f0h/VEW1qS8+zmOek5Y9b/jyVEc4pmT7DCT3RnaQ lZfpNzXhgaQjpSlOFMCjQCj3GgW0p5WFgpkdUdR8H1d2NmvVt9cfxKyDSHWXTDwzE7kg YhheWgvhGtyc0HoYmB/XFmpWpy2/9jHFykOnQBWWOnRXA+GIFbNlmDu7kkVaA7KINebI 867g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=+bqMYfhBoMQBNclMwiXInuF4126VdbEDPwSYcMlTatk=; b=BZn9p3pORHlrRPrV4YDrwu7AnKotNiErD0krZyMJqwZdVQcSBfDqnum7iqn9rx6e1H T9ecpmIg8IId/tcqQf5Y4pT26qaxqbSPi3hv7n7apXtI8BqaWQhrXn1NSCPxN2mYLy7K ojTCGcB/vCVdlTNmzKQJ2ZIEpwy4KUec+hcQIH7Ed5LXRHu/sE5y0cNNvDRO97aFEMfR awrLVynW+MgMomrkxivKFrju4kKW2ulKCO+gGSL+Upx9Tj4DgV8AY9XyiKTeEA85/Dm2 RGAWPJBVawQmh2QyTph+2LDdb8oEQZc9MW4JV8HwvTQZawGjYuSjD2m4PRs7iSZrpx7p WHlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CJRlxu66; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a170902dacd00b0017535568d5dsi3582046plx.256.2022.10.27.14.56.09; Thu, 27 Oct 2022 14:56:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CJRlxu66; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235922AbiJ0Vl6 (ORCPT + 99 others); Thu, 27 Oct 2022 17:41:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236117AbiJ0Vly (ORCPT ); Thu, 27 Oct 2022 17:41:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E7CB4B4A0; Thu, 27 Oct 2022 14:41:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E82B3B827DE; Thu, 27 Oct 2022 21:41:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F112C433D6; Thu, 27 Oct 2022 21:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666906911; bh=+bqMYfhBoMQBNclMwiXInuF4126VdbEDPwSYcMlTatk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CJRlxu66YR1gJs+s/NRcf9oKssdDMmsNjr8UoEhMmO0BXaC5th/zLePkc9dB6Kfk1 x6OmBiPkcO1KJDdZsxscaN8ZlqWvZdoHZbgds/k2Bvmgj9Dl3Yb9Cl946pyKrj2rat hJHXHbwRo0MRo9ApgPkb4JO8xANJvDN8P5wR7cSjTWZEe5PmONuVZ7Y1GuEt0HcG6e lbK6VL4KcBv7hSwPl2IRLroc1paBs4BmP9IMRzPc/BZ3xeTBHlOLDamhgj8NTRcuhL jiHOk3G3pyDA5u5k6bnWMVP2zIMEJ+P9TxPvw7uzqzOX0iica03IJcc2g0VXYzlm1r a/PEVvzF7+4bg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <5e55012567da74870e1fb2edc2dc513b5821e523.1666801017.git.daniel@makrotopia.org> References: <9bde77be-f4ec-11e7-e645-7c4465bcf6db@collabora.com> <5e55012567da74870e1fb2edc2dc513b5821e523.1666801017.git.daniel@makrotopia.org> Subject: Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks From: Stephen Boyd Cc: Sam Shih , Miles Chen , AngeloGioacchino Del Regno , Chen-Yu Tsai To: Daniel Golle , Matthias Brugger , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Date: Thu, 27 Oct 2022 14:41:49 -0700 User-Agent: alot/0.10 Message-Id: <20221027214151.7F112C433D6@smtp.kernel.org> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Daniel Golle (2022-10-26 09:18:07) > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock > driver clk-mt7986-infracfg.c. Is this a cleanup patch? Or a pre-requisite for thermal and auxadc drivers? I don't understand the priority of this patch. Should I apply it to fix a regression?