Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Yujie Liu <yujie.liu@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com,
        linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Amir Goldstein <amir73il@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fsnotify: allow sleepable child flag update
In-Reply-To: <Y1pE/MdXBB9swEZ/@yujie-X299>
References: <20221018041233.376977-3-stephen.s.brennan@oracle.com>
 <202210271500.731e3808-yujie.liu@intel.com> <Y1pE/MdXBB9swEZ/@yujie-X299>
Date:   Thu, 27 Oct 2022 15:12:41 -0700
Message-ID: <87a65ghq5i.fsf@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?09Lia3LrmuRir9S6r0BRjMskVzLKJWC9y8EEoES8QcS7u7NYWkIIqE3IWgc9?=
 =?us-ascii?Q?bnvh+Ud98zr5n2vhSiMWqnK03PRx4SkSggPj7UbzrWf3RtdyEoZUQ0uQN4PG?=
 =?us-ascii?Q?bquYBpyWPD55Dk6LgqXdFRaAxMGiPLRBknOoy7yTvE86DXGKoVZs8vaZzCgl?=
 =?us-ascii?Q?QG55IWjI5+P8JESGqw9sbysxY12M2QSQFZ3z/O1KcwVpY8zwOxW661QyEgH+?=
 =?us-ascii?Q?oeIZPj0f8+HJugK88e3jUqhex2m+yQst77bVW1FBn7OPb8uvdobd0H8XUR5R?=
 =?us-ascii?Q?lt55qWIVRGtB/05l+0qdroBKk5McBkSwrUfPXQILLfJvB5OXyclHafaITuVM?=
 =?us-ascii?Q?Gk5kne8F81Noj+0kAzQFaz6R6mjf+8likGyCPWwa8P3+nQLDeJxty32rfkaA?=
 =?us-ascii?Q?+AlivCHBy/eppoZX52yBnbCWqDDetrfznlq0Xu7Z9RZN1Wdi4qkPEdlE2nY/?=
 =?us-ascii?Q?qM2f/GxAgLWDWTLrq5zJ44DRa6Irc401hKiFz4pNEMfMXArl6gYxef/WniEz?=
 =?us-ascii?Q?FhRuSBvPover08Q3WVF9IvZxVr/2+tHg3rxxAsB/g5rtj16ALq+29xXCZ62M?=
 =?us-ascii?Q?775oALiB74Uyf0E0OBzeKd0AVzv5hqmmdlaPxespBk7D0sHW+U1XWI1zoLfA?=
 =?us-ascii?Q?qVjoVDIMSDHPRkwJdzloWKXIRPjcdUALiNQ8aweHVsT/2+0JIUuWJ0AZj451?=
 =?us-ascii?Q?qNDoNEpXbCBAVTPdk3ZXyJKXIWNZxQ1LlhV8+8ICW2sgqf/hxVOUq2TIiXI/?=
 =?us-ascii?Q?+3hnyZLFSJnw09cFXvYkG/jVQyH+PHuU/1vUoo977+ft+WVczjevjZljnXHW?=
 =?us-ascii?Q?gVBO3V8kzNOpojGXBMEyAicHpPcyKWq9oshhYJejzIYg3UhITpUPiRYs+LVB?=
 =?us-ascii?Q?yORZphPYa3RJ3lrk1WXZV57ky6yGa2l9LQOoCT8MKw+NuYp7uamsZQgBIs/u?=
 =?us-ascii?Q?C/5zLcscsPxbMcMVYxd5+xV0JKf2S+nbIz950QyIAIQZIQwrg0MziMEW9hQ0?=
 =?us-ascii?Q?Jbfpg6YGh2z6QeqWRKazYloyXAYMuLXv/KAoMGpAcOCyZ5bFSt4ReQdkj19J?=
 =?us-ascii?Q?hwhvp3jqqtYtpcRUW+lvc14H1T71umYtihqRFe9rXziMgzmkXx2RLLi3B32e?=
 =?us-ascii?Q?xFhcqFoNV5cLAo//XdVMEV3rCB81Tue3Mb5aimDhe1sOU+FcUqVepBQq8Rdc?=
 =?us-ascii?Q?zW9MCh1VAZpCdXhYwIR2Q5z5M+UEWznitcrQi8XeOGnBmeN6ETckuWtiJNp3?=
 =?us-ascii?Q?AogMeSManAnV4bv1HB9xwaNx7HFv6SrGdRW0iETrqXH7Eq4g7FN8+N9DDgY/?=
 =?us-ascii?Q?PGkqz25YOiKH5UB35BI0dBBjEDvNc8rAd8zhPq5EmAh/54LSG9dzNkDBMGbh?=
 =?us-ascii?Q?CVvifeiIkr5UIr+vrdHrsYVOyA7UY9x7dqO2Fu22FBRfP3EzMZqAjrP7u1c5?=
 =?us-ascii?Q?ukRzydG9iSOfcVuajY/VX1qmgxNG3YSIONPlvM7h7nfHZ4wJ9D64/NAOvfhk?=
 =?us-ascii?Q?pZZNDQKZj6gtP8EbUgqNisqCb4z7clIT84svQgJ55OayJFkYDougZbwqShCI?=
 =?us-ascii?Q?0dXS03HIt2Pp++Ym82uxQo61Ro9kC4nGrehm06UBwJHYDOk1PJ44AndaRV1Q?=
 =?us-ascii?Q?GQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c1b865a-020f-4e1a-f26b-08dab86863d1
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 22:12:51.8565
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dArlA8vg256GJb9szVd0uMHDOLhIYP3VLbNQExs51g/J8G+7HaWHznDUpxfWpcbzmxx/KuaNj6cUISCcABNoapT/kqjkbNNM+bJthVOLMFE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5379
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 mlxlogscore=999
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210270125
X-Proofpoint-ORIG-GUID: MBSqgzy2geslFhVNMPzv1FvfDIhZMkb9
X-Proofpoint-GUID: MBSqgzy2geslFhVNMPzv1FvfDIhZMkb9
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yujie Liu <yujie.liu@intel.com> writes:
> On Thu, Oct 27, 2022 at 03:50:17PM +0800, kernel test robot wrote:
>> Greeting,
>> 
>> FYI, we noticed WARNING:possible_recursive_locking_detected due to commit (built with clang-14):
>> 
>> commit: bed2685d9557ff9a7705f4172651a138e5f705af ("[PATCH 2/2] fsnotify: allow sleepable child flag update")
>> url: https://github.com/intel-lab-lkp/linux/commits/Stephen-Brennan/fsnotify-Protect-i_fsnotify_mask-and-child-flags-with-inode-rwsem/20221018-131326
>> base: https://git.kernel.org/cgit/linux/kernel/git/jack/linux-fs.git fsnotify
>> patch link: https://lore.kernel.org/linux-fsdevel/20221018041233.376977-3-stephen.s.brennan@oracle.com
>> patch subject: [PATCH 2/2] fsnotify: allow sleepable child flag update
>> 
>> in testcase: boot
>> 
>> on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G
>> 
>> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
> Sorry, this report is for the v1 patch which seems to be obsolete now.
> Please kindly check the details in report, if the issue has already been
> fixed in v2, please ignore this report. Thanks.

Thanks for the message, I'm looking deeper into it now. If it were to
happen on the v1, it may very well occur on v2.

Thanks,
Stephen