Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Oct 2022 21:32:24 +0000
To:     =?utf-8?Q?Jos=C3=A9_Exp=C3=B3sito?= <jose.exposito89@gmail.com>
From:   =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc:     jikos@kernel.org, benjamin.tissoires@redhat.com, spbnick@gmail.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mia Kanashi <chad@redpilled.dev>,
        Andreas Grosse <andig.mail@t-online.de>
Subject: Re: [PATCH] HID: uclogic: Add support for XP-PEN Deco LW
Message-ID: <2m7M7XFEGHGOu6Le-GK_9kDuuA3BltmE1I17zDsok382TFmgO2oDamLv7cWcXjYLdzdgwQli7Qe98xoe0tuVc4bg7sRbFG2LFZ6iYn0s3Fk=@protonmail.com>
In-Reply-To: <20221027211021.230325-1-jose.exposito89@gmail.com>
References: <20221027211021.230325-1-jose.exposito89@gmail.com>
Feedback-ID: 20568564:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi


2022. okt=C3=B3ber 27., cs=C3=BCt=C3=B6rt=C3=B6k 23:10 keltez=C3=A9ssel, Jo=
s=C3=A9 Exp=C3=B3sito =C3=ADrta:

> [...]
> +/**
> + * uclogic_params_ugee_v2_has_battery() - check whether a UGEE v2 device=
 has
> + * battery or not.
> + * @hdev:=09The HID device of the tablet interface.
> + *
> + * Returns:
> + *=09True if the device has battery, false otherwise.
> + */
> +static bool uclogic_params_ugee_v2_has_battery(struct hid_device *hdev)
> +{
> +=09/* The XP-PEN Deco LW vendor, product and version are identical to th=
e
> +=09 * Deco L. The only difference reported by their firmware is the prod=
uct
> +=09 * name. Add a quirk to support battery reporting on the wireless
> +=09 * version.
> +=09 */
> +=09if (hdev->vendor =3D=3D USB_VENDOR_ID_UGEE &&
> +=09    hdev->product =3D=3D USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_L) {
> +=09=09struct usb_device *udev =3D hid_to_usb_dev(hdev);
> +=09=09const char *lw_name =3D "Deco LW";
> +
> +=09=09if (strncmp(udev->product, lw_name, strlen(lw_name)) =3D=3D 0)

Please use `strstarts()` here instead.


> +=09=09=09return true;
> +=09}
> +
> +=09return false;
> +}
> [...]


Regards,
Barnab=C3=A1s P=C5=91cze