Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20221027101159.942843-7-peng.fan@oss.nxp.com>
References: <20221027101159.942843-1-peng.fan@oss.nxp.com> <20221027101159.942843-7-peng.fan@oss.nxp.com>
Subject: Re: [PATCH 6/6] clk: imx93: keep sys ctr clock always on
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-imx@nxp.com, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Jacky Bai <ping.bai@nxp.com>,
        Peng Fan <peng.fan@nxp.com>
To:     Peng Fan (OSS) <peng.fan@oss.nxp.com>, abel.vesa@linaro.org,
        abelvesa@kernel.org, festevam@gmail.com, kernel@pengutronix.de,
        krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
        robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Date:   Thu, 27 Oct 2022 16:05:29 -0700
User-Agent: alot/0.10
Message-Id: <20221027230531.2288CC433D7@smtp.kernel.org>
Precedence: bulk

Quoting Peng Fan (OSS) (2022-10-27 03:11:59)
> From: Jacky Bai <ping.bai@nxp.com>
>=20
> Keep sys ctr clock always on to make sure its register
> can be accessed for cpuidle.
>=20
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/clk/imx/clk-imx93.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> index 74e8d810db7f..91db356564c1 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -238,7 +238,7 @@ static const struct imx93_clk_ccgr {
>         { IMX93_CLK_HSIO_32K_GATE,      "hsio_32k",     "osc_32k",       =
       0x9dc0, },
>         { IMX93_CLK_ENET1_GATE,         "enet1",        "wakeup_axi_root"=
,      0x9e00, },
>         { IMX93_CLK_ENET_QOS_GATE,      "enet_qos",     "wakeup_axi_root"=
,      0x9e40, },
> -       { IMX93_CLK_SYS_CNT_GATE,       "sys_cnt",      "osc_24m",       =
       0x9e80, },
> +       { IMX93_CLK_SYS_CNT_GATE,       "sys_cnt",      "osc_24m",       =
       0x9e80, CLK_IS_CRITICAL},

Please add a comment like

	/* Critical because clk accessed during CPU idle */

>         { IMX93_CLK_TSTMR1_GATE,        "tstmr1",       "bus_aon_root",  =
       0x9ec0, },
>         { IMX93_CLK_TSTMR2_GATE,        "tstmr2",       "bus_wakeup_root"=
,      0x9f00, },
>         { IMX93_CLK_TMC_GATE,           "tmc",          "osc_24m",       =
       0x9f40, },