Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221027053407.421783-1-rekanorman@chromium.org> <Y1ohUyZJItFh3xDs@kroah.com>
In-Reply-To: <Y1ohUyZJItFh3xDs@kroah.com>
From:   Reka Norman <rekanorman@chromium.org>
Date:   Fri, 28 Oct 2022 10:56:56 +1100
Message-ID: <CAEmPcwtZt0RoksByW0OnkNsBiPJ-wHqzR9nuZEwAn3d2m=fyOA@mail.gmail.com>
Subject: Re: [PATCH] xhci: Apply XHCI_RESET_TO_DEFAULT quirk to ADL-N
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 27, 2022 at 5:11 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Oct 27, 2022 at 04:34:07PM +1100, Reka Norman wrote:
> > ADL-N systems have the same issue as ADL-P, where a large boot firmware
> > delay is seen if USB ports are left in U3 at shutdown. So apply the
> > XHCI_RESET_TO_DEFAULT quirk to ADL-N as well.
> >
> > This patch depends on "xhci: Add quirk to reset host back to default
> > state at shutdown".
>
> What is the git commit id of that change?

It hasn't been merged in mainline yet, only in the xhci tree:
https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?id=feb0b04b09c82589af65c84398b7d3fefaa7b7ac&head=for-usb-linus
Should I add the commit id from there? Or add the lore link?

>
> And is this needed in stable kernels?  If so, how far back?

Sorry, I'm not sure how to answer that properly.
It looks like most ADL-N support was added starting from 5.16.
The issue it fixes is a ~20s boot delay in the specific case of booting from S5.
It probably makes sense for it to go wherever the ADL-P patch goes.

>
> thanks,
>
> greg k-h