Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Jan Kara <jack@suse.cz>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Amir Goldstein <amir73il@gmail.com>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: [PATCH v3 0/3] fsnotify: fix softlockups iterating over d_subdirs
Date:   Thu, 27 Oct 2022 17:10:13 -0700
Message-Id: <20221028001016.332663-1-stephen.s.brennan@oracle.com>
In-Reply-To: <20221021010310.29521-1-stephen.s.brennan@oracle.com>
References: <20221021010310.29521-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PlXbKXBORVZjDmC4XBkVFTo1wRVRZDG7QBOVykU1tFMKkwMx+m5GWq0ueQ5B?=
 =?us-ascii?Q?eOWvqxa0QrPjibnoyfJufDG4Q3HWzOeJv5zVkawsiJbl67cZij3EstyV6bvw?=
 =?us-ascii?Q?eR7EpDLCnceD2/Orjvyu2qF9ETswcMSm22ZiKVhJvkZBKoOxHuws+QTDuYJb?=
 =?us-ascii?Q?9sP3z/mdRl/yNEMUxIYkEnJHSfVrGQiC2LWZS9tmMKz9iMfoh89ThqvYyd72?=
 =?us-ascii?Q?ZejDxyENslekdPFOam+JsyNOAUEfZKe5xLKQQX6Mm5Q/t8PMymEHcS6jVdmt?=
 =?us-ascii?Q?gVj1UIUXPYuts0m5wJYM2Mp9LRVti21fLIkTj3hTHEXXPVbuOdpZ0hHRlTBH?=
 =?us-ascii?Q?ocBFmvxrkHtgHDzk4oQs6iU6Aj9NXVmbFzp8Y4HEG18ugX9cC34uyb1DMU7d?=
 =?us-ascii?Q?wu5crZNfkiIkcY+dBaO6B1aPk4ak3ckc6GRlgOkUgMuMyUHy8/x9xd4eOoQ2?=
 =?us-ascii?Q?jQNIF16hh7FQwwZuqddyl0GTkbyDa79fHk8mhjQh4UYCvR8F8z0LzZDjB5LL?=
 =?us-ascii?Q?wUmwgkfaN+WGbDPXeTu9fMj9cya0RFd0ZL3jfk8mgqpyKrCuH6ftCWWJSo3D?=
 =?us-ascii?Q?LaWRiErx3lHeDwNuZipyNcP3NeWy4CzLqmOsGuj10dMMyQCKL1s8E6eIasJw?=
 =?us-ascii?Q?TDdZGfzAaMWCc2THuj1CgnxzE5y2ikwNLKPboe1unX0gYC9MHSlxIpvDUxgL?=
 =?us-ascii?Q?DwdqpRa8X4acG7ojtsmxO4Q48kV+qHvXybV8sChkw4MCwcF56i4413pjZ+wK?=
 =?us-ascii?Q?+8bcdL8giM9V/2Fl53ylEdCZ6HlvMVYQwFMgo5sPm0/VpBElvsprMgRD7UQ9?=
 =?us-ascii?Q?n9BLejvl3ZuwoC72Ckp14j1b6z0UP+W8siusbZUL0i7VbHF4ETXB0AZCuCpX?=
 =?us-ascii?Q?nPhYjNkdtkNugehnp+6SKghhKb4zOdHtNDfVHfd7GaEUnu07CBkDKZbSWNYs?=
 =?us-ascii?Q?C4dFmvfjklZBdns4YhcLyQT6ncICahhpGdx4IV6DsoOEMdSHGz0EoKGZFOom?=
 =?us-ascii?Q?oNuQpHrYFEn/BlztB7TEUHhO9nXh7JB/T4zy0U11Ei6yJNrpCnD3yALoG7EP?=
 =?us-ascii?Q?Z1QXLKKDvawtk9uo0lfDABezWjJyiRyfa9N8RWQDVUmO6yqG+Ia9+7leZTns?=
 =?us-ascii?Q?+FJc0HoxrlUAJKnR3UvGr7GRMFG39DRu7J5fan9u3cr2cxKG6tOKWM3Z47XD?=
 =?us-ascii?Q?o2N4IYEOKO4sfg6lfrTAeNqFIMM2NgHsWKnWHSryfaQEbYrOLMOGmDW6Ci/k?=
 =?us-ascii?Q?2PtqrDnU9JJHvA684WbkAPywYFPrNMq4QdBCOY8bmMURnwlEuiPcznXGmT2b?=
 =?us-ascii?Q?WnSD3kd3m67lO5/sCDUlzXnM9EWH8r55coxUPrqzqSUDXOoXQaN/BT5UNkQK?=
 =?us-ascii?Q?olzuxdda8KPafmJ1OzkiAPd2OH9mmCT9G83SAnlWD370KraL7Km3iiOBDEvA?=
 =?us-ascii?Q?3NlbUVXQk5ow1+Q07bL6rcuV3jdlpinquAEmAVyhQQz7OHyenEt17+yHm2vX?=
 =?us-ascii?Q?Vh+R0gEqDezMuRmbEo7NMmdFzmARxB9JxN/rQO3hfoRFvI1ZrsNBOxuNZ2g6?=
 =?us-ascii?Q?FFKUOsxv9tRL9UsYDQWJl3CZfGjy6bhshR8GH2vK6m/7plA1UM5qe3qfEguj?=
 =?us-ascii?Q?Jw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f74fd9c4-80b2-48bb-1892-08dab878cc74
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 00:10:19.3982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2pS+WYKyzDiC2H3gYHfDbSFOoxbyanXQC0mloQQa8EjuVbWB3qmkHni4TrifkXm4uJ2Vt5lWbwFaTdIv0QXLKLCNnLoNgYWEmpcXpLZpT5M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4130
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 mlxlogscore=941
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210270138
X-Proofpoint-GUID: AWmWzrcAWuai_5eUifGj5kR6_0sdu4-o
X-Proofpoint-ORIG-GUID: AWmWzrcAWuai_5eUifGj5kR6_0sdu4-o
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi all,

Here is v3 of the patch series. I've taken all of the feedback,
thanks Amir, Christian, Hilf, et al. Differences are noted in each
patch.

I caught an obvious and silly dentry reference leak: d_find_any_alias()
returns a reference, which I never called dput() on. With that change, I
no longer see the rpc_pipefs issue, but I do think I need more testing
and thinking through the third patch. Al, I'd love your feedback on that
one especially.

Thanks,
Stephen

Stephen Brennan (3):
  fsnotify: Use d_find_any_alias to get dentry associated with inode
  fsnotify: Protect i_fsnotify_mask and child flags with inode rwsem
  fsnotify: allow sleepable child flag update

 fs/notify/fsnotify.c             | 115 +++++++++++++++++++++-------
 fs/notify/fsnotify.h             |  13 +++-
 fs/notify/mark.c                 | 124 ++++++++++++++++++++-----------
 include/linux/fsnotify_backend.h |   1 +
 4 files changed, 185 insertions(+), 68 deletions(-)

-- 
2.34.1