Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ee37b5a1-5afc-71b3-f777-add295d9ce17@linaro.org>
Date:   Thu, 27 Oct 2022 21:22:10 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 2/3] dt-bindings: regulator: Add regulator-output binding
Content-Language: en-US
To:     Zev Weiss <zev@bewilderbeest.net>, Rob Herring <robh@kernel.org>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Naresh Solanki <naresh.solanki@9elements.com>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        openbmc@lists.ozlabs.org
References: <20220925220319.12572-1-zev@bewilderbeest.net>
 <20220925220319.12572-3-zev@bewilderbeest.net>
 <20220929210714.GA2684335-robh@kernel.org>
 <YzYNt+IQRomycRLs@hatter.bewilderbeest.net>
 <Y1rRCq9Kdd2zPPkw@hatter.bewilderbeest.net>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <Y1rRCq9Kdd2zPPkw@hatter.bewilderbeest.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/10/2022 14:42, Zev Weiss wrote:
> On Thu, Sep 29, 2022 at 02:27:20PM PDT, Zev Weiss wrote:
>> On Thu, Sep 29, 2022 at 02:07:14PM PDT, Rob Herring wrote:
>>> On Sun, Sep 25, 2022 at 03:03:18PM -0700, Zev Weiss wrote:
>>>> This describes a power output supplied by a regulator, such as a
>>>> power outlet on a power distribution unit (PDU).
>>>>
>>>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>>>> ---
>>>> .../bindings/regulator/regulator-output.yaml  | 47 +++++++++++++++++++
>>>> 1 file changed, 47 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> new file mode 100644
>>>> index 000000000000..40953ec48e9e
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> @@ -0,0 +1,47 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +
>>>> +$id: http://devicetree.org/schemas/regulator/regulator-output.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Regulator output connector
>>>> +
>>>> +maintainers:
>>>> +  - Zev Weiss <zev@bewilderbeest.net>
>>>> +
>>>> +description: |
>>>> +  This describes a power output connector supplied by a regulator,
>>>> +  such as a power outlet on a power distribution unit (PDU).  The
>>>> +  connector may be standalone or merely one channel or set of pins
>>>> +  within a ganged physical connector carrying multiple independent
>>>> +  power outputs.
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    const: regulator-output
>>>> +
>>>> +  vout-supply:
>>>> +    description:
>>>> +      Phandle of the regulator supplying the output.
>>>> +
>>>> +  regulator-leave-on:
>>>> +    description: |
>>>> +      If the regulator is enabled when software relinquishes control
>>>> +      of it (such as when shutting down) it should be left enabled
>>>> +      instead of being turned off.
>>>> +    type: boolean
>>>
>>> I'm not too sure about this one as there could be various times when
>>> control is relinquished. It is userspace closing its access?
>>> driver unbind? module unload? Does a bootloader pay attention to this?
>>>
>>> Rob
>>
>> Thanks for the feedback, Rob -- I'll admit I was a bit unsure how to 
>> approach that, and this may well not be the right answer.  What I'm 
>> really aiming for is an appropriate way to express that regulator 
>> on/off state should only ever be changed by explicit (external, e.g. 
>> userspace) request, never as any sort of default/automatic action.  
>> The two obvious things to guard against there seem to be automatic 
>> enablement during initialization and automatic disablement on de-init 
>> (shutdown, unbind, etc.).  The former I think can be avoided by simply 
>> not setting regulator-boot-on, so I added this as a corresponding 
>> property to avoid the latter.
>>
>> I'm definitely open to suggestions for a better approach though.
>>
> 
> Ping...
> 
> Would something like this be preferable as a more direct description of 
> that?
> 
>    regulator-manually-controlled:
>      description: |
>        The regulator should never be enabled or disabled automatically,
>        only when explicitly requested by an external actor (e.g.  
>        userspace).
>      type: boolean

This looks like putting policy and OS behavior into DT. I guess it easy
to understand in case of Linux which disables unclaimed regulators
during. But what if other system/firmware does not behave like that?

And what is the "external actor"? OS is not an external actor?

I could not get the problem you want to solve with this property - I
looked at cover letter and at commit msg.

I can only imagine that you want to keep regulator on, after last its
user disappears... but for what purpose? Do you expect that after system
shutdown the pin will stay high so regulator will be also on? If so, you
need hardware design, e.g. with some pull up (if control is over GPIO).

> 
> That would leave the question of which property takes priority if both 
> regulator-manually-controlled and regulator-boot-on are set -- should 
> the binding document the answer to that?  (I personally don't have a 
> strong opinion on which it should be.)


Best regards,
Krzysztof