Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1672621rwi; Thu, 27 Oct 2022 19:57:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Wi4zlt77HTSm+FWk4xG2ZlECnV+3FCybAGPQZnuq17yDAR+aY1PD0KtJOmkM/C1HHzuQj X-Received: by 2002:aa7:810d:0:b0:563:1fa6:fecc with SMTP id b13-20020aa7810d000000b005631fa6feccmr52934554pfi.24.1666925833871; Thu, 27 Oct 2022 19:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666925833; cv=none; d=google.com; s=arc-20160816; b=P+pQsP9oYASkz8W/UM2qH5rTIW/RCDK7tB6Ubb9WqPKrZvet+rlBNfdLY6BL+zfonp SV19IwQgx/Y4i0b7icXjC3rLwOiIKeRVS0Q+KjWP14vQkMBf1xLmwbmIKCzxc2k5g22l hPthpVgoGmG9qYgbcRnWLTrMvH3S+tCTs3Ukv6pwkUdbHSi3VxR/yXvYW68bM2NVxily E+jLohyve2aIAjg/nMcVnorz5q+s5yqmF9Q1S4bvZhQlGqHqzPiUqG1DyXBq0cci+p4p YG7xbXU9JqRddJWnnL76X7R3ENgYA8fskEaWpdiWGsRryfhtcbV89le02SQgL7l799hR f/FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ePAnUqBsHfpEZfy8Hk6sJVchTl2kYrXoUq+WAcUoWDA=; b=OkdNBLg1V0yrRF4MLyPEHxZfoim85L4Gj1Zy41lPcui2msTT06/rTaGgtakp7bkdjl qY5pNPLzV+pzybryxQKUriGHwX2Xmlggiq5Vbz5GHr9+gb9+VPJg55dDxorG02eCLIPn 7chD//mjJQPpEz3pBwCdcUcPJgYQiDWwAnuaU7H+j5+uxvuoPimlfBgHTtgTIbhL/5Hv 1dPkDeYVkUzk30Xt5Az+GpT/MNw3YZ0YfIIYeKTpTo0dvKy1sNqo9s4xkFyS0fvI+kV7 jbpv0SNKkWDBsPpnPSGaaUmk08JJy9xJhM0sXqcKAQnpRuP3S7a9aU0wcDKl3aB/fgtQ G7Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=ZNZOHoy8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j63-20020a638042000000b0043c05df34c0si3843195pgd.411.2022.10.27.19.57.02; Thu, 27 Oct 2022 19:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=ZNZOHoy8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236221AbiJ1CeP (ORCPT + 99 others); Thu, 27 Oct 2022 22:34:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235291AbiJ1CeO (ORCPT ); Thu, 27 Oct 2022 22:34:14 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABEB8BCBAE; Thu, 27 Oct 2022 19:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=ePAnUqBsHfpEZfy8Hk6sJVchTl2kYrXoUq+WAcUoWDA=; b=ZNZOHoy8NsrV2R7T2RHyOEnnLO El93uHcdcPtvooH/1/jUJkhref5Yzh5UUxmkjA8e0CzFFGms4qY80y3yHqrotbI2ObZznWKryK3W8 lvqZOVHceYpxEm24dCbauiXa0BpHEXDgelJRsw1tbSeowLk+UiH43/8BBPikOcVroWqUkToS6snx3 gMr3bs/XQ70IzefyXBqOO0ri4+MoK3C8swTqXFe0U/K2UkoGSyxoiAzEpoVNHbw/cnv11KvRnpJZ5 lmIOUlcr6mxlYpgDkjvFatgSAkzgOjo2/RgTXwm2oULj9LGklOJ6uDFNU1J0XP9JV+pFhGUGurXYh mE4k0MdA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1ooFBx-00EorN-1f; Fri, 28 Oct 2022 02:33:53 +0000 From: Al Viro To: Christoph Hellwig Cc: David Howells , willy@infradead.org, dchinner@redhat.com, Steve French , Shyam Prasad N , Rohith Surabattula , Jeff Layton , Ira Weiny , torvalds@linux-foundation.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/12] [target] fix iov_iter_bvec() "direction" argument Date: Fri, 28 Oct 2022 03:33:48 +0100 Message-Id: <20221028023352.3532080-8-viro@zeniv.linux.org.uk> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221028023352.3532080-1-viro@zeniv.linux.org.uk> References: <20221028023352.3532080-1-viro@zeniv.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Al Viro --- drivers/target/target_core_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index 28aa643be5d5..55935040541b 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -337,7 +337,7 @@ static int fd_do_rw(struct se_cmd *cmd, struct file *fd, len += sg->length; } - iov_iter_bvec(&iter, READ, bvec, sgl_nents, len); + iov_iter_bvec(&iter, is_write, bvec, sgl_nents, len); if (is_write) ret = vfs_iter_write(fd, &iter, &pos, 0); else @@ -473,7 +473,7 @@ fd_execute_write_same(struct se_cmd *cmd) len += se_dev->dev_attrib.block_size; } - iov_iter_bvec(&iter, READ, bvec, nolb, len); + iov_iter_bvec(&iter, WRITE, bvec, nolb, len); ret = vfs_iter_write(fd_dev->fd_file, &iter, &pos, 0); kfree(bvec); -- 2.30.2