Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Jonathan Zhang (Infra)" <jonzhang@meta.com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Robert Richter <rrichter@amd.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Terry Bowman <terry.bowman@amd.com>,
        Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 0/2] efi/cper, cxl: Decode CXL Protocol Errors CPER
Thread-Topic: [PATCH 0/2] efi/cper, cxl: Decode CXL Protocol Errors CPER
Thread-Index: AQHY2pI/27foXU1qhE2+ZZlknLVcfa4ZgNaAgAZkhACAAAReAIABRD4AgAIRxgA=
Date:   Fri, 28 Oct 2022 03:07:41 +0000
Message-ID: <D9381C12-A585-4089-873B-3707C17823D3@fb.com>
References: <20221007211714.71129-1-Smita.KoralahalliChannabasappa@amd.com>
 <63531a9dd51b9_4da32946c@dwillia2-xfh.jf.intel.com.notmuch>
 <151c093f-1e92-1c8e-957b-8781e488626a@amd.com>
 <63587b16dbb3_14192944c@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <69a14ac2-510e-fd8f-0854-60805a150663@amd.com>
In-Reply-To: <69a14ac2-510e-fd8f-0854-60805a150663@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x5wxEvQw7/xUFEu3lGuvpAbOPChQBdbrY6b7qeTyZGYnZmh80YZvk4Wwsnbk?=
 =?us-ascii?Q?dHCnbI4LQQKHI699CljGvv/KUZ6ODb7Hhw3QWJf2F+O5XiflcDvltIMtrBib?=
 =?us-ascii?Q?KSBNSbGYs58FuMl+yQVfkAikqP1GBBipa5CfzoHUuidRKDGKLn/9wj4vtFXd?=
 =?us-ascii?Q?ypTeY8pE1kQddgR/0a5HUUUhZcMj1vXhBqltc1RjVbyLcrGPpWPvjysHrFMp?=
 =?us-ascii?Q?6lx04ZVnWCK95RJBEcDM20zKwf3bh/RqmvXUXZP3hsVGdktWJAp/kdQaV3jU?=
 =?us-ascii?Q?j6ySS+Bs3p6oh8IXucwZV0ubYnRShU1qW/bLBbV0ttr9mXQlWiQ/Dsq8v4oB?=
 =?us-ascii?Q?XFo/dS9bg8FLSRDR0Gd7nNwRSu6HCpjYdpl5w6GqC4LjCGrHcqLkqonFCFyn?=
 =?us-ascii?Q?+LCfDdl7zt8YKkejDLNp50JKeS0pLgNcYDH23SELMJXH7kvQj3MerfGnin+m?=
 =?us-ascii?Q?lwcdvYfbnSr2Mo1QB+Cf/bhjH8EZpgI1Azp4clYtYFFYhcs27bfTcozugqS+?=
 =?us-ascii?Q?uJ03DKTQgQpMuuBQDFXxeoJxhxIDZamzCCbATn8HzVFcCbCAthItoQvuN9v+?=
 =?us-ascii?Q?oq6+fjXkZMdmOg3cg0uh6vYivAzJJ/UJ1JhqygZMKvMlZi1WzKUijNdmY+V+?=
 =?us-ascii?Q?xpzUv3nCco2r9zrpZ/N/c+aWrh4LjWn5S8P8FpFWlP3Zvo3+crwX6DlTcYJ4?=
 =?us-ascii?Q?tf2nVm2ukmxiYXQRNA8NmFHDz10IQkU8hfcb0q12Q3btte8P5AovXa79cCH3?=
 =?us-ascii?Q?2coXg+t4zggnrDg+idaCStbR1PLxk/iNv8dB5owCG9WiirYq1mMhK0HnMrCo?=
 =?us-ascii?Q?pF74zLBCQFP86CfMdDqJCLFsUcVf3sgBXgHIEhE6s46vCUZ7BzcjDYSH/KiR?=
 =?us-ascii?Q?42ai4Nxmb5aQNZk1bP8vuT8O5O1Z0AvLMlaAP7hqIhf+HAgAWFGLYYgH+xZV?=
 =?us-ascii?Q?pv4pxv1C+iR2NZHgsuSZ60FxTVbXIoMq5FhReqoft/hr4DI+z9p1nX1ay2yu?=
 =?us-ascii?Q?ldZiDUFzziBo26fNkk6fFZMlmC/eY0L8VxCHIc32rKFGT55mpON3FvEpNCZY?=
 =?us-ascii?Q?R0YfnewF1cAeaFLbP78b2N19gTyonHLGwNRQEb+2e3hjKV/IKbd5aAX19RTx?=
 =?us-ascii?Q?GpNLu8yapeZmLoi6PUZrBB5s8fsWw/jtXQ3Z/8mrNduFymh2LtF09waDzZc5?=
 =?us-ascii?Q?X6lCpoLiQOwh8L5nZPFFkuGzPg7LidhNcIhyIMcsbNo+6NPESjAoQR1jwtjQ?=
 =?us-ascii?Q?Ij58+YUSVwJhUyja5alNoXu+roCQmNLCRHNmvQ1EqwEIhaO6StFUdRfNW/uB?=
 =?us-ascii?Q?qBcxehT8+AVyMSTvS90T97c1U73mRRCGa3JqkkewhUL3892MCrOtSCHu0gQM?=
 =?us-ascii?Q?+EHysAPDlJkKon8/8qsqrPbSR/6jxPoW/ddjxxD2iQaGrSE/lJ9iYq+XmHXX?=
 =?us-ascii?Q?jqBkhQsxQs8jlB1eU01KwO/DvJKdqiiUHlzwifDNV5ZCtlTEom6r6Fnd+rYZ?=
 =?us-ascii?Q?fxgGp72mYmgMkGzGthuENCNes9WrjEWdbPiwmfIfxNnz6f0KBQGkh8cJE0Md?=
 =?us-ascii?Q?eLRmsstA3i6gtFROhjmBjzAOk1Vmu8WiSz3Pec8021EoMns8WC2TnSeFHjYs?=
 =?us-ascii?Q?ixfRBLmS5x2fNbsm0v3INPo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AA7BBDF738DC084498A3F6A7CB66E069@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR15MB4969.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d181e877-f643-4e91-ba27-08dab89193a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 03:07:41.2692
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EyXGqlC49jzT5H2rPqiMYLWOYadfJWz+Yw0bDEyrxpyiORHXNfXLMKfJf9PFefy4WlG+VdTMEy8lrC2x0lNAfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2553
X-Proofpoint-GUID: PQPFcz1zDgSkalnBTi8ef8mWeeINXwZS
X-Proofpoint-ORIG-GUID: PQPFcz1zDgSkalnBTi8ef8mWeeINXwZS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_07,2022-10-27_01,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Oct 26, 2022, at 12:31 PM, Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com> wrote:
> 
> On 10/25/2022 5:11 PM, Dan Williams wrote:
>> Smita Koralahalli wrote:
>>> Hi Dan,
>>> 
>>> On 10/21/2022 3:18 PM, Dan Williams wrote:
>>>> Hi Smita,
>>>> 
>>>> Smita Koralahalli wrote:
>>>>> This series adds decoding for the CXL Protocol Errors Common Platform
>>>>> Error Record.
>>>> Be sure to copy Ard Biesheuvel <ardb@kernel.org>, added, on
>>>> drivers/firmware/efi/ patches.
>>>> 
>>>> Along those lines, drivers/cxl/ developers have an idea of what is
>>>> contained in the new CXL protocol error records and why Linux might want
>>>> to decode them, others from outside drivers/cxl/ might not. It always
>>>> helps to have a small summary of the benefit to end users of the
>>>> motivation to apply a patch set.
>>> Sure, will include in my v2.
>>> 
>>>>> Smita Koralahalli (2):
>>>>>    efi/cper, cxl: Decode CXL Protocol Error Section
>>>>>    efi/cper, cxl: Decode CXL Error Log
>>>>> 
>>>>>   drivers/firmware/efi/Makefile   |   2 +-
>>>>>   drivers/firmware/efi/cper.c     |   9 +++
>>>>>   drivers/firmware/efi/cper_cxl.c | 108 ++++++++++++++++++++++++++++++++
>>>>>   drivers/firmware/efi/cper_cxl.h |  58 +++++++++++++++++
>>>>>   include/linux/cxl_err.h         |  21 +++++++
>>>>>   5 files changed, 197 insertions(+), 1 deletion(-)
>>>> I notice no updates for the trace events in ghes_do_proc(), is that next
>>>> in your queue? That's ok to be a follow-on after v2.
>>> Sorry, if I haven't understood this right. Are you implying about the
>>> "handling"
>>> of cxl memory errors in ghes_do_proc() or is it just copying of CPER
>>> entries to
>>> tracepoints?
>> Right now ghes_do_proc() will let the CXL CPER records fall through to
>> log_non_standard_event(). Are you planning to add trace event decode
>> there for CPER_SEC_CXL_PROT_ERR records?
> 
> Thanks! Yeah its a good idea to add. I did not think about this before.
> I will send this as a separate patchset after v2.
> 
> I think with this cxl cper trace event support and Ira's patchset which traces
> specific event record types via Get Event Record, we can start the userspace
> handling probably in rasdaemon?
Yes, I think this makes sense. rasdaemon could aggregate data and provide user
with full picture:
* Memory errors from both processor attached memory and CXL memory.
* CXL protocol errors.
* CXL device errors.
Such errors may be handled either firmware first or OS first.

> 
>> 
>> I am not sure if the CXL CPER to trace record conversion belongs there,
>> or somewhere closer to trace_aer_event() invocations since the CXL
>> protocol errors are effectively an extenstion of PCI AER events.
> 
> Right, I will keep it simple in v1 and get the comments about the placement..
> 
> Thanks,
> Smita
> 
> 
>