Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaolei Wang <xiaolei.wang@windriver.com>
To:     shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com
Cc:     l.stach@pengutronix.de, linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] soc: imx8m: Increase the clock enable before reading the register
Date:   Fri, 28 Oct 2022 12:14:18 +0800
Message-Id: <20221028041418.4033261-1-xiaolei.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RVToqHxa6VZzTAiNAKZJk4pZ4Pb/3EwA4KHEGU2zMIYK7nQyJCOU3gPtp73M?=
 =?us-ascii?Q?W/168+pJ16FQCq7aso1Xzd8rDKg7gkpqWlmmBEdu1qhhljwN1ZIJpGIMi424?=
 =?us-ascii?Q?33vDNBSxtkMsotx4723S2jxaX8BOthjNYaaNk6UuHmwlShJ8AZGtlleRWx3x?=
 =?us-ascii?Q?ujkmsCzUeidXcHkQ5+g9/fItQYXjWWceirsRXLIxXHoDmWQ+50w9GxyLA8nM?=
 =?us-ascii?Q?GeeZVCabSbFeYGFbKNlYfC7r4DPNJ9lNCVQ+CIeotEwtDTxhc3S8AQaTmJfJ?=
 =?us-ascii?Q?monKHs26H5u5G9XW8DjdPSqZDKiBeq6aXVWOUiCNt1nHufCT54pXEeGwtbYZ?=
 =?us-ascii?Q?Gi/7Z9mAmNpyjhb4mYalciQwIneXbnsc6N1FbUBjZ2JBOfmt8z8BOFKg4u50?=
 =?us-ascii?Q?UY418BWMEXytk4q0tFtu5thvoKddJmxUBG1nc/3aC3PQIvaXHcIrAm/iC1iI?=
 =?us-ascii?Q?gKygae0sy8Xo+Jf+IpGh/2J2S2f+nxe2vGt5wofR8nmGIgb2jcSEzBe4cRrV?=
 =?us-ascii?Q?0QOhfu0QZu0+6eqMsOzGExHPPZ4NZ78K3RvmmS95sEML+ZAPVcQuGGuI5XKn?=
 =?us-ascii?Q?Hwdo/FTJLl3MFNTbhb/5CuiZQUFeFvLjCACLiGZQNL3VRExYtP0320bGw5Dx?=
 =?us-ascii?Q?CR1Y5BcyTOz82lbJUq2mp7oZCadILSMc30YqLr8nc595x9GXXCHlcMO8dV1J?=
 =?us-ascii?Q?+tkvzhb2rPjpWFGFIxrbyOc8l9sfOhA7v0aKBiJe2BxcwULVyerGM9988HbA?=
 =?us-ascii?Q?6Ue6+FgelgFUROp2uc1rzRE92JjwOHOPbn3MxFehhK9FgXjk7Pl/t2Ew3UiY?=
 =?us-ascii?Q?oBfPj4sR2ZZGt/gpoITokFYvP28IP3ON0/X/SML9qZNCLEA8ynLpcw8A03RS?=
 =?us-ascii?Q?dIfnHq84h7deLNYRKr42K/m5CBNlaD+F1oXQLoz6Zli50TAqof2iM0qGWKvs?=
 =?us-ascii?Q?sL7WTaVSjB1d3drad86qijh1l1i1DnZXwSylY3jUWzH5tNyhrV2GPqaiT6eQ?=
 =?us-ascii?Q?sDKROxgGXWY2EGkjdKcoh4pHEt2fSrnJ8dLDSXAwKSbbccGhZn3GOyVbsa7h?=
 =?us-ascii?Q?XrzlpUiAGzoFsqSmqjuvCwhkCHVp4tuprpFHXzEpD4gfhl0cdpE2/bYwOZn5?=
 =?us-ascii?Q?0IyosqlqEoxHs+S/e+zEXbCmDloRoYSUA4GeXVitE5Z5/Dxhst9F7PJKsHZO?=
 =?us-ascii?Q?1L1vsDt/9UF2WNwwyMrGN+5p2Pd2Y7efQok3EAWoz03AWGXnveQ2E/G6BPxA?=
 =?us-ascii?Q?oRYN+znDQ5ioGVnPCoFu+mmhz9W0++waH5qNj8uF07mXoYLel3wKhnxS1Idl?=
 =?us-ascii?Q?1t6o9ZcnweXv5C239YUAgtYb6nt1NzPhBGFWNPZO2FUWjBKJhsDdIbHvpTue?=
 =?us-ascii?Q?L+zvvLSp1yr/IBtNhOlmslGMp0pOWE9BQjTJENMSz+tlscwTgiOTT6aM2P7j?=
 =?us-ascii?Q?97HGC+7g3nVbID5a/TxtS3xyutKp3O+cFTJfS8I1NSeKkYekovJqY6SLBlZJ?=
 =?us-ascii?Q?P6x+TVTCWy8GGZcy0qyV/rtVkYNgr+xE4xkPtGNPifyiT5w23Egx9YZYxglj?=
 =?us-ascii?Q?U9AjZrV0NwqjvvChJKu/zmOKaDBSziF5On53cJhP0qJEPYfUKS9d4+44ZIJO?=
 =?us-ascii?Q?FQ=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5a6c5f2-890d-4101-8a3d-08dab89aeebe
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 04:14:39.8003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mYMp/CLslnFF2rRlgAS6Zfy5W3BFIIiTl5rkk69X4qa6kLqk20yXR27ocDty/jPdpq5pCbDuJaVEtOfjO6YXXqFYQ2X7juc0A08w9r1JUc0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6787
X-Proofpoint-GUID: snwtmMtRbHOqpTrQoWCy1RKEyt_ev0_H
X-Proofpoint-ORIG-GUID: snwtmMtRbHOqpTrQoWCy1RKEyt_ev0_H
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_01,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0
 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 mlxlogscore=782
 impostorscore=0 clxscore=1011 spamscore=0 lowpriorityscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210280026
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When executing kdump to start the second kernel,
since IMX-OCOTP has turned off the clock, the clock
needs to be re-enabled, otherwise the system will hang.

Fixes: ac34de14ac30 ("Revert "soc: imx8m: change to use platform driver"")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 drivers/soc/imx/soc-imx8m.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index cc57a384d74d..28144c699b0c 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -11,6 +11,7 @@
 #include <linux/platform_device.h>
 #include <linux/arm-smccc.h>
 #include <linux/of.h>
+#include <linux/clk.h>
 
 #define REV_B1				0x21
 
@@ -56,6 +57,7 @@ static u32 __init imx8mq_soc_revision(void)
 	void __iomem *ocotp_base;
 	u32 magic;
 	u32 rev;
+	struct clk *clk;
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-ocotp");
 	if (!np)
@@ -63,6 +65,13 @@ static u32 __init imx8mq_soc_revision(void)
 
 	ocotp_base = of_iomap(np, 0);
 	WARN_ON(!ocotp_base);
+	clk = of_clk_get_by_name(np, NULL);
+	if (!clk) {
+		WARN_ON(!clk);
+		return 0;
+	}
+
+	clk_prepare_enable(clk);
 
 	/*
 	 * SOC revision on older imx8mq is not available in fuses so query
@@ -79,6 +88,8 @@ static u32 __init imx8mq_soc_revision(void)
 	soc_uid <<= 32;
 	soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW);
 
+	clk_disable_unprepare(clk);
+	clk_put(clk);
 	iounmap(ocotp_base);
 	of_node_put(np);
 
-- 
2.25.1