Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 10:51:23 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Slark Xiao <slark_xiao@163.com>
Cc:     bhelgaas@google.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Add vendor ID for Quectel and Cinterion
Message-ID: <Y1tRu3SFMrS3su56@debian.me>
References: <20221028023711.4196-1-slark_xiao@163.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="9Xw69vIUQyybTeYV"
Content-Disposition: inline
In-Reply-To: <20221028023711.4196-1-slark_xiao@163.com>
Precedence: bulk


--9Xw69vIUQyybTeYV
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote:
> In MHI driver, there are some companies product still do not have their
>  own PCI vendor macro. So we add it here to make the code neat. Ref ID
>  could be found in link https://pcisig.com/membership/member-companies
>  and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as
> their IOT modem card's trademark. So you will find 0x1269 belongs to
> Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to
>  Thales.
>=20

The patch description is confusing me.

What about below instead?

```
Add missing vendor ID for Cinterion (which is 0x1269).
```

> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> ---
>  include/linux/pci_ids.h | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90eb9b0..9e2b6286f53f 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -1765,6 +1765,8 @@
>  #define PCI_VENDOR_ID_SATSAGEM		0x1267
>  #define PCI_DEVICE_ID_SATSAGEM_NICCY	0x1016
> =20
> +#define PCI_VENDOR_ID_CINTERION		0x1269	/* Celluar Modules*/
> +
>  #define PCI_VENDOR_ID_ENSONIQ		0x1274
>  #define PCI_DEVICE_ID_ENSONIQ_CT5880	0x5880
>  #define PCI_DEVICE_ID_ENSONIQ_ES1370	0x5000
> @@ -2585,6 +2587,8 @@
>  #define PCI_VENDOR_ID_TEKRAM		0x1de1
>  #define PCI_DEVICE_ID_TEKRAM_DC290	0xdc29
> =20
> +#define PCI_VENDOR_ID_QUECTEL		0x1eac
> +

Why pourring in Quectel ID while this patch is about Cinterion?

Thanks.=20

--=20
An old man doll... just what I always wanted! - Clara

--9Xw69vIUQyybTeYV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1tRuwAKCRD2uYlJVVFO
oxIyAP481XABRghCrwrABNCawateQXhp6C3NFLwLZVLO0YijPwEA1xqi1znSReqk
twlMFSAHZGqaRNpSnb1QKnMSbLCUqQM=
=0ghT
-----END PGP SIGNATURE-----

--9Xw69vIUQyybTeYV--