Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221026132838.GA44037@rdm> <20221026171430.GA5592@nam-dell> <Y1o5mktrnE5rbtCO@kadam>
In-Reply-To: <Y1o5mktrnE5rbtCO@kadam>
From:   jovial umwari <umwarijovial@gmail.com>
Date:   Fri, 28 Oct 2022 07:56:46 +0300
Message-ID: <CAMk1CBNwM3XFPyHVfBnE0K4XWmGX_ZwzBV-sns6Nj7Yutb4YtA@mail.gmail.com>
Subject: Re: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar initializer]
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Nam Cao <namcaov@gmail.com>, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

well for the start it was not giving an error but after  fixing blank
lines  that is when i saw that
Thank you for the hint i  fixed  it

On Thu, 27 Oct 2022 at 10:56, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Wed, Oct 26, 2022 at 07:14:34PM +0200, Nam Cao wrote:
> > On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote:
> > > Using the checkpatch.pl script, found the below errors and  fixed
> > > ERROR: trailing whitespace
> > > CHECK: Please don't use multiple blank lines
> > > warning: braces around scalar initializer
> > >
> > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> > > ---
> > >  drivers/staging/most/dim2/dim2.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> > > index 7a5f80e637a0..28259ce05024 100644
> > > --- a/drivers/staging/most/dim2/dim2.c
> > > +++ b/drivers/staging/most/dim2/dim2.c
> > > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev)
> > >             writel(0x04, dev->io_base + 0x600);
> > >     }
> > >
> > > -
> > >     /* BBCR = 0b11 */
> > >     writel(0x03, dev->io_base + 0x500);
> > >     writel(0x0002FF02, dev->io_base + 0x508);
> > > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = {
> > >     {
> > >             .compatible = "xlnx,axi4-os62420_6pin-1.00.a",
> > >     },
> > > -   {},
> >
> > I'm no expert, but this looks like a null terminator and probably
> > should not be removed.
>
> You're absolutely correct.  Also I tried to see why checkpatch.pl was
> printing an error for this but it doesn't print an error for me.
>
> regards,
> dan carpenter
>