Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d97d668-b967-563b-28d0-54982b1bbeb0@gmail.com>
Date:   Fri, 28 Oct 2022 11:00:43 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v2] PCI: Add vendor ID for Quectel and Cinterion
To:     Slark Xiao <slark_xiao@163.com>
Cc:     bhelgaas@google.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221028023711.4196-1-slark_xiao@163.com>
 <Y1tRu3SFMrS3su56@debian.me>
 <9ec6b2e.17e9.1841cbcf83b.Coremail.slark_xiao@163.com>
Content-Language: en-US
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <9ec6b2e.17e9.1841cbcf83b.Coremail.slark_xiao@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/28/22 10:57, Slark Xiao wrote:
> At 2022-10-28 11:51:23, "Bagas Sanjaya" <bagasdotme@gmail.com> wrote:
>> On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote:
>>> In MHI driver, there are some companies product still do not have their
>>>  own PCI vendor macro. So we add it here to make the code neat. Ref ID
>>>  could be found in link https://pcisig.com/membership/member-companies
>>>  and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as
>>> their IOT modem card's trademark. So you will find 0x1269 belongs to
>>> Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to
>>>  Thales.
>>>
>>
>> The patch description is confusing me.
>>
>> What about below instead?
>>
>> ```
>> Add missing vendor ID for Cinterion (which is 0x1269).
>> ```

Oops, I mean also for Quectel (0x1eac).

>>
> As you said 0x1269 belongs to Thales (not Cinterion), So I write it about the details.
> 
>>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>>> ---
>>>  include/linux/pci_ids.h | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>>> index b362d90eb9b0..9e2b6286f53f 100644
>>> --- a/include/linux/pci_ids.h
>>> +++ b/include/linux/pci_ids.h
>>> @@ -1765,6 +1765,8 @@
>>>  #define PCI_VENDOR_ID_SATSAGEM		0x1267
>>>  #define PCI_DEVICE_ID_SATSAGEM_NICCY	0x1016
>>>  
>>> +#define PCI_VENDOR_ID_CINTERION		0x1269	/* Celluar Modules*/
>>> +
>>>  #define PCI_VENDOR_ID_ENSONIQ		0x1274
>>>  #define PCI_DEVICE_ID_ENSONIQ_CT5880	0x5880
>>>  #define PCI_DEVICE_ID_ENSONIQ_ES1370	0x5000
>>> @@ -2585,6 +2587,8 @@
>>>  #define PCI_VENDOR_ID_TEKRAM		0x1de1
>>>  #define PCI_DEVICE_ID_TEKRAM_DC290	0xdc29
>>>  
>>> +#define PCI_VENDOR_ID_QUECTEL		0x1eac
>>> +
>>
>> Why pourring in Quectel ID while this patch is about Cinterion?
>>
>> Thanks. 
>>
> Patch title is for 2 vendors,  Quectel and Cinterion. May I add 2 different VID at the 
> same time?

Ah! I don't see the patch subject.

Next time, please just send plain-text email, not HTML.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara