Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 08:48:35 +0100
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH v6 3/3] clk: Add Ingenic JZ4755 CGU driver
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     Siarhei Volkau <lis8215@gmail.com>,
        Siarhei Volkau <lis8215@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Message-Id: <ZODGKR.IJ47UDRQGD431@crapouillou.net>
In-Reply-To: <20221027215716.77250C433D6@smtp.kernel.org>
References: <20221027192024.484320-1-lis8215@gmail.com>
        <20221027192024.484320-4-lis8215@gmail.com>
        <20221027215716.77250C433D6@smtp.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Stephen,

Le jeu. 27 oct. 2022 =E0 14:57:14 -0700, Stephen Boyd <sboyd@kernel.org>=20
a =E9crit :
> Quoting Siarhei Volkau (2022-10-27 12:20:23)
>>  diff --git a/drivers/clk/ingenic/jz4755-cgu.c=20
>> b/drivers/clk/ingenic/jz4755-cgu.c
>>  new file mode 100644
>>  index 000000000..d2eb3ae0c
>>  --- /dev/null
>>  +++ b/drivers/clk/ingenic/jz4755-cgu.c
>>  @@ -0,0 +1,346 @@
> [...]
>>  +static void __init jz4755_cgu_init(struct device_node *np)
>>  +{
>>  +       int retval;
>>  +
>>  +       cgu =3D ingenic_cgu_new(jz4755_cgu_clocks,
>>  +                             ARRAY_SIZE(jz4755_cgu_clocks), np);
>>  +       if (!cgu) {
>>  +               pr_err("%s: failed to initialise CGU\n", __func__);
>>  +               return;
>>  +       }
>>  +
>>  +       retval =3D ingenic_cgu_register_clocks(cgu);
>>  +       if (retval)
>>  +               pr_err("%s: failed to register CGU Clocks\n",=20
>> __func__);
>>  +
>>  +       ingenic_cgu_register_syscore_ops(cgu);
>>  +}
>>  +CLK_OF_DECLARE_DRIVER(jz4755_cgu, "ingenic,jz4755-cgu",=20
>> jz4755_cgu_init);
>=20
> Is there another driver that probes this device?=20
> CLK_OF_DECLARE_DRIVER()
> is for the situation where we want to probe this device again with
> another platform driver. Please add a comment indicating what that=20
> other
> driver is.

See: 03d570e1a4dc ("clk: ingenic: Use CLK_OF_DECLARE_DRIVER macro")

Cheers,
-Paul