Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: v0ezxqZwsoO3WESLl94/Tla/pLnvVwa7mAyb9HmSPL2JPeUYkA6a7+rZEKkaQWj6U7j082q6Vf
 pK3BZTDUrzU+SPrUphUadqFf0tN0+8QlhvDfhrGF2dsPMxdq+40NqrHUMCTfNO0H1BVuK61uoq
 eG0yo/STcc73LXf7IX1X+F1/61+Pw2mJffwY0KfqdXmU2i4/bFs3ZzUtjxx09oAqQy49jUuKJ8
 Oiu83QCjp9qo86TolAvy4w+tnaZhQqiaGC55n+HedXg33aHQyVJ7S1b/oW5Y4k0/KyJJ7BF3a/
 kC8CkP5kK3MlKcP4nbEA99Xe
IronPort-SDR: n6fxHrUlovb24PAoaFuxz+3ejpokf64cKBpR7guB4OGt1LHQd09osZhib78JD5Bij5W12T55gK
 DL++ueOiIKTcepHOdCYCmBoRV9zuiX/Vil3hzIQmyJMcoCw+M/fM43NGG/uS1x9hH6czjBnyqA
 lQ117x0VYJqhAbGkx3dMAXMioWHtow6LDf3Edmh3vrK2DMxxfwkBz6c4WulFnMY9TD9R+Hn8Rz
 re22tEhQCskhpl+NTbGbiZp1v0eAcwqPAFtFHhAl0TwSUnUVwz7eX/FVeERWwDwnXN/cZ+LpQP
 WSY=
WDCIronportException: Internal
Message-ID: <0bb40ab2-2e80-44a5-79c2-fa4bfe2560d1@opensource.wdc.com>
Date:   Fri, 28 Oct 2022 17:26:24 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH RFC v3 2/7] ata: libata-scsi: Add
 ata_internal_queuecommand()
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, Hannes Reinecke <hare@suse.de>,
        jejb@linux.ibm.com, martin.petersen@oracle.com, bvanassche@acm.org,
        hch@lst.de, ming.lei@redhat.com, niklas.cassel@wdc.com
Cc:     axboe@kernel.dk, jinpu.wang@cloud.ionos.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
        linuxarm@huawei.com, john.garry2@mail.dcu.ie
References: <1666693976-181094-1-git-send-email-john.garry@huawei.com>
 <1666693976-181094-3-git-send-email-john.garry@huawei.com>
 <08fdb698-0df3-7bc8-e6af-7d13cc96acfa@opensource.wdc.com>
 <83d9dc82-ea37-4a3c-7e67-1c097f777767@huawei.com>
 <3ef0347f-f3e2-cf08-2b27-f65a7afe82a2@suse.de>
 <ea0be367-a4e0-3cc2-c4c7-04d8db1714cd@huawei.com>
 <07028dac-d6cc-d707-db08-b92c365a6220@opensource.wdc.com>
 <a3fe8284-d002-36b0-7e09-67f132353088@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <a3fe8284-d002-36b0-7e09-67f132353088@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/28/22 17:14, John Garry wrote:
> On 27/10/2022 23:35, Damien Le Moal wrote:
>>> At what stage do you want to send these commands? The tags for the shost
>>> are not setup until scsi_add_host() -> scsi_mq_setup_tags() is called,
>>> so can't expect blk-mq to manage reserved tags before then.
>>>
>>> If you are required to send commands prior to scsi_add_host(), then I
>>> suppose the low-level driver still needs to manage tags until the shost
>>> is ready. I guess that some very simple scheme can be used, like always
>>> use tag 0, since most probe is done serially per-host. But that's not a
>>> case which I have had to deal with yet.
>> In libata case, ata_dev_configure() will cause a lot of
>> ata_exec_internal_sg() calls for IDENTIFY and various READ LOG commands.
>> That is all done with non-ncq commands, which means that we do not require
>> a hw tag. But given that you are changing ata_exec_internal_sg() to call
>> alloc_request + blk_execute_rq_nowait(), how would these work without a
>> tag, at least a soft one ? Or we would need to keep the current code to
>> use ata_qc_issue() directly for probe time ? That will look very ugly...
>>
> 
> I am not sure if there is really a problem. So libata/libsas allocs the 
> shost quite early, and that is before we try using 
> ata_exec_internal_sg(). Also note that I added patch "ata: libata-scsi: 
> Allocate sdev early in port probe" so that we have ata_device.sdev ready 
> before issuing ata_exec_internal_sg() (sorry if I'm stating the obvious).
> 
> I think Hannes' issue is that some SCSI HBA driver needs to send 
> "internal" commands to probe the HW for info, and this would be before 
> shost is ready. He can tell us more.

OK. Understood.

> 
> Thanks,
> John

-- 
Damien Le Moal
Western Digital Research