Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 10:16:56 +0200
From:   =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>
To:     =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc:     jikos@kernel.org, benjamin.tissoires@redhat.com, spbnick@gmail.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mia Kanashi <chad@redpilled.dev>,
        Andreas Grosse <andig.mail@t-online.de>
Subject: Re: [PATCH] HID: uclogic: Add support for XP-PEN Deco LW
Message-ID: <20221028081656.GA19766@elementary>
References: <20221027211021.230325-1-jose.exposito89@gmail.com>
 <2m7M7XFEGHGOu6Le-GK_9kDuuA3BltmE1I17zDsok382TFmgO2oDamLv7cWcXjYLdzdgwQli7Qe98xoe0tuVc4bg7sRbFG2LFZ6iYn0s3Fk=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2m7M7XFEGHGOu6Le-GK_9kDuuA3BltmE1I17zDsok382TFmgO2oDamLv7cWcXjYLdzdgwQli7Qe98xoe0tuVc4bg7sRbFG2LFZ6iYn0s3Fk=@protonmail.com>
Precedence: bulk

Hi Barnabás,

Thanks for reviewing the patch.

On Thu, Oct 27, 2022 at 09:32:24PM +0000, Barnabás Pőcze wrote:
> Hi
> 
> 
> 2022. október 27., csütörtök 23:10 keltezéssel, José Expósito írta:
> 
> > [...]
> > +/**
> > + * uclogic_params_ugee_v2_has_battery() - check whether a UGEE v2 device has
> > + * battery or not.
> > + * @hdev:	The HID device of the tablet interface.
> > + *
> > + * Returns:
> > + *	True if the device has battery, false otherwise.
> > + */
> > +static bool uclogic_params_ugee_v2_has_battery(struct hid_device *hdev)
> > +{
> > +	/* The XP-PEN Deco LW vendor, product and version are identical to the
> > +	 * Deco L. The only difference reported by their firmware is the product
> > +	 * name. Add a quirk to support battery reporting on the wireless
> > +	 * version.
> > +	 */
> > +	if (hdev->vendor == USB_VENDOR_ID_UGEE &&
> > +	    hdev->product == USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_L) {
> > +		struct usb_device *udev = hid_to_usb_dev(hdev);
> > +		const char *lw_name = "Deco LW";
> > +
> > +		if (strncmp(udev->product, lw_name, strlen(lw_name)) == 0)
> 
> Please use `strstarts()` here instead.

Good point, I'll send v2 in a minute with this change.

Jose
 
> 
> > +			return true;
> > +	}
> > +
> > +	return false;
> > +}
> > [...]
> 
> 
> Regards,
> Barnabás Pőcze