Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b803bcf9-fc47-5239-ffe9-707925f324de@nvidia.com>
Date:   Fri, 28 Oct 2022 10:33:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 04/11] arm64: tegra: Enable XUSB host and device on Jetson
 AGX Orin
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        treding@nvidia.com, thierry.reding@gmail.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com, kishon@ti.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com
Cc:     linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221024074128.1113554-1-waynec@nvidia.com>
 <20221024074128.1113554-5-waynec@nvidia.com>
 <2059dfe5-b084-42a4-7f35-9da9561fc12b@linaro.org>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <2059dfe5-b084-42a4-7f35-9da9561fc12b@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzZPT0tCNndMaHZwdWtheFlBQzhmWUpqQUV1OTNuZ3JNcE5yOFkzWmxFRFBG?=
 =?utf-8?B?VGpjb3UwVEpGZWgyWkpld0dISElsQU03MFB3WXh3d205QUZBcTB6Z0NkcU5s?=
 =?utf-8?B?c1QrZC9PWmM3RVRkNnZudVVjV1lqdkwwYUF4aFQvc2FYeDE3Mklqb0NOanQz?=
 =?utf-8?B?K01TeCt3NXNBR1lYcE9Yd1pVWUtUclh2bU0wQThlZHpmYlBRMjlwOXpOUGdU?=
 =?utf-8?B?em9STlZPakQ2amtZeU43NHhHaHJLdDhtRzRpVnJnNXRDTjdySGZaU1N4UlZU?=
 =?utf-8?B?MHB5RitZQXVwNFdFbUh3cjltc3UzbXZpemx4Z1VLQU1DdW1zZElvMGlRcDA4?=
 =?utf-8?B?dU82R3FwTnAzdDl3OW9XMXNTNkJMQnBRdlR2b2psNG8xbVlSazNFdCtJa21R?=
 =?utf-8?B?dFdlNVNRTmg2NVBCOXpGaS9ncmVKVDc2YlAvZDVPZkpzRW1ES2JjaVRObysx?=
 =?utf-8?B?YWNUbWtBNkRMY3J4dDA5UUhXN3FoQVozcmMrOHNabUh6UWZ6MlcrZ2xWcVdV?=
 =?utf-8?B?SGlKUmdQZjRNbndFV1hXZVh0cUU3V0M3UGh0QUlIb3o0dFpaT2VPdUE0bDBs?=
 =?utf-8?B?U2lKVWd4c3kzZEdaSmllcjRFMmlmTnVLaHVrNHppS0MwTmlZMU1uenhvak43?=
 =?utf-8?B?Nm9YYmlkcTRpYUw0MkU4WWc3UkJ5a25wOGsrRFZnWTVVZDFrR0RNT3ZXOE56?=
 =?utf-8?B?dmtJV0pFMlRFNWVhcXlOYkRlWDNoejNjdTdjaEdaMVR1VEtPZmg2VTB4NFNX?=
 =?utf-8?B?dmJjYTFUTHFBQ1h5b3pBTGxmNDRTd3E1OTBLOFI4Q1RKNkZkdXBjQ0FWc3ho?=
 =?utf-8?B?S29nM3RwNis5dTQvTC8waWw3cTd5WHo1ZE5yZnJHT09EbkExNm9ESk9tL2tq?=
 =?utf-8?B?L1UvMnA2NUpjSFdEanYxWHc1dGNYanFnTTQ5K2VMcERiM1BabHgzVFF5Z3NT?=
 =?utf-8?B?OElhcVpQU2M5L0V4MGNFUTJoWmVpWDY0aERsUHJxUU9sWmdydXlVNmI0OWgv?=
 =?utf-8?B?c0RLWjVyakdmemNncGxqaFJjMitsUHFWM1R5aytEdW9SZGlOWDNSSmQ0Kysx?=
 =?utf-8?B?SGJWODZXaXd5U2pQUWkycTRwUHkrL2NZaVdJbXZ4N0hQaHBzM296NEhJeXN5?=
 =?utf-8?B?UEJjdGhnSlJYS0VSMVM2SktwU0QvS1Y5dVFwYTJnbmJwZDBJSkxrRE16c1V1?=
 =?utf-8?B?b2hmZHpxZWJESGM4Z0I5azJFbTlMNXpDNURrRXo4UG5FWGxod01iYjVtWFZj?=
 =?utf-8?B?RVdSVGdqc3QwUjc2dXNsWm5RdkhlSDZLUStzaU5BQmE1OG9uMDcvbG1oYTdT?=
 =?utf-8?B?U0tUZjZieGNlY21LUGJvNzVxVzBCQkZtQTV2a1dXb0lJcTVxSkY5UFRJL0lZ?=
 =?utf-8?B?STJ0MG5UWUtzd3l5WkZrUTkzb1N0Vzd3Q0VneEhBZmhWQ3NjcXpYamVjZ0VQ?=
 =?utf-8?B?VUVsT1BhRmZNRGhvZVBPNGZmREVNSU5hZ3NCLzBQRWJ2SUtEc204WVo5YVph?=
 =?utf-8?B?azB6RjVGcDMwd1dUOStVd3RVSklWRm5WVjhNS01TOUN3b1JIOUFMSzNBUjNU?=
 =?utf-8?B?Y1ZvT0VXME9Jb3MrWUFmUXpwS1FRZ0ZRUmw2MXBWK2dMRldiZitxbTVmd1B3?=
 =?utf-8?B?NEsraHEyMkxxblZEZks1bzBwRVlKVGZBSTlTdW01QUxRcHRtYXFZZkRBVEEr?=
 =?utf-8?B?NS9PNTZzMnl6bVBSUWwxZ3FkQXlJNnpTdGI2RHROd0NyQ2lpNjJqMndTcFFV?=
 =?utf-8?B?aXpueXNGL0w1R3hBRmdwaDUzZFBvNzY4b0EwK2UvTEZBTmRxcERZaG9keUsz?=
 =?utf-8?B?RGF1TzJiSGhNeGR2UndOTzN4Z29QK0NNclNia2VMQXg4WEtvck8reEZiOWVl?=
 =?utf-8?B?S3RrZVhudHk3MmltQTdJYXJCQ3RZYk94WFEzd3dSOXRHdVZBMkFtenBpdDlU?=
 =?utf-8?B?aDF2THNCMVAzMUkyalVzSkVTR2ZzdldHd2JKWlFBNTVTTnQvVDVvYTJteHk4?=
 =?utf-8?B?MGRRL3oxZXdWQU5HUDdKNzFoa0t5enJZN3dwN3VIWXpFOVlyd0FEK2p0MDVN?=
 =?utf-8?B?RzU4Q25kYWk2aW1NZUFuWFBGZ21USzNaSkRWV1h1QmZ4REtVaDdpTmpqVE1n?=
 =?utf-8?B?OHp3ZmZEUUwwcUtUS25rM0xYcVR3ZkRHd1NaTlZ3MlFNalQrMzgyYnBsbGhy?=
 =?utf-8?B?aGhsc2d1S3ljN3JlaGpIOFl2cUhIQk1ON01HeVBYWTAyd3c5b0tvL3JIc29h?=
 =?utf-8?B?VUV1NGhhd1VoV1VjL1lXWmdrZTJ3PT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e30751c-d6e8-4fb2-408a-08dab8c76e59
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 09:33:11.8191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +qAO5Au59vX9rEXoa9LXVTmXl2VxdR9ch17W5RHZRuGfrQg+4RUVcwD0JYOUcit6B2xCEMDR7/z8YLDkOZECOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4940
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 28/10/2022 03:23, Krzysztof Kozlowski wrote:
> On 24/10/2022 03:41, Wayne Chang wrote:
>> This commit enables XUSB host, device, and pad controller on
>> Jetson AGX Orin.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> ---
>>   .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  |  48 +++++
>>   .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 184 ++++++++++++++++++
>>   arch/arm64/boot/dts/nvidia/tegra234.dtsi      | 170 ++++++++++++++++
>>   3 files changed, 402 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> index 9e4d72cfa69f..8acef87a5398 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> @@ -61,6 +61,29 @@ mmc@3460000 {
>>   			non-removable;
>>   		};
>>   
>> +		padctl@3520000 {
>> +			vclamp-usb-supply = <&vdd_ao_1v8>;
>> +			avdd-usb-supply = <&vdd_ao_3v3>;
>> +
>> +			ports {
>> +				usb2-0 {
>> +					vbus-supply = <&vdd_5v0_sys>;
>> +				};
>> +
>> +				usb2-1 {
>> +					vbus-supply = <&vdd_5v0_sys>;
>> +				};
>> +
>> +				usb2-2 {
>> +					vbus-supply = <&vdd_5v0_sys>;
>> +				};
>> +
>> +				usb2-3 {
>> +					vbus-supply = <&vdd_5v0_sys>;
>> +				};
>> +			};
>> +		};
>> +
>>   		rtc@c2a0000 {
>>   			status = "okay";
>>   		};
>> @@ -69,4 +92,29 @@ pmc@c360000 {
>>   			nvidia,invert-interrupt;
>>   		};
>>   	};
>> +
>> +	vdd_5v0_sys: regulator@0 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "VIN_SYS_5V0";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +	};
>> +
>> +	vdd_ao_1v8: regulator@1 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vdd-AO-1v8";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		regulator-always-on;
>> +	};
>> +
>> +	vdd_ao_3v3: regulator@2 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vdd-AO-3v3";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-always-on;
>> +	};
>>   };
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> index 57ab75328814..b4630280bb32 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> @@ -2011,6 +2011,190 @@ hda@3510000 {
>>   			nvidia,model = "NVIDIA Jetson AGX Orin HDA";
>>   			status = "okay";
>>   		};
>> +
>> +		padctl@3520000 {
>> +			status = "okay";
>> +
>> +			pads {
>> +				usb2 {
>> +					lanes {
>> +						usb2-0 {
>> +							status = "okay";
>> +						};
>> +
>> +						usb2-1 {
>> +							status = "okay";
>> +						};
>> +
>> +						usb2-2 {
>> +							status = "okay";
>> +						};
>> +
>> +						usb2-3 {
>> +							status = "okay";
>> +						};
>> +					};
>> +				};
>> +
>> +				usb3 {
>> +					lanes {
>> +						usb3-0 {
>> +							status = "okay";
>> +						};
>> +
>> +						usb3-1 {
>> +							status = "okay";
>> +						};
>> +
>> +						usb3-2 {
>> +							status = "okay";
>> +						};
>> +					};
>> +				};
>> +			};
>> +
>> +			ports {
>> +				usb2-0 {
>> +					mode = "otg";
>> +					usb-role-switch;
>> +					status = "okay";
>> +					port {
>> +						hs_typec_p1: endpoint {
>> +							remote-endpoint = <&hs_ucsi_ccg_p1>;
>> +						};
>> +					};
>> +				};
>> +
>> +				usb2-1 {
>> +					mode = "host";
>> +					status = "okay";
>> +					port {
>> +						hs_typec_p0: endpoint {
>> +							remote-endpoint = <&hs_ucsi_ccg_p0>;
>> +						};
>> +					};
>> +				};
>> +
>> +				usb2-2 {
>> +					mode = "host";
>> +					status = "okay";
>> +				};
>> +
>> +				usb2-3 {
>> +					mode = "host";
>> +					status = "okay";
>> +				};
>> +
>> +				usb3-0 {
>> +					nvidia,usb2-companion = <1>;
>> +					status = "okay";
>> +					port {
>> +						ss_typec_p0: endpoint {
>> +							remote-endpoint = <&ss_ucsi_ccg_p0>;
>> +						};
>> +					};
>> +				};
>> +
>> +				usb3-1 {
>> +					nvidia,usb2-companion = <0>;
>> +					status = "okay";
>> +					port {
>> +						ss_typec_p1: endpoint {
>> +							remote-endpoint = <&ss_ucsi_ccg_p1>;
>> +						};
>> +					};
>> +				};
>> +
>> +				usb3-2 {
>> +					nvidia,usb2-companion = <3>;
>> +					status = "okay";
>> +				};
>> +			};
>> +		};
>> +
>> +		usb@3550000 {
>> +			status = "okay";
>> +
>> +			phys = <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-0}>,
>> +				<&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-1}>;
>> +			phy-names = "usb2-0", "usb3-1";
>> +		};
>> +
>> +		usb@3610000 {
>> +			status = "okay";
>> +
>> +			phys =	<&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-0}>,
>> +				<&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-1}>,
>> +				<&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-2}>,
>> +				<&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-3}>,
>> +				<&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-0}>,
>> +				<&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-1}>,
>> +				<&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-2}>;
>> +			phy-names = "usb2-0", "usb2-1", "usb2-2", "usb2-3",
>> +				"usb3-0", "usb3-1", "usb3-2";
>> +		};
>> +
>> +		i2c@c240000 {
>> +			status = "okay";
>> +			ucsi_ccg: ucsi_ccg@8 {
> 
> No underscores in node names.
> 
>> +				compatible = "cypress,cypd4226";
>> +				cypress,firmware-build = "gn";
>> +				interrupt-parent = <&gpio>;
>> +				interrupts = <TEGRA234_MAIN_GPIO(Y, 4) IRQ_TYPE_LEVEL_LOW>;
>> +				reg = <0x08>;
>> +				status = "okay";
> 
> The pattern of redefining full path in Tegra is confusing - I have no
> clue which of these status=okay are correct which are redundant.
> 
> Do you?

I understand you may not like this approach, however, this comment is 
not really relevant to just this patch, but a general comment. But yes 
we will ensure that this is correct.

> 
> 
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +				ccg_typec_con0: connector@0 {
>> +					compatible = "usb-c-connector";
>> +					reg = <0>;
>> +					label = "USB-C";
>> +					data-role = "host";
>> +					#address-cells = <1>;
>> +					#size-cells = <0>;
>> +					port@0 {
>> +						reg = <0>;
>> +						#address-cells = <1>;
>> +						#size-cells = <0>;
> 
> Hm, why do you have here cells?
> 
> Did you test the DTS with dtbs_check?

That does not look correct and so we will correct.

Thanks!
Jon

-- 
nvpublic