Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 11:55:23 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     "Gole, Dhruva" <d-gole@ti.com>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spi-mem: Fix typo (of -> or)
Message-ID: <Y1unCzyjQ1ZzgU/S@probook>
References: <20221008151459.1421406-1-j.neuschaefer@gmx.net>
 <0f5235b8-9f35-6f7c-37b4-8094e476fbd4@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1NtTPhkobE9FrTi9"
Content-Disposition: inline
In-Reply-To: <0f5235b8-9f35-6f7c-37b4-8094e476fbd4@ti.com>
UI-OutboundReport: notjunk:1;M01:P0:N1lsjRnlqaQ=;fNkAC7kWKBjkcVw5mRwQPYFHwjb
 CdCuv11tVODhHBj6yyFZVt8R+OAd2aWQpWXFsp2OzbAe/DJeWAcXx1KIEiJlGyN50OrgFZLS9
 AZzSlpzYjBBIq7IcqIWAz63cOvl0VXtsVuLGyPiZs52Ny9+1Q/2KxGX5ialqEkOAMRWSp0oIk
 umu1TULRksbk63j8YTfZabJ88ijZSGh82AN86yeYNDqptmZGPfFrB2tHTerF1t9gcbXgYGsdn
 wwsLqyeYk5ELVFboqNJrMt1DYUV91+9adUmD+hatPsb4H2P817G3ygyiXx+XiBjmSCJqmgkw0
 3CntwNxc+XmSB9WfnAJCfLLZf6BvMRehbK8y5XpI9UALd9r/NDCULIr3x01N6zaBF7U/RjD8z
 tcZtVc4nEwUKD4zCyIzAHtWFMpbBdyScvSQxpZPfNM+2sCbuJtso4DO76rIK9L8edACVWGHuW
 j3F4jVD4Mv/DbHv79Svi+q6nxY+9EzXGnNUoU0frGgP+O17d/yfEoEKO+yOGeg3SHfUd73FwX
 CfTzClYgiVciFLWIdeH7f23VxjaoIgkcylMOUuMZKEG35tL8rYi5JhCRmO9gPZGJ3ltWnyfV5
 smTAJXzEG1bBhp009TGy23bBbglPlWweLcaxKDAAUKkcAFaP3AHAjzHPd1NzLy8futlDePRW+
 Erak7/62WVTn46LEkWctGoLVQt+JUJee272BLn6RUXg8r9Y02iklvUTTb7cUAPs9UxjCT+fhe
 7oqpBbIOCA2QH4un8KcnLtONSe106JK9DrgPv3cWarTVfqovNDn8B52iMYmo2tPAr5qg26hej
 5GlIBuIL7ZMRHUoBOkbI71xsyqE46JS5mHJsrAU6/DVYJCENUdE8NcuJk8qkaRkh5hiAmfeAB
 kuCf2QlRnAU43GgVDL8eo2WlJQJr7+u4uHL4mf+5FE0NglID7RkVvq0mtvJ8OKKItDwOb3l9N
 Pk23LCt1HkZswC9Qj6INvW7cs+k=
Precedence: bulk


--1NtTPhkobE9FrTi9
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 28, 2022 at 12:00:23PM +0530, Gole, Dhruva wrote:
> Hi Jonathan,
>=20
> On 10/8/2022 8:44 PM, Jonathan Neusch=C3=A4fer wrote:
> > In this instance, "or" makes more sense than "of", so I guess that "or"
> > was intended and "of" was a typo.
>=20
> Using "I guess" is generally discouraged in commit messages. Please read =
up
> the documentation

It is truthful though: I did not write the original comment, and my
change is based on my interpretation of the comment.

> on submitting patches:
>=20
> > Describe your changes in imperative mood, e.g. =E2=80=9Cmake xyzzy do f=
rotz=E2=80=9D
> instead of =E2=80=9C[This patch] makes xyzzy do frotz=E2=80=9D or =E2=80=
=9C[I] changed xyzzy to do
> frotz=E2=80=9D, as if you are giving orders to the codebase to change its=
 behaviour.

The imperative-mood description is already in the commit title
(or subject line). I am not making a functional change to the code, so
"fix a typo" is really all that is to be said in imperative mood, the
rest is an explanation of why I think this makes sense.

>=20
> link: https://www.kernel.org/doc/html/latest/process/submitting-patches.h=
tml#describe-your-changes


Best regards,
Jonathan

--1NtTPhkobE9FrTi9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmNbpuAACgkQCDBEmo7z
X9sr4g//VvsB4DL6cxOkmmeWBDqoGQantquJSx2os82Mrwqh1d3WAuc/fXeODrTU
4pMFCbrbv/eC1sKy0LiYMcBFCy5n6dUcxHMVFl+QNlc0HZxOLVYVsD3aUWGkEdVq
5RnfTmXvK/CIiK+OahaFpg7x2g7guNWT/7Tc4mwDPuEh78QO8QAB9Jc1HD9u1HbT
71mqGBRSAux7/0WD/D0qIE7VDxKGRt7nempUAcC/ys+6iSkR/csJfBhSilpJFBI+
GBumW2Lt4UHYk48E0mZeQCycGYarQ3E71/Slm2bdWfLaaUEgcQ6OX1mtpWxqamzI
SIGju+H+sxLagjkDM7nr7WMNoAUc1GqXKqryfTLOUZSj1BkVCrjLUBFxRwDolZ7A
kD+0VCuTtqACFhn7CpwB1lK7RWG1Eu4zX+eEb4uSMIq6ZKruIf+yRbjwP3B2E3As
SPXAxQb1wuV81Itg4jAfxrUw2KLayeIJdYG/aH5vO8muXAJX0ap+ti6obKqYkeZu
cASE8C1stw5spziwKwYeHnJO4HhmVTfUsGBYpRAdC7zu3OtZNeIGuZOSzYHb74Iy
4dmwgwQCZGyBNbX2HBkbKg3nUxxw9yAAgB+zvYvjs+P4B1xg7HI9Qu87p8PeCgLF
N0TicmHo6KdHj8l/L5+HzTa0BIJRMNTXX9U+R31fjOdhsSiYqAo=
=q8+s
-----END PGP SIGNATURE-----

--1NtTPhkobE9FrTi9--