Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Lei Yu <yulei.sh@bytedance.com>, Felipe Balbi <balbi@kernel.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Henry Tian <tianxiaofeng@bytedance.com>,
        Jakob Koschel <jakobkoschel@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ryan Chen <ryan_chen@aspeedtech.com>
Subject: RE: [PATCH] usb: gadget: aspeed: fix buffer overflow
Thread-Topic: [PATCH] usb: gadget: aspeed: fix buffer overflow
Thread-Index: AQHY543fG2IRDKPpjUCvaIBADhhwbq4jYB2AgAASRYCAABWy4IAABOeAgAADxYA=
Date:   Fri, 28 Oct 2022 09:55:57 +0000
Message-ID: <HK0PR06MB32024F58191E17DC5ABC99F380329@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20221024094853.2877441-1-yulei.sh@bytedance.com>
 <HK0PR06MB32022348EA65805C7109B7D080329@HK0PR06MB3202.apcprd06.prod.outlook.com>
 <CAGm54UExHOBw61DJNqxvW67OSr60fQ+Q247t63RzymiMOmHmFg@mail.gmail.com>
 <HK0PR06MB320203EF8E3AD14C34359B0580329@HK0PR06MB3202.apcprd06.prod.outlook.com>
 <Y1ueEYJk2epT/g4J@kroah.com>
In-Reply-To: <Y1ueEYJk2epT/g4J@kroah.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IJJrYeakPo7AYSB9q4VzqPzNgL4e8CWJsJrqrVt0g7gMPpCTi6Dy6syr0szR?=
 =?us-ascii?Q?AGgFPpkDUJ01KoIKLd7xTpnjep88zUd0f2Bc94114NMlUemQqthqaLlSaT6h?=
 =?us-ascii?Q?4jjSN3g11BVH0BUG/tIs9K38RIg6l8FeKgFu+6Zq7s2oJlwVInJPa7rg4Wao?=
 =?us-ascii?Q?BiceMZCiS+BbfvdizUHvjxqb82E/iyP06RmCkY6SIPQJuv7nanJPO8m1/ijL?=
 =?us-ascii?Q?Rq+xzfl7LKOcpfDAPQ4akZWb/ltcLxFa2QzfICCTd2Aa5qbHVvy3mQ8PkpCN?=
 =?us-ascii?Q?8/VMVGoFykZRarvVfBl2+NBwGhzDYtKkaJ92ezOibElajnmIddR7872x43rd?=
 =?us-ascii?Q?DYkpKAlaKomSXwd06mXqSttQlj9m1kU6Y/lcp+2jaffP1RVOM6DMcJ6l9BHr?=
 =?us-ascii?Q?ji/tL+KdX5Xgp2zyH8FQuCXhx81NOXeI0bgjKS0cmCmuSYLaXSzLlGrQM5pE?=
 =?us-ascii?Q?vsUdFVG7TyVXi7YojPBKn5MnkqSi4yZ7n//Tpa3LTHQV6fjM3PeszqdO2muY?=
 =?us-ascii?Q?UMwuhDBXpuZZ9ej2Z7qPvXzyZPJwCunqroGx2mYJqcedi0ObZ1YntLQW9Fpp?=
 =?us-ascii?Q?6WVEVT/rubTz4651TlFpxgEGz7CQiHPmla1cKV4IqG2nWfQ+4AJHc1Bx04V7?=
 =?us-ascii?Q?Hsw89vmXeOZXiMIUHC1zg+FajTn0Ngtuhz1KubS6BlCItAW6HgvF0GbRNLkG?=
 =?us-ascii?Q?AcXhXxx/tUz6tzd05mY7oc2FONLaxnXSyxxEyPZhvFB0zTv7EvVKqSqLvHJa?=
 =?us-ascii?Q?vBhqio1kaBN56z5ix5tfCq8cEPR6DQUN2A26lQFJlYSxS9P4+537L6dSMBKf?=
 =?us-ascii?Q?aHNmM0s+458wJzicGIaaHJxmP0jJq0twOc2hg0FlllrtFWbFCAs/rpVbQZab?=
 =?us-ascii?Q?SGTrvnCJPwMXJmoIhfkZJ18dbFHxDo/kMwAXtabAYMPJY47dj/UN1qkiiTNL?=
 =?us-ascii?Q?+ASEoei09qNS3oR8OQ+TRXM4MoTciRVtDR90nN5cIzKUFrC8+QNlT8YHoZ4X?=
 =?us-ascii?Q?hUR2XLr4yYqzpxvQn1FP0W9YDWfHRX0oJw09FwO0aD9FSUQT/v6Sfh/YMxs5?=
 =?us-ascii?Q?GbnqHM9uiHWuhSwZRVIHkI6YO5Dq4sjXqPwZ4Xas1Te9H00ejV94t+GAWnoX?=
 =?us-ascii?Q?MmXokBLVReBb6T6IF9fzMC1/8IgSafTBLtpmHy+wJ+/6L3qIzyVkbuTdXfSs?=
 =?us-ascii?Q?CjZLaNCTZv0dHA9eCNpmd7gptJkWx+PIAU/vBbpx6+y2gYSThplnXKvygkMF?=
 =?us-ascii?Q?ngcqXvPlfA0LI/qUftTX7NCi/Ah3pJGARc212nOfqXTxqTnBqH0QK1W70CPY?=
 =?us-ascii?Q?iPST/u7uJX8q2ObYIAK7GCnHsikBo8x0/BTx/CTJhZUq7Xx/42i8UYDL7HnS?=
 =?us-ascii?Q?T+po0RYHDBsAwDX4hGqd2mNuJFZnfSomI7yFUZ/GMTs+39qyJFu8kLSmF5ZG?=
 =?us-ascii?Q?eUMMiisSb+vRTmaig0MIn/6UTkO1hjP/7yUBRVL4utlIVErMkZlQ1GwQ3Mv7?=
 =?us-ascii?Q?3Ys0Fr4VbBgaE88KGT+xQz4i0xRvy5urdfm3Kwlptxm8/sPfG09IRJnBl1FC?=
 =?us-ascii?Q?fHIyVNy4BhKTkA98tRFuEgFxDj57kcoUHfDErmyf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6e908fe-47a9-4bc2-1eb1-08dab8ca9c4c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 09:55:57.0860
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fUq8Nz6l6jNRDgMiGCMjneIzOrwpzaXzQGbB4rUd7tEs7rqgyBdryRc+8AdFAqZoC/8JFRrp1a/rrbw/D4DKjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5056
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_SPF_TEMPERROR
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > > Thanks for your feedback.
> > > > I tried to reproduce it on my side, and it cannot be reproduce it.
> > > > Here are my test sequences:
> > > > 1. emulate one of the vhub port to usb ethernet through Linux
> > > > gadget
> > > > (ncm)
> > >
> > > We are using rndis instead of ncm.
> > >
> > > > 2. connect BMC vhub to Host
> > > > 3. BMC & Host can ping each other (both usb eth dev default mtu is
> > > > 1500) 4. Set BMC mtu to 1000 (Host OS cannot set usb eth dev mtu
> > > > to 2000, it's maxmtu is 1500)
> > >
> > > Not sure if it's related, but in my case (USB rndis, Debian 10 OS)
> > > it should be able to set MTU to 2000.
> >
> > Using rndis is able to set MTU to 2000, and the issue can be reproduced=
.
>=20
> Please NEVER use rndis anymore.  I need to go just delete that driver fro=
m
> the tree.
>=20
> It is insecure-by-design and will cause any system that runs it to be ins=
tantly
> compromised and it can not be fixed.  Never trust it.
>=20
> Even for data throughput tests, I wouldn't trust it as it does odd things=
 with
> packet sizes as you show here.

Thanks for the info, Greg.
If rndis will no longer be supported, how to use usb-ethernet on Windows OS=
?
For my understanding, ncm/ecm cannot work on Windows OS.