Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Deepak R Varma <drv@mailo.com>,
        "outreachy@lists.linux.dev" <outreachy@lists.linux.dev>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: iio: ad5933: Use div64_ul instead of do_div
Thread-Topic: [PATCH] staging: iio: ad5933: Use div64_ul instead of do_div
Thread-Index: AQHY6ks4nrCWT2KFn0+DLX/dNrKI2K4jloMg
Date:   Fri, 28 Oct 2022 10:11:26 +0000
Message-ID: <SJ0PR03MB6778EAAB4132374270E96FFB99329@SJ0PR03MB6778.namprd03.prod.outlook.com>
References: <Y1r4EaDvEipzhaaf@ubunlion>
In-Reply-To: <Y1r4EaDvEipzhaaf@ubunlion>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kPAIjwDNu+/AYwNywJ+Mf/AOF8ZAzb4/kX+KxjdgIqSSVJw9S0v8yUZvhj?=
 =?iso-8859-1?Q?XW2VAUxuPyqWi39IvoiL57bE98MBT+5PXWfx7b5pTGNEl0K8rpZj/Yxnkj?=
 =?iso-8859-1?Q?DQ2qmPzLc5dJDtFzi46wH5kU7X0eGRFb9GaUGwFzGUXkV7/koMyqZknyAL?=
 =?iso-8859-1?Q?3CvRir0LtGspEdmQzNyrGKnOyp4pEtwdqrwHNy3DOKhIjKUsbZ2wzzBtMm?=
 =?iso-8859-1?Q?sOfHPkzVEZ5dxkPSCB39MKq3Pgq9UB9t30BJFhdIBDlyovsJjm23k9OVfA?=
 =?iso-8859-1?Q?CXTW7thhO7cD5UFN34Y7/zJbVf/ZEiwGctId58uHSZuZs9TfeVo1EsH9uh?=
 =?iso-8859-1?Q?GpOUmwl5vjKaLP3WZamc8tzNTIWN8AaFjetDmCEJ8pBCxNEzHByncYMujD?=
 =?iso-8859-1?Q?8NUWNFEpN08toiTVv25SYGvxWrac7fPGqHQ32bHWyFb+WeHe6MbPw79Jgf?=
 =?iso-8859-1?Q?7T+2OvnZdV0BRqWXmcgPYG0sGMmwnyCKj9Qo1Yer5KD9zJnA8nEEB4kiq2?=
 =?iso-8859-1?Q?d3/Uta13pRCFwlikRrhJQ0JFyuYNoW1Nu4zhXVBFhpT68cuT09m1i9ylsP?=
 =?iso-8859-1?Q?w5T7AJl1SSPJaQDVmE3ma59Lb1ZgpCc66CuNHhGw687wWjWBON2GnSmN7a?=
 =?iso-8859-1?Q?XtRAgm47CnANfdeYir09Ho52U6mJWdaWl+yibOKZC34V1u8CxGOsedIeE3?=
 =?iso-8859-1?Q?nhuIOQQ2VR6r/sv/ooxkrMhgaeGBCBodAV1zY+ZelqR8h55VLWH/PNr2u/?=
 =?iso-8859-1?Q?F1y/2X61N7JAAUQtPfdb9wyuLzsPx2bcM01gJ5HOpAOtz9vTXcLO/E7fHm?=
 =?iso-8859-1?Q?8vxM8yVGOKpjGie298Tgj8/fr/5YHcrrQh34syfYWOZq4Dw2LOj5EzdLgU?=
 =?iso-8859-1?Q?dxDM9gzchhAYXho9tWXD4NtsbNaPFimvsnL/idLRcHmf7WB7qahtBgLu6Q?=
 =?iso-8859-1?Q?MT+5kROF+yOuVmCQEXCd6fsVDIM4woZ5BlJ2biVNWQ1PoTiTcWJ+KrHQBZ?=
 =?iso-8859-1?Q?ZYjId/FqZFpyDfPq3lG6CpTeCPVbzYSx9uFn/4C6GLld6ewBX2hX8XnW3S?=
 =?iso-8859-1?Q?VDEddhqJYeyCA5QMOJMXpAjf7XT/SHpGhf1LyJL74vxdq7sXpLTGEuiyd9?=
 =?iso-8859-1?Q?coyZexrF6YrLab2O5yi4KVhU9pZsDEbnNooqayCv92T24/8K5984arsrFG?=
 =?iso-8859-1?Q?xIZP9RuNHaBUPlZTr4oVt5UO3UwJj+hSpjUrF+v4jnD8zxgxddxqu7Dhdk?=
 =?iso-8859-1?Q?O5ePOF4YdJ6279T0Gf3QRjVhiAgZABgJ4EBpD5W9OWyyN7/4R+4M8k2pgd?=
 =?iso-8859-1?Q?wwnS3uQs1ZYolQaxqHBlCeROspzSwT0PEElDrkUAg85O7bX8r+C5eTNEdi?=
 =?iso-8859-1?Q?bCkfoOqDAVDugUChXe/AoTFLq09p8uJjAf3RJ1QOshLPcvDgcTeSWWY1PE?=
 =?iso-8859-1?Q?q8kpvzCkDYw9nupXn5H5v8RIR2zw66gYxloZ61NrQPihMwKcXz/b4QEiKw?=
 =?iso-8859-1?Q?kLyb3ORVraRFu8EByNlSD9Tq/OqP5xxX/ayGbu9PNBgX0xX60OVduUChov?=
 =?iso-8859-1?Q?3fJH0k+rBFK3Vr9E7/WkRmNg2X0Sw+TM6+kTSXmRyoufEpp8MNHlfINegL?=
 =?iso-8859-1?Q?Af3h6YxKIlsNI8NunNmeF9Apov08kh2cLJ?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6778.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f24ce96d-d80a-412e-4517-08dab8ccc67e
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 10:11:26.9037
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5btWpUMhGTKXbQ4vfpfWqt/Merz6M8+UTkmreWfv2HpPjZCEvJmeLv5Do59zv8Zfcb3q559LqfPB2UKbKPjb4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB7019
X-Proofpoint-GUID: 4EplaXg3FlkvWLzYTXqWKB5tB-Y-6g0_
X-Proofpoint-ORIG-GUID: 4EplaXg3FlkvWLzYTXqWKB5tB-Y-6g0_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_04,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011
 priorityscore=1501 mlxscore=0 lowpriorityscore=0 adultscore=0
 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 spamscore=0
 mlxlogscore=930 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2210170000 definitions=main-2210280064
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Deepak R Varma <drv@mailo.com>
> Sent: Thursday, October 27, 2022 11:29 PM
> To: outreachy@lists.linux.dev; Lars-Peter Clausen <lars@metafoo.de>;
> Hennerich, Michael <Michael.Hennerich@analog.com>; Jonathan Cameron
> <jic23@kernel.org>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>;
> linux-iio@vger.kernel.org; linux-staging@lists.linux.dev; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] staging: iio: ad5933: Use div64_ul instead of do_div
>=20
> [External]
>=20
> do_div() does a 64-by-32 division. Here the divisor is an unsigned long
> which on some platforms is 64 bit wide. So use div64_ul instead of do_div
> to avoid a possible truncation. Issue was identified using the
> coccicheck tool.
>=20
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---

Reviewed-by: Nuno S=E1 <nuno.sa@analog.com>