Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2161840rwi; Fri, 28 Oct 2022 03:56:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5QVUU/i2KO5ndi//EJYzjQJmBa+D5AybAYrt+WR/O9Im3W97a6hiQB7hKAVcShASWfuSfG X-Received: by 2002:a17:906:591:b0:73d:c3ef:84ae with SMTP id 17-20020a170906059100b0073dc3ef84aemr46421222ejn.155.1666954597757; Fri, 28 Oct 2022 03:56:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666954597; cv=none; d=google.com; s=arc-20160816; b=kT5CWzNOGSlThUcwVqHA+q+3X6qH2tTXutRxzwE7Ii90gtQ1pNhiFlSbsgn8taRHcQ oY5LrLcLPQ2RxTPIOVHON5gNro6BiB6Vh9Czt+aL06nvd5b3LRzMgDHFwsY9r+sRmyib lNt9L70otr/uvEpTI3y+wH+yrURB2WM/ipjVGwvmWqOuT3/GPrZFT5oEdOyhCixnOU4/ wMvBtjcmMO+/TRvo3GlcJFZ5CzNoWMRX/YcE5AOQI0jtNlp15sP0kKqZPohVj+X3eaHn 9yrFLqHJMlOfny0ZEpGd4hy2f2hYQXRWIBrXWs4HI3iAihPsJOAxIoog9SCvwAQsYx7Z jl0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=zwzLdWoWFgq62O5OUUPFj6Ag8jaRzLM+v7K+j93cq9Q=; b=knd+6Jqa0VzfeX/jJOwYSMOpssBl+CFE7kCFOkiPTF5KQ8DeGONKDBmUCyxDaPkKQI rTJJfdDiJPtbIcyNq3J+mKeSS5A/atW3mJwwqETANdPHyRsZiVYLlGkJk3Nw26f3zcv6 syokTO67fvUK0Zh+4HnvkvyfDnwjY+KF+jFvgwz7CpW85QssJQY4QJb5klpu/8G1qhOw ru5UtfHYP/Oj86gxIs3Yka0IAIppfHFIv4O0xhDxJ5jPnWcurXw5hieU7sh9FWM3Rlw3 ypSQ/PgPKebFvIg0GOa+WL1uqsNgmFQNIQZIV7oHkYtS7UcPhX7hG9CTs9h4xyTdC1N0 SWQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r6-20020a05640251c600b00457f9c97f13si3905664edd.581.2022.10.28.03.56.12; Fri, 28 Oct 2022 03:56:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbiJ1Jg3 (ORCPT + 99 others); Fri, 28 Oct 2022 05:36:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbiJ1JgG (ORCPT ); Fri, 28 Oct 2022 05:36:06 -0400 X-Greylist: delayed 597 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 28 Oct 2022 02:35:27 PDT Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394B959244; Fri, 28 Oct 2022 02:35:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 44B421863F30; Fri, 28 Oct 2022 12:25:26 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wmW6qRmkIY0a; Fri, 28 Oct 2022 12:25:26 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 04B521863F18; Fri, 28 Oct 2022 12:25:26 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id es316AFVOzqz; Fri, 28 Oct 2022 12:25:25 +0300 (MSK) Received: from rbta-msk-lt-106062.astralinux.ru (unknown [10.177.20.20]) by mail.astralinux.ru (Postfix) with ESMTPSA id A95B11863ED2; Fri, 28 Oct 2022 12:25:25 +0300 (MSK) From: Anastasia Belova To: Vinod Koul Cc: Anastasia Belova , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] vdec_vp9_if: add check for NULL for vsi->frm_bufs[vsi->new_fb_idx].buf.fb in vp9_swap_frm_bufs Date: Fri, 28 Oct 2022 12:25:16 +0300 Message-Id: <20221028092516.19070-1-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If vsi->frm_bufs[vsi->new_fb_idx].buf.fb =3D=3D NULL while cleaning fb_free_list NULL-pointer is dereferenced. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Anastasia Belova --- drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c b/drive= rs/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c index d9880210b2ab..dea056689b48 100644 --- a/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c +++ b/drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c @@ -512,7 +512,7 @@ static void vp9_swap_frm_bufs(struct vdec_vp9_inst *i= nst) * clean fb_free_list */ if (vsi->frm_bufs[vsi->new_fb_idx].ref_cnt =3D=3D 0) { - if (!vp9_is_sf_ref_fb( + if (vsi->frm_bufs[vsi->new_fb_idx].buf.fb !=3D NULL && !vp9_is_sf_ref_= fb( inst, vsi->frm_bufs[vsi->new_fb_idx].buf.fb)) { struct vdec_fb *fb; =20 --=20 2.30.2