Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 10:38:39 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Wei Liu <wei.liu@kernel.org>,
        Shradha Gupta <shradhagupta@linux.microsoft.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Dexuan Cui <decui@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH v2 1/2] mm/page_reporting: Add checks for
 page_reporting_order param
Message-ID: <Y1uxLyaLlKp2sfkD@liuwe-devbox-debian-v2>
References: <1664447081-14744-1-git-send-email-shradhagupta@linux.microsoft.com>
 <1664517699-1085-1-git-send-email-shradhagupta@linux.microsoft.com>
 <1664517699-1085-2-git-send-email-shradhagupta@linux.microsoft.com>
 <Y1lTWxMnk3lnS+3V@liuwe-devbox-debian-v2>
 <20221027132207.bb4e9408e1ca94b3dfaca405@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221027132207.bb4e9408e1ca94b3dfaca405@linux-foundation.org>
Precedence: bulk

On Thu, Oct 27, 2022 at 01:22:07PM -0700, Andrew Morton wrote:
> On Wed, 26 Oct 2022 15:33:47 +0000 Wei Liu <wei.liu@kernel.org> wrote:
> 
> > On Thu, Sep 29, 2022 at 11:01:38PM -0700, Shradha Gupta wrote:
> > > Current code allows the page_reporting_order parameter to be changed
> > > via sysfs to any integer value.  The new value is used immediately
> > > in page reporting code with no validation, which could cause incorrect
> > > behavior.  Fix this by adding validation of the new value.
> > > Export this parameter for use in the driver that is calling the
> > > page_reporting_register().
> > > This is needed by drivers like hv_balloon to know the order of the
> > > pages reported. Traditionally the values provided in the kernel boot
> > > line or subsequently changed via sysfs take priority therefore, if
> > > page_reporting_order parameter's value is set, it takes precedence
> > > over the value passed while registering with the driver.
> > > 
> > > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> > 
> > Andrew and other MM reviewers, can I get an ack / nack for this patch?
> 
> Looks OK to me.  Can this be merged via the hyperv tree?

Yes, I can take of merging it.

I will add your acked-by to the patch.

Thanks,
Wei.