Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 13:30:13 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Wayne Chang <waynec@nvidia.com>, Rob Herring <robh@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        Thierry Reding <treding@nvidia.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        Ajay Gupta <ajayg@nvidia.com>, "kishon@ti.com" <kishon@ti.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
        Jui Chang Kuo <jckuo@nvidia.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sing-Han Chen <singhanc@nvidia.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host
 controller binding
Message-ID: <Y1u9RUv8twZF9uwm@orome>
References: <20221024074128.1113554-1-waynec@nvidia.com>
 <20221024074128.1113554-3-waynec@nvidia.com>
 <20221024145446.GA1763588-robh@kernel.org>
 <52ae737e-eb4f-9eb7-8b79-d58251062276@nvidia.com>
 <f5d2c979-a61c-e0d4-7a08-5b6f5b38dffb@linaro.org>
 <c8039494-9fb7-c72e-a852-8bde13c0a61d@nvidia.com>
 <8194796b-9845-cd02-a542-0bc0d66b4617@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7Ij0/INtbn8XA1A3"
Content-Disposition: inline
In-Reply-To: <8194796b-9845-cd02-a542-0bc0d66b4617@nvidia.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--7Ij0/INtbn8XA1A3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 28, 2022 at 12:07:38PM +0100, Jon Hunter wrote:
>=20
> On 28/10/2022 10:25, Jon Hunter wrote:
> >=20
> > On 28/10/2022 03:19, Krzysztof Kozlowski wrote:
> > > On 25/10/2022 04:02, Wayne Chang wrote:
> > > >=20
> > > > > > +=C2=A0 power-domain-names:
> > > > > > +=C2=A0=C2=A0=C2=A0 items:
> > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: xusb_host
> > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: xusb_ss
> > > > >=20
> > > > > Drop 'xusb_'.
> > > >=20
> > > > The properties are constant and we use the name to get the power do=
main.
> > > >=20
> > > > =C2=A0=C2=A0=C2=A0=C2=A0tegra->genpd_dev_host =3D dev_pm_domain_att=
ach_by_name(dev,
> > > > "xusb_host");
> > > >=20
> > > > =C2=A0=C2=A0=C2=A0=C2=A0tegra->genpd_dev_ss =3D dev_pm_domain_attac=
h_by_name(dev, "xusb_ss");
> > > >=20
> > > > we might not be able to drop the xusb_
> > >=20
> > > These are new bindings, so why do say they are "constant"? New bindin=
gs
> > > means you did not use them. If you used them before bindings... what =
can
> > > we say? Don't?
> >=20
> > Not exactly. However, what we should do here is convert the legacy
> > binding doc [0] and replace with this one. But yes we are stuck with the
> > 'xusb_host' naming.
>=20
>=20
> Thierry already has a patch to do this [0]. So we should fix that up and
> included in this series.
>=20
> Jon
>=20
> [0] https://lore.kernel.org/linux-tegra/20211209165339.614498-3-thierry.r=
eding@gmail.com/

I have a v2 with at least some of the comments addressed. I'll go
through them again and send it out. If we can get that reviewed, it can
be included in this series and the Tegra234 addition be applied on top.

Thierry

--7Ij0/INtbn8XA1A3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNbvUUACgkQ3SOs138+
s6Fa0Q/9EKJnNz9Xf4kL0Qh2galCEt8TqgYwD0b9wPG2Y0qT48Ruux/nxUQsmqAp
NNh9qsA8QDQq7dPeyQu98rnPmeiA4QYXI9VEtqxwdwJS4L3S8M+lQSd1SfrWJh7n
RJZXVYmiqddCjoVbNpr9BNNgHwzEBy/QmugeQRQl4PadheM1VpF1CGocd1x7sI30
aIjMmjO8yzVyfj9WHNoiWq+IjiByk9Yrgnrs18JjWR/6vFD9lBxIUqSKEbap9Fck
HqiPKdF4Bi8Ha0Xa5Ztp49L86UkWlKa7/162BKPaxS27XpFYBmQaCb8ZA7ZFjLCH
v7u7KsxscMEac7riJwV2KEZGQLyqtI6M8eSlBCPR/7Ra6utKCxQeCqd4EIR52bij
pYiFQgFJCwK5gLfLUoFarfhcmZ2TMpiAPU8bt4Erp6qrC3GA/gV66LLAXuDGkR64
n8u5ARPNC+WztYokhWpctiujRBOa8VWrK8wPQhM+Ng3lJbKWEJwG0/4/ZWQFTljQ
GVErNKlx9f0sBgbh/qWTa9geGJI9hhFp77es5u4r0rymFr8vd7+EnZjwBp1BzQqJ
yFyL8rWkJ6j8tPZBqC63+QTBuTHS5XludSuSvzuGS3fAIgvcNuhAS6mAoQuL5ZI9
7Q8voktDR5a94kkLK0qQYjFewCCcjqrk+BoZNWbBbP/wxpsSaBE=
=pOcc
-----END PGP SIGNATURE-----

--7Ij0/INtbn8XA1A3--