Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 12:56:16 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Cc:     linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, robh@kernel.org,
        Shengjiu Wang <shengjiu.wang@nxp.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>,
        angelogioacchino.delregno@collabora.corp-partner.google.com,
        devicetree@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v1 1/2] ASoC: dt-bindings: Document dmic_sel-gpios
 optional prop for two DMICs case
Message-ID: <Y1vDYNOwZNOco1hq@sirena.org.uk>
References: <20221028102450.1161382-1-ajye_huang@compal.corp-partner.google.com>
 <20221028102450.1161382-2-ajye_huang@compal.corp-partner.google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="M+JJnzUDip9rx8JE"
Content-Disposition: inline
In-Reply-To: <20221028102450.1161382-2-ajye_huang@compal.corp-partner.google.com>
Precedence: bulk


--M+JJnzUDip9rx8JE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 28, 2022 at 06:24:49PM +0800, Ajye Huang wrote:
> Document dmic_sel-gpios optional prop for switching between two DMICs.
> Ex, the GPIO can control a MUX to select Front or Rear dmic.

> +  dmic_sel-gpios:
> +    maxItems: 1
> +    description: GPIO for switching between DMICs, ex Front/Rear dmic
> +

If we're going to do this we should also allow the bindings to label the
mics appropriately so that the control presented can reflect the actual
hardware.  It does feel like it might fit better to do this separately
to the DMIC driver as a mux between the DMIC and the DAI it's connected
to but equally with the way things are at the minute that feels like
it's probably disproportionate effort.

--M+JJnzUDip9rx8JE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNbw18ACgkQJNaLcl1U
h9A7JQf+MkRMavqrw/+lt93KD/xfx0zvIziXhJJ3+MlsSpvWpJmxEX1nDEEu2I2g
C3wW4SWf4Um/Y1k/eHZYy/KpGJe0ceGE3pmMdrZynpXT2CIWFnGAyLkZAtlRajY9
3wn7V68sQ/A+py5pQOPY1/uDrOkQH2NwHjR9lLvUE8uT/yF1fKmDSMfQTPqHXIVJ
osuU/f+QuIC6JRvu1KcLLk4k0e+Urkm8Y6rck9P3qmbSFM2JqvTm7ZGIIFnmIakd
U4r5I/ex9DN8Qnc002dKHTVM+1Q3AmE6TCnrtnh6F009WvQV7XFLiFQck1b7P5HQ
CIoF98dhQQ/K07h+K2mhTr9xu1ScjQ==
=QJF2
-----END PGP SIGNATURE-----

--M+JJnzUDip9rx8JE--