Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7229a2a6-d646-a8f5-50a2-cca6c44d16d5@nvidia.com>
Date:   Fri, 28 Oct 2022 17:39:48 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        mperttunen@nvidia.com
Cc:     devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20221027051214.22003-1-vidyas@nvidia.com>
 <20221027051214.22003-2-vidyas@nvidia.com>
 <4579404d-b3f7-8342-6704-2644f5cd489d@linaro.org>
From:   Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <4579404d-b3f7-8342-6704-2644f5cd489d@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clM0ZXRzd1hLcnRydnR6NVRoTUZLNkVYYUZrK2dFRTNsRW5yODZiN05pV0dF?=
 =?utf-8?B?ZmFhWW1zcmpNS2ZnYU5RamtKYTFlYUJyUEpIQ1l1V3VBQmhadGdvVXpFZlRl?=
 =?utf-8?B?R1JGS3BqbEJDREhRRTdYZ1dkVnBybXNweTB3aGozN0tNa2lIZ1NlZmtYR1Vl?=
 =?utf-8?B?RU1IU2hzUlZDQTYyNVVQbWwyN21mVG5pMVZJaDROc21HVGd1cGlYM1VkUEJs?=
 =?utf-8?B?a0NSelc4Rmd1MkhqY0l3Ujl1NWhFV1dlSzhTM3FndTNjQWdkb1U4TS9jL1lH?=
 =?utf-8?B?Q3NRTjJPc21SbmNpVUo0TW1URGNiY01iWWxMT1JDVCtBaWNObUZ6R1RPV3Bs?=
 =?utf-8?B?MG5YN25JVmdoY3JFREUzNW04MUYxMHNZNm5Xd1BaUFM1elBNQjNjTXAvZS96?=
 =?utf-8?B?Rmw3a0gzTGdZc3EyM3B1WTd3Mnd2TEdvVFpmR3AwUG0rQzZpbDdPbXM5Qm5y?=
 =?utf-8?B?VGVZeTU2YTFrUnorN3VacXB3c0VjaHBOdHRkWFovRTlTOCtCVERsWTZ0Y0l4?=
 =?utf-8?B?NkN4RUt2TkIrN29VRDBIb1BpTGJKNytjODl1V2FQQ252Wm82MnRyNDJKdnUz?=
 =?utf-8?B?bHE3MXJQMThSMmpGNlVFMnVJU2g2ZlFRdzJvOFFrUnZ6bFBQeVY2d2RoYlk2?=
 =?utf-8?B?VC9tU0ZHY0FFTll2N2gwaXJSaUdMQVJRUHRBREJBZDEzUFBGSnZVMklFaWk3?=
 =?utf-8?B?dENZVGZtYmppc3pUeWw5SjF6M00zbzYxbzBha1p4dysxcnUwNVgwZDI4WGFB?=
 =?utf-8?B?cXBqckJxcU16bXpLYWE0S3l3YnZNMWgvL1pldWxMejZOV0RVM3ZjOUFabWtO?=
 =?utf-8?B?Tk9MZnRuMFhkVDFCclg1UDNHN01UUlRuaFpLaFBIc0UwNmFZa2tBN21reElK?=
 =?utf-8?B?M0Nqd2FvMkV3RE8zYzM2Uzcvc0JNZkhBM2V0RGF0T0dFWlExZ0xrOFhuQmRC?=
 =?utf-8?B?aklDM1A0TUJoOWJaNE5ITjIzalFTQ0M4dnlvVmJkR3l6RzZ5V2xqa2V2WTZD?=
 =?utf-8?B?eE91b05OVHJWN245d2NUVEhteVo5MUw3WS9iUXJKczQvSmRTVUlDalNNMlZp?=
 =?utf-8?B?dE5oMENrREtDUlBnclIwMldmSkh1YkhMOUttN2hpS3BOMUxpNjNmQ0lmczAz?=
 =?utf-8?B?SEwxMi9tUjFKaVF2OFpxSXdwc25HaVBnczNnSTd1b0FFR1RocUhRck5Ha2Jm?=
 =?utf-8?B?QWRoMnJ1OHRnVUswWlpRTzRSeHhPVE4zQ0RRc1VDWXhtbXh4MTEycHNvWmpq?=
 =?utf-8?B?a3hDVHF6c0h3MkNCUlpnajVGL3oxMzNlVU1sTmRGRnRWWTd3ekZTZGk0Y1E4?=
 =?utf-8?B?Z3hVdjBvMzVJdCszeFhHSXhTZXRtLzlGMmtmQU8zQnZNUmNVeFpsWlRaMm5O?=
 =?utf-8?B?Y2IwT3ozOEJhdFZqZ3lDdllpeDhnQ3k4WWY1Tk5kK1QyU1ZIblpUK0FlUDB1?=
 =?utf-8?B?bUp3b2xwNURKZW1BRDJWS3YyNG9ZbWovUUV2UWNoQW5hK1IzbWhFTlJPRzM5?=
 =?utf-8?B?U3ZtK2NGdnIraTZwLzRScjQwaUw1RU5WWUtEVzk1YlorbE9wUFFCYnhVVVhZ?=
 =?utf-8?B?cFl6WFE4UVpEYUF6aE5wOUVTemlpS3BDcmI1MHRIbHZrdjVCRlVuUGxXYXZJ?=
 =?utf-8?B?YXljeEFra3AwejM3Z2tPOUNGajJKTktxVVJhanI1eTI5eEdQNFJaQ1pVZ05Z?=
 =?utf-8?B?YmhiK2diVEw4U2N6RGJPMjJGWXlIeUo5NHJsdGRiL21VRFpSSThhdEt4Y3l2?=
 =?utf-8?B?SnJaaDViOVVDd0doVHlLaWhiRVRWc2RwSXNsdS9QL21sLzJZcWNZYTZtZk9L?=
 =?utf-8?B?VDZScXNzcjFjM3kwUGtobGkybzZvMkRURkdoakNQdENPeGVkUzRiWnNoZ25O?=
 =?utf-8?B?V29tWmIzd3FlRTNDbWRMZTJzNGlQd3FXZGJQT0w1ZDQ1Q2RzLzJWTUxHY3FQ?=
 =?utf-8?B?RURHNmFJTGFFR0NLV3djY0ZDSWpmRnFVSm1Zc2NVRzdwRlNpcGRpYnFvMS9L?=
 =?utf-8?B?bEdpNTc4QjJDc2hTamh6VjhjSk9DWFNGa051aXNVVVB0RjRML0Zhc1FvUXBI?=
 =?utf-8?B?QzdibDMxa0ZVOWFoVzg5Tk1lOGdhaWtqSm5VZ1RIVWZJWGorN2NyaWg2OGxB?=
 =?utf-8?Q?ilVKFn9ekTfzxyyECYpiJeOyR?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2d0baea-f9b3-4436-d6c1-08dab8dd559f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2900.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 12:09:59.4230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MSpJrWx4NIelaugEi8QBDaYrbHhPJeNoAGURDgBZE7ulcLK2vjumF1pPRdz4/1onohhtt+ENqyycz0Cg777o1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5287
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/28/2022 2:48 AM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 27/10/2022 01:12, Vidya Sagar wrote:
>> Add support for ECAM aperture for Tegra234.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>>   .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml  | 10 ++++++++--
>>   .../devicetree/bindings/pci/snps,dw-pcie.yaml          |  2 +-
>>   2 files changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> index 75da3e8eecb9..15cc2d2055bb 100644
>> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> @@ -27,6 +27,7 @@ properties:
>>         - nvidia,tegra234-pcie
>>
>>     reg:
>> +    minItems: 4
>>       items:
>>         - description: controller's application logic registers
>>         - description: configuration registers
>> @@ -35,13 +36,17 @@ properties:
>>             available for software access.
>>         - description: aperture where the Root Port's own configuration
>>             registers are available.
>> +      - description: aperture to access the configuration space through ECAM.
>> +          This is applicable only for Tegra234.
> 
> Then restrict it per compatible in allOf
> 

Thanks Krzysztof for your review.
For a similar change here 
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20220707081301.29961-3-vidyas@nvidia.com/ 
Rob had said that may be it is not worth it.
Let me know if you really want this change and I'll push a new patch.

Thanks,
Vidya Sagar

>>
> 
> Best regards,
> Krzysztof
>