Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2384705rwi; Fri, 28 Oct 2022 06:33:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM51EAGC6QcAfs06R00NKG2DxxcjJFKh/lGVtu6pmbScFTw5sDWNOkS0H8L+KUFfZVQIQwgy X-Received: by 2002:a17:907:b17:b0:78b:b909:e91a with SMTP id h23-20020a1709070b1700b0078bb909e91amr45283323ejl.687.1666963981672; Fri, 28 Oct 2022 06:33:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666963981; cv=none; d=google.com; s=arc-20160816; b=TcEdxUUl3fGJSgzVZogYCLI0xK+a5VEWyMzdBgjGMGQGZMqEC/zVMaRXrgLkZnJ/Pr ISDkCmYcdRE7OcdV/tuJE5glLN8AzVOP76GVaPIEqr0Cq86IjT8LtpuZuAwaXvx0rac4 7+2BxvF0mi933Hu2zE8eIS7jN3AFynhq5WxG0+I9QVo6Pz8+TAKDqKA2veihQJnpcp6O GD9ZNi9dR2QfV9DHUtBCE7xLXdcAEFQ8izAKZRkhJFrYe1V5CeMilP1RL3EVU51MFTnV uXluOD5AMI5VuGZAJpjJB7l1l8iiBT3XY16CeLpi6+uiHnA7RuQFLIGWVxY8rah1u6hK AIdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YxOjchKQMR0NepLMaT43U5aY9O6bOI1VIwV7xrzTqJ0=; b=WnaiIxqlkO5RevzkBfmBO28FWyyMRG8SJTBSfEfA+PwPi+SQaLGcwoRdZO3jqYg/X3 wRB6Pb8GiYZeAzADEugMdKJOyCnUuO6AK7fWZ/OjJzK0/Apqnvs1U3vZ1x/ueji28Gx1 se3k/2U7PjEse/8xnQHmG6qNB5mSD9sisk+rD0vhCzwXg/Y7YQHK8jK04lglkRVgGFim WDz1OdeTFS5jBvzGJYXlFzqgoAMEORGFK61tHGshck8uJb+2q8PvD9IR7/zPgxUEG7hs ZGGnq6FJKxnHJURJQc1iXxuT5cZ+D2dYdzlHFXzKzaviRO+Q6WB9Pgy2A+e/Wdufpeft wymQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qJK0uSjC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s20-20020a056402521400b00461e426dcb0si4627918edd.609.2022.10.28.06.32.35; Fri, 28 Oct 2022 06:33:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qJK0uSjC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229379AbiJ1M4L (ORCPT + 99 others); Fri, 28 Oct 2022 08:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiJ1M4J (ORCPT ); Fri, 28 Oct 2022 08:56:09 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A74ED1BFBA6; Fri, 28 Oct 2022 05:56:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1D473CE2B27; Fri, 28 Oct 2022 12:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EF42C433C1; Fri, 28 Oct 2022 12:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666961765; bh=VHuzHyK/ptJnT7l0y3XH9UJ/iKdBdii83zZaQVjzLGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qJK0uSjCKHOuaBdb8fohf3eG1Ezo4BX544vlCK2s//gCGhInnaT0Y3Xh5qduPhxVo 1xJoCClTBT1I/iAGPMIZjp1q3pBJGSE1VkBpeWg19qtZxpJ3eYGh92wPjSNUXikuAF 1dy22fZ5u/q0+2M1wBMKsVqxqtut6tdeWxJhkP2PPDvyFoOoxklODSzWQSuTXp8xSZ 7Us2KxxmzFn99c1rpOtNvVzLir8Nmw8bF7F5n3dwp1WcYi+Ixvit93imqOsWYWuDus TzjKR/P+cjwYi/DTQecG5tUinB/wj0YeFJjBTAwjts7u7VTd5Gmjiex6ecadXqWHms cMvd68M5hNUpw== Date: Fri, 28 Oct 2022 18:26:00 +0530 From: Vinod Koul To: Johan Hovold Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] phy: qcom-qmp-combo: fix NULL-deref on runtime resume Message-ID: References: <20221026162116.26462-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026162116.26462-1-johan+linaro@kernel.org> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26-10-22, 18:21, Johan Hovold wrote: > Commit fc64623637da ("phy: qcom-qmp-combo,usb: add support for separate > PCS_USB region") started treating the PCS_USB registers as potentially > separate from the PCS registers but used the wrong base when no PCS_USB > offset has been provided. > > Fix the PCS_USB base used at runtime resume to prevent dereferencing a > NULL pointer on platforms that do not provide a PCS_USB offset (e.g. > SC7180). Applied, thanks -- ~Vinod