Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 16:33:59 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Deepak R Varma <drv@mailo.com>
Cc:     outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: Use flexible-array for one /
 zero-length arrays
Message-ID: <Y1vaR0olLH9+bJbk@kadam>
References: <Y1vNNSSWK1EkcohT@ubunlion>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1vNNSSWK1EkcohT@ubunlion>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O2kJgGImfIWJOYXMfXdiKpHdUGTRxJwE+OTuhD6eeI7pLvGBIfJrNqQ2sKGF?=
 =?us-ascii?Q?TQ5BHW2S4mGdYchQDo0wL9t5fN40bau80HpLiye6P37zEjjIPiN/Cvb0lhKB?=
 =?us-ascii?Q?dtVfhaNqxzE6c4id/kRb10l/cnTmeI7lJmAabXQMJBl0ARVuMqHU5QTHBnNz?=
 =?us-ascii?Q?vIL5rxVuyE4uHBzPuQwL73+aayA9nPPyVgLDhwAIxOnmq9XtP9PTHQyeFT2I?=
 =?us-ascii?Q?tWAqqjoTaNgdPp5tyJ2ZomUeO6lx7s7+nAS0jTbkzAlaADMUtOd9UTlZB0Xs?=
 =?us-ascii?Q?Gg4Bt50wClstyuFdgJIBhRFU7ajczUe6Md7jY8yPYuTAztG406MQmbU6FaWp?=
 =?us-ascii?Q?8SpkmZsOv+a5+A7KozNj64UTwIFc7xzO5cS3JyK5MuJ2jG/U87GBroycssE6?=
 =?us-ascii?Q?x4crAaj+EoBgqlvmHwJ47SbNWgvKaIuBPIvSkJr4EtrHwIRpG2nmav5ZcA54?=
 =?us-ascii?Q?aEAFk9GH5aL5njOo/OBIFSNP9uZevWar6MCuJfajR0zg2cERR7+WO5e3RvOU?=
 =?us-ascii?Q?u7rglz1neWFWw+buf2q5l2gxMo42haeVymMD3xJkHp7aiZrDnXnfOtUI5P2+?=
 =?us-ascii?Q?oYM/yROk2vyx7BOUe8fh8DCRKy1RvM/mU2vNtRRdqGz6+47D/CijlKLdMTkD?=
 =?us-ascii?Q?aDlr3mroljVz+n26KPue4Ljz8wWOdqbdBQim4j0mXQgA0AoFaeEFf6F1wfMR?=
 =?us-ascii?Q?Pwz1+8QDjw8dp+k2y9rAg4+ejPp5PvKZX7kKDBRYRDUvAFu/wwb1NsZ1JfkP?=
 =?us-ascii?Q?J/3q6iQefI4nZ8j8sXE6ij06LgPZkpEmoBTFnDUT6PhbbLKP13sDEexAeJlC?=
 =?us-ascii?Q?jsi2PJg9vEWFJHZ5Q/G5sEiW2mEL5sxIXx5qGlpuOm/c5EzrX6ljwkrd4/Dw?=
 =?us-ascii?Q?xvAvWDBUNJDhs+VuZAb8D2+dS7/Ioc8MeDwlbrQyFD3qVJ98fM0zbSSHDd3s?=
 =?us-ascii?Q?JJjFy4v+HzX7YKXmp9ZwogI0d2+jHoYEkxssCFRRrDttyFHtEKBJJ3jkKOyD?=
 =?us-ascii?Q?YHqOASDGITlQHxazrBtfoO4xwvSW+5iPEGLpk5zz2w9iWhqOsQ3ZYO44vQta?=
 =?us-ascii?Q?+QrPFsrm7V9YO4KpyHXk3lDVaJG2Fi0cKkguQ0wmfQdpIZCFaBOCca8/iPaC?=
 =?us-ascii?Q?n7OifIV9GRRh6R//c9BR9xnXZqOFQi2S+yzVzVaSLGd6eslb3Jxb4+VKLXF1?=
 =?us-ascii?Q?ZfBh7wyHRpabsbzlG3UrHSiqUYP63n+Bu9I5oUR+3Ar8/iznv/gqvUT9TV84?=
 =?us-ascii?Q?9CeIDjf2ywdzPQmKCrZGSIr168Zoxu+5ijCq1NfjLK9zfVbXjAWqUdpRsflI?=
 =?us-ascii?Q?HQ/lNnmJHjyZj0dNP3qdghm6fThdadiNFmKWZLSAbUm2j8sHzLuyPN0pOWe/?=
 =?us-ascii?Q?IcihnqABRTczLjc1Z4bzRB0DI107ucIlVGAzyCvIOimkD8sj677k4QlhriDu?=
 =?us-ascii?Q?Pze5v+uefZhYhd3BKXIy+aTVyBTPgs2iM1X6hMd1MVivwlZ2doaX4rKLB3SO?=
 =?us-ascii?Q?W4/WZ5vRVNsQ0nn0HLh3Kg8Dvm4xVgVBVmXaS2Obg+hIluFFIVFpAdHKNKe3?=
 =?us-ascii?Q?pCKPTwjpqFsxrmeW4qFMi1D8Co98S5wize6PrZbgEZsndg96gEpQv1tn/w/l?=
 =?us-ascii?Q?9g=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f1d71db-cb4a-404d-55d6-08dab8e918b0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 13:34:11.6508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m+nwIaUG4Gy3P1kk8jyXGNgsjDMAd8+8ALZlPNcmq9JjWraHDfwIIrCT2uFa2EgI5XR6k1TKE/XP1DnvPCsLShq1LVqawrRLdcEhS9OGVlM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6356
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210280084
X-Proofpoint-GUID: n_lpvYdYVvdzTNA5Fje7i_yC_emyD_49
X-Proofpoint-ORIG-GUID: n_lpvYdYVvdzTNA5Fje7i_yC_emyD_49
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 28, 2022 at 06:08:13PM +0530, Deepak R Varma wrote:
> Flexible-array member should be used instead of one or zero member to
> meet the need for having a dynamically sized trailing elements in a
> structure. Refer to links [1] and [2] for detailed guidance on this
> suggestion.
> 
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> 
> Issue identified using coccicheck.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>  drivers/staging/wlan-ng/p80211mgmt.h  | 8 ++++----
>  drivers/staging/wlan-ng/p80211types.h | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h
> index 1ef30d3f3159..d6fe52de2c8f 100644
> --- a/drivers/staging/wlan-ng/p80211mgmt.h
> +++ b/drivers/staging/wlan-ng/p80211mgmt.h
> @@ -229,14 +229,14 @@ struct wlan_ie {
>  struct wlan_ie_ssid {
>  	u8 eid;
>  	u8 len;
> -	u8 ssid[1];		/* may be zero, ptrs may overlap */
> +	u8 ssid[];		/* may be zero, ptrs may overlap */

How have you ensured that changing this from a 1 byte array to a zero
byte array does not break anything?  It's not uncommon for a people
to do math like "size - 1 + length".  The "- 1" would be to take the
1 element into consideration.

I was trying to read through this code to check your work, but then
you sent a second patch which also does not explain how you are auditing
your changes.  Can you go a bit slower?

regards,
dan carpenter