Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7a1c4943-4ae2-cde4-221b-fa972c2baab2@nvidia.com>
Date:   Fri, 28 Oct 2022 13:42:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 03/11] dt-bindings: usb: Add binding for Cypress cypd4226
 I2C driver
Content-Language: en-US
To:     Thierry Reding <thierry.reding@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Wayne Chang <waynec@nvidia.com>, gregkh@linuxfoundation.org,
        treding@nvidia.com, heikki.krogerus@linux.intel.com,
        ajayg@nvidia.com, kishon@ti.com, vkoul@kernel.org,
        p.zabel@pengutronix.de, balbi@kernel.org, mathias.nyman@intel.com,
        jckuo@nvidia.com, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        singhanc@nvidia.com, linux-i2c@vger.kernel.org,
        linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org
References: <20221024074128.1113554-1-waynec@nvidia.com>
 <20221024074128.1113554-4-waynec@nvidia.com>
 <f8eeeebc-e635-9c97-b97b-46df38f06002@nvidia.com> <Y1vLoT+/dgOgrxjD@orome>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <Y1vLoT+/dgOgrxjD@orome>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3hSVlQ5dGFVZjltVWZOOWQySkZmeVM3L2xUS2hDdFNPMWJJdkY5cWZVY242?=
 =?utf-8?B?RDE4Tnl2d2FhVGoxMFQ2WGlRZ25NdWswL0VoTVljTTFtdHpJTFRiVE9GNTBj?=
 =?utf-8?B?Qm1pc2dGaVIzR0RLK1RIalZuZVprT0svMTBLdDBZaU44R01ESFp6elJpcnha?=
 =?utf-8?B?dWh5QWpyQXF1bXY2MlI0ZXI2VndiQVpQS3dwMGUwRHZ4WW5JL2Y3VVlEWWU2?=
 =?utf-8?B?ZUdaS2lBMFVjZzVKaGs5YnU3RHp0QVVMRzcwazlKWG5pOHJ2UWx6NWhzSFli?=
 =?utf-8?B?b2VjZWJIb2VFK0xaZHQxcHp5Qm1KZVRncEhiTmJxbGRsemUrNVptU0xONkZu?=
 =?utf-8?B?NHZjNUE4MVZPcjFJYnZpbmRsUzNyZVJuWVBBTm1HNWJ0c0g2TUh1bHRqQng3?=
 =?utf-8?B?MWJyMkptazlqdTVHWHhSSVhUajVjV1ZFWHRFVktoLzlEOTFsMnQ0Vi84N1FX?=
 =?utf-8?B?KzJrYmJodEtMdXl2VjJCdk9TQ2lxODhOTmxvS084U2E1dVZycHdLQWE2eFRi?=
 =?utf-8?B?cUJuejFyM2NKVVNmUHlCdWdJbDdFRU1OcWNyUGQxOFdBQ0ZCaVBBaGRFck9u?=
 =?utf-8?B?blk4R1E1bkZ5dmhmMWFHZDB6Nlg2ZGJXVkUwbkc3RjlJOEwzTUtmY2xCYjAz?=
 =?utf-8?B?RzgzNVJFeXo5MEhFWU41Vjc5eUZxMHhpZWVMZ1NwdGtDd2llTE0wSU1kWDVF?=
 =?utf-8?B?a0hhWFlIUGUrZE5hN0xwZWQ4WmpEUFpzMHpmTFB3OThDZmN1aVlQenh1Y3B1?=
 =?utf-8?B?N081cW81cmUyM1ZUYWxtcmxOMEMxNjNBekdQRXk3LzVETmRLVVFJeTJuYmJO?=
 =?utf-8?B?SEhCMXhVaWYvVmFKeVBHWmovL3hVT1IwVTIyeEdJMEphbXd5QjJnVE1QMjZN?=
 =?utf-8?B?dmFNSGd6eDd3akpGN1FjUmhWdVlwYUdIcmNYN1llaWxDNHo2NGMvVno4ais4?=
 =?utf-8?B?bDlPQkQvZGk5WU5MYUcyV0YzR0VKM3hsWGZTdTlNby9rT01lbHRQYmlxRTR5?=
 =?utf-8?B?cjVpeVZmdWxGSDdPME83MnBSYlV1Z3gwMldML3hvWEljN1pLQUcyYSt5ZEJl?=
 =?utf-8?B?Z01FVHJQTUswWCt6WjFOaVR4WEc0VHlFaHhiWWNjajA3aUJRMEpuY0FVT2F4?=
 =?utf-8?B?bWdNS3FiTEdHeDdNRjYzT0FoaGQzdUcrS1VaWk5ZYzR0OXlub3hJY29Qempr?=
 =?utf-8?B?RHh2Q25mUW5IMEpLcTBvN3RZc0dJOGYyOGcrUzRxblNaeVprYzVLaTRNQVJX?=
 =?utf-8?B?WXRCUkkyQ3JNRVdWMThjcEVvMW9aN3FURnBuOVhJMkNCK1FYVmJ0S3FnYmdx?=
 =?utf-8?B?VVJLSWxCNlA5SXNWV2ZocnhyNlM2MWxmQVZSa1lJOXY5ZVFsMTVhMm8wSGpw?=
 =?utf-8?B?TjFmWHJScGR3K1JrOUZpeWp6QnpqNTFZbHRxTlFlQk8zUG0zckcvSHZBbm1j?=
 =?utf-8?B?UXNkZHBTMTlBZzBFVkJPQ05mT0NjbE5FZFhBNEVCUXhCZnR2MUpaREJTSkF5?=
 =?utf-8?B?K1FQOGMxNkZ0b3lWdVFaSUZRQWgvTEdiZmpuRzhPM2tQNWtiZEl1azFMRHVw?=
 =?utf-8?B?YWZmZk5KWkZKeitnUjdTS0NQYmovQ3pzZS9yRlQ5RXBsZUVzVHkxUDhtalk3?=
 =?utf-8?B?YUhsVXJ5enN0V1A4WEN1T2hDNmhSK0xUZTdjYXU2NUdKdCtoUVhiYlN0dE1K?=
 =?utf-8?B?ZjNCTE40bEozVlRVdy9JTzEvR0h4aVFrdXI1NUdhd3FvUXYxR3lWdFVyelVY?=
 =?utf-8?B?THgvb3JqaTl4K2pnWTBBY094ZEhJWm5oT2VJRXhycUpuRjk3bHo0RWJOMTBv?=
 =?utf-8?B?dlF0eVR6SkVGWFlraHlNRVA5ZXl4cGlzMS84eDhCMXJwTWFCMndzbm9ScjYv?=
 =?utf-8?B?K3A5M29EMG50eGFpcm1Xck9KS0dLTWlqc0R6WSt2blU0Mm9HUitCcEVHSzdv?=
 =?utf-8?B?R1BTbE1mRHZMUEdxZElaYVVUSkZ6Mzl6dUNkaVEvWG00WW9JVllRWXhzRjh0?=
 =?utf-8?B?STVwaDd4N1BsWEFBV1RISEtVS0k2NC9wQmhQNTN6SFVvRlJVTHFHc1IzcGNs?=
 =?utf-8?B?ZGwwblZJNG5XUjVORlA3MFZqUFd3YjdhUll1dWswQkVrM3BoZmVhNEZmMko2?=
 =?utf-8?B?ekNxWW80SWppS0VKeFJlZ3UvWTFsTTFoWlFkMC9zcDJrQ20rdlRGbG01Z1Jw?=
 =?utf-8?B?Q1RQSWt0cVZNOXNyQkUwVmJmcVE0cW5HeGpNUHBFNEhxdkRvM0JaMWVNMXNV?=
 =?utf-8?B?M01RU0RLRW9veEJRUjdCbFlhTXBnPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8362aff8-f9c9-4bb2-b673-08dab8e1e958
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 12:42:45.2622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X5bMhC/MgPUF2zwa5GNnoFhk07G2FuJT+cy33Z9xtP05fgMvrwZl11iQON1QznGl7SHE+S+rLLYDhYy0lxF8UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4314
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 28/10/2022 13:31, Thierry Reding wrote:
> On Wed, Oct 26, 2022 at 08:13:57AM +0100, Jon Hunter wrote:
>>
>> On 24/10/2022 08:41, Wayne Chang wrote:
>>> add device-tree binding documentation for Cypress cypd4226 type-C
>>> controller's I2C interface. It is a standard i2c slave with GPIO
>>> input as IRQ interface.
>>>
>>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>>> ---
>>>    .../bindings/usb/cypress,cypd4226.yaml        | 86 +++++++++++++++++++
>>>    1 file changed, 86 insertions(+)
>>>    create mode 100644 Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>> new file mode 100644
>>> index 000000000000..5ac28ab4e7a1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>> @@ -0,0 +1,86 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/usb/cypress,cypd4226.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Cypress cypd4226 UCSI I2C Type-C Controller
>>> +
>>> +maintainers:
>>> +  - Wayne Chang <waynec@nvidia.com>
>>> +
>>> +description: |
>>> +  The Cypress cypd4226 UCSI I2C type-C controller is a I2C interface type-C
>>> +  controller.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: cypress,cypd4226
>>> +
>>> +  '#address-cells':
>>> +    const: 1
>>> +
>>> +  '#size-cells':
>>> +    const: 0
>>> +
>>> +  reg:
>>> +    const: 0x08
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  cypress,firmware-build:
>>> +    enum:
>>> +      - nv
>>> +      - gn
>>> +    description: |
>>> +      the name of the CCGx firmware built for product series.
>>> +      should be set one of following:
>>> +      - "nv" for the RTX product series
>>
>> Please add 'NVIDIA' so that it is 'for the NVIDIA RTX product series'
>>
>>> +      - "gn" for the Jetson product series
>>
>> Same here please add 'NVIDIA' so that it is 'for the NVIDIA Jetson product
>> series'.
>>
>> Rob, any concerns about this property in general? Unfortunately, ACPI choose
>> a 16-bit type for this and used 'nv' for the RTX product. I don't find 'gn'
>> for Jetson very descriptive but we need a way to differentiate from RTX.
>>
>> This is needed in the Cypress CCGX driver for the following ...
>>
>> https://lore.kernel.org/lkml/20220928150840.3804313-1-waynec@nvidia.com/
>>
>> Ideally, this should have been included in this series but was sent before.
>> We can always re-work/update the above patch even though it has been queued
>> up now.
> 
> The driver seems to use this 16-bit value only to compare with a
> corresponding field in the firmware headers. How exactly we obtain this
> value is therefore not important. However, since this 16-bit value is
> embedded in firmware images, we also cannot substitute them with
> something more sensible.

I am actually wondering if this is actually embedded in any images 
because I see it populated by the i2c-nvidia-gpu.c driver [0]. So I am 
wondering if we can use PROPERTY_ENTRY_STRING() for this driver instead 
and have a more descriptive name such as 'nvidia,rtx'?

Jon

[0] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/busses/i2c-nvidia-gpu.c#n261
-- 
nvpublic