Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20019699-40a7-37d6-4b9b-06446183338f@linaro.org>
Date:   Fri, 28 Oct 2022 08:47:22 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support
Content-Language: en-US
To:     Vidya Sagar <vidyas@nvidia.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
        jonathanh@nvidia.com, mperttunen@nvidia.com
Cc:     devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20221027051214.22003-1-vidyas@nvidia.com>
 <20221027051214.22003-2-vidyas@nvidia.com>
 <4579404d-b3f7-8342-6704-2644f5cd489d@linaro.org>
 <7229a2a6-d646-a8f5-50a2-cca6c44d16d5@nvidia.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <7229a2a6-d646-a8f5-50a2-cca6c44d16d5@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28/10/2022 08:09, Vidya Sagar wrote:
> 
> 
> On 10/28/2022 2:48 AM, Krzysztof Kozlowski wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 27/10/2022 01:12, Vidya Sagar wrote:
>>> Add support for ECAM aperture for Tegra234.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>> ---
>>>   .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml  | 10 ++++++++--
>>>   .../devicetree/bindings/pci/snps,dw-pcie.yaml          |  2 +-
>>>   2 files changed, 9 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>>> index 75da3e8eecb9..15cc2d2055bb 100644
>>> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>>> @@ -27,6 +27,7 @@ properties:
>>>         - nvidia,tegra234-pcie
>>>
>>>     reg:
>>> +    minItems: 4
>>>       items:
>>>         - description: controller's application logic registers
>>>         - description: configuration registers
>>> @@ -35,13 +36,17 @@ properties:
>>>             available for software access.
>>>         - description: aperture where the Root Port's own configuration
>>>             registers are available.
>>> +      - description: aperture to access the configuration space through ECAM.
>>> +          This is applicable only for Tegra234.
>>
>> Then restrict it per compatible in allOf
>>
> 
> Thanks Krzysztof for your review.
> For a similar change here 
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20220707081301.29961-3-vidyas@nvidia.com/ 
> Rob had said that may be it is not worth it.
> Let me know if you really want this change and I'll push a new patch.
> 

That's a bit different. Restricting it per variant works and should be
trivial.

Best regards,
Krzysztof