Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 16:43:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     =?utf-8?B?0L3QsNCx?= <nabijaczleweli@nabijaczleweli.xyz>,
        Jonathan Corbet <corbet@lwn.net>,
        Federico Vaga <federico.vaga@vaga.pv.it>,
        Alex Shi <alexs@kernel.org>,
        Yanteng Si <siyanteng@loongson.cn>,
        Hu Haowen <src.res@email.cn>,
        Thomas Sailer <t.sailer@alumni.ethz.ch>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub =?utf-8?B?S2ljacWEc2tp?= <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-doc-tw-discuss@lists.sourceforge.net,
        linux-hams@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 01/15] hamradio: baycom: remove BAYCOM_MAGIC
Message-ID: <Y1vccrsHSnF1QOIb@kadam>
References: <9a453437b5c3b4b1887c1bd84455b0cc3d1c40b2.1666822928.git.nabijaczleweli@nabijaczleweli.xyz>
 <47c2bffb-6bfe-7f5d-0d2d-3cbb99d31019@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <47c2bffb-6bfe-7f5d-0d2d-3cbb99d31019@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmE5a0VXN0NVc3UranJqaFdUV0NSZzdEV2NIV3lFODh3MW4ydkxWdjJLRS93?=
 =?utf-8?B?VG5jM290Z3FpWjQ4S1RZVlZtVDV6dFFpRTBwTkhDeWJGbkdUSUpiY3crcUky?=
 =?utf-8?B?anVwVmlpVm9OdUN6dU83V2pLWVNoWlpCa2hBcDZPWGZpeGN3ODgvSUptbTlv?=
 =?utf-8?B?bUd1KzFxemw1RmF6ODJYZkpQZVdLYzBKZ05MZjZBelEwSExndlJsbjNBRzRV?=
 =?utf-8?B?aVlRemtGdXNrQXdxelcrSUxtOVdaVGdiMEQwMVBxdEFTUTJJRERFcTNGeDVK?=
 =?utf-8?B?N2RIdDVVNGF5T2FNOStIUlRnZTJCclpkWXB2bUhRQ0lWSUdVR1dHUjFHcFkr?=
 =?utf-8?B?bVdkNUxxSGpqOUcwb2VnaFFmT2VMcitKY3Q5cWNUQng2WGtmdGlxcWJvZllT?=
 =?utf-8?B?bzIwaURwRDBMU3VyQVlhWTRDMEFQSzhDYS9SYUlDZFlQUGszMzhvbnU2VHds?=
 =?utf-8?B?S0E5L284djFBK0FtNS9CL21Ra2V1RWNVS0IydHBuVkFkKzJIL0g3cDF6eVRl?=
 =?utf-8?B?VVpLWFYyWkkvWmE2OXpsTHdSNC9XaUF5SFVSYm4veWRpaExYU3dTd2pRcjlE?=
 =?utf-8?B?WmVMNTRtVFZQd0hQVkRDa2JqZVFwck5yWVhUcnZRcytEOEgyUzlQR25GVXlM?=
 =?utf-8?B?RDJtQ2k0aWdYM0ZXNkdrS3gxRElBajVrMkZLaFd0a3VydVRhYWdIQ0dXZldn?=
 =?utf-8?B?NEZzcHBhYS9vdSt6VnFHbGFGZW1QUmdITlNnd2MvRWJwM0dJRjZCQ1BGVjF6?=
 =?utf-8?B?cFFSMC9XRytNL3V1ZXFxK1ZCZ3NlL3dWbGpiS1lhLzI3ZWN3bXNpUmU2ejFC?=
 =?utf-8?B?V1VxOGtCcXdVWXVHMm5WekVpbzBnUGJxUEowNlNhdDBEcnU4M2JnU3RKcTM1?=
 =?utf-8?B?QXNDUitDLy85TFkrSUhGVEZuOG13RFVGWmk0OWRqd1dKd1FjSFJZbHJtemkx?=
 =?utf-8?B?Y2dMaWtIMkdYTzIrbFJhWHRYWmtRU1hINkkvVnpsT3lHdHBBUkdhOXJIYTBL?=
 =?utf-8?B?VHg2UTRkOGVsODBacGR4Nm5YUnhydzR3dXBsK2hUK3orZmhKaWRpblBuWXZE?=
 =?utf-8?B?SExCUzdJM09ndHVMYWRIZ1htR0JudldwNG1ZRzNuQkkxbXdzNmhPY0hOWDZj?=
 =?utf-8?B?bC9LUk90Q3pabWdzZFBzTjdLVE9ZNFZRbUZkMTBqb1JMbDRUUyt1V2REVW05?=
 =?utf-8?B?K0RFa2s3SWZWa21oQ2I0bkVuTUFHMGlnaFc0SnBZdlFoV1VDT1BIaFFrUmZm?=
 =?utf-8?B?YUtqdW8vdEcxcDRCWVVJelBzTkF1RzJmYUFPdm5YaEczUzNTdTBZNjBQUmx4?=
 =?utf-8?B?NjFqdlRGaUxlTzkwbWdBOU5HYW84SnlHRllhK1FNeDhMc3lYNXpHOTF2NkZV?=
 =?utf-8?B?ZVUrTlB2UWt2L2hYRGQra3J3UG5HN1hvT1hpUURWVk5DTXBodXhMSUVrSkM2?=
 =?utf-8?B?VWtrVExnSWNtQmxZZjZlcklLbWJ4NlFEWlErcUtBNitDanRpTWVtZXg2TzJk?=
 =?utf-8?B?Sm1ndXdDZnk0STUwc1lqVnZscHdyUkRaRUFKWkVJWlhDeVFRV3ZQdjQxWEpz?=
 =?utf-8?B?NzR5Zkd4SlIvcjIvSVpNK1Z2OHRiKzdNeUZ4KzRwSWJOdWgzRGt5SWl1anVE?=
 =?utf-8?B?Wkc5NjB4czNtQXdyMVdEcXFjWklGZjM3VWtxY1cvdERXQzN5Q3pvTG1VbE9w?=
 =?utf-8?B?dlJCU20zWVNhNGF6Q3BvRGFxZGVlbHFVcytNZWZheW5TYnkydU43SFczOHhx?=
 =?utf-8?B?d2lPbEUzVE1PNFRVNmxqNmhhbmYrQnpnV1YxNG9xUlRiT21reCs3UnExeVB4?=
 =?utf-8?B?WDVsSHJnamRSbi92S0p1UXZnVGNteDZWQVFHSmJUbk5pU1JlVUpVOFZSTDRy?=
 =?utf-8?B?TnFlVkcybFFsNkprYUttbjRnRGdSbHMrU3FSYk9SZmtmS0NuRHZIWU5yNW9n?=
 =?utf-8?B?TVNzUFlpMG5OZUEvbm53TEpYejRGMDkvV0ZHM282aGZNUlI3dm9XVVhQeHIz?=
 =?utf-8?B?NCs1MVZCRVRNRFR3UllrcTFnWGNsN3JpTU9tZTQ3TGNKWkQ5eE5ERmxZdU9R?=
 =?utf-8?B?cnlseDlrbk9QaXRoQnRzRFYralRDeWU3VGxMWi85aWhmY0tmMVF5NTF1L2Vk?=
 =?utf-8?B?VWhFMUhVeTQ2M0dHYk1QdU5kVUQrYVhsVXFTMVZZVDNBVmI3cjZxdFF5aGkw?=
 =?utf-8?B?RHc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4642085-5d91-4d88-66da-08dab8ea6514
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 13:43:28.9508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1CTZkvXyYGTOQeAdyapbbZvUyYyTtdTm2ZkT15Sypetvzvj2THJiibDHLPgi0hjWdOXBe4xtEVHb3gRTBC3QiVrsqXBDTCuhQZgEOLtU4Fw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4354
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0
 mlxlogscore=912 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210280085
X-Proofpoint-ORIG-GUID: lLDe-3qHVtAUKfO7PWU-yLjwHHZeGbli
X-Proofpoint-GUID: lLDe-3qHVtAUKfO7PWU-yLjwHHZeGbli
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 28, 2022 at 08:13:49PM +0700, Bagas Sanjaya wrote:
> On 10/27/22 05:42, наб wrote:
> > Since defanging in v2.6.12-rc1 it's set exactly once per port on probe
> > and checked exactly once per port on unload: it's useless. Kill it.
> > 
> 
> What do you mean by defanging in that release?

I was also curious about this, but I accidentally sent my question
privately instead of to the list.

> 
> Also, s/Kill it/Remove BAYCOM_MAGIC from magic numbers table/ (your
> wording is kinda mature).
> 

The kernel has almost 13 thousand kills...

$ git grep -i kill | wc -l
12975
$

It's fine.

regards,
dan carpenter