Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <642519a2-664d-d837-983a-1d5bbc72a25e@gmail.com>
Date:   Fri, 28 Oct 2022 17:03:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] staging: r8188eu: Use flexible-array for one length array
 member
Content-Language: en-US
To:     Deepak R Varma <drv@mailo.com>, outreachy@lists.linux.dev,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <Y1vRivFfRD6VoBt/@ubunlion>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <Y1vRivFfRD6VoBt/@ubunlion>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Deepak R,

Deepak R Varma <drv@mailo.com> says:
> Flexible-array member should be used instead of one or zero member to
> meet the need for having a dynamically sized trailing elements in a
> structure. Refer to links [1] and [2] for detailed guidance on this
> suggestion.
> 
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> 
> Issue identified using coccicheck.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>   drivers/staging/r8188eu/include/odm.h         | 2 +-
>   drivers/staging/r8188eu/include/wlan_bssdef.h | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
> index 89b01dd614ba..e2a9de5b9323 100644
> --- a/drivers/staging/r8188eu/include/odm.h
> +++ b/drivers/staging/r8188eu/include/odm.h
> @@ -166,7 +166,7 @@ struct odm_ra_info {
> 
>   struct ijk_matrix_regs_set {
>   	bool	bIQKDone;
> -	s32	Value[1][IQK_Matrix_REG_NUM];
> +	s32	Value[][IQK_Matrix_REG_NUM];
>   };
> 

you are changing the actual size of the struct. Wondering if you have 
tested this patch somehow

>   struct odm_rf_cal {
> diff --git a/drivers/staging/r8188eu/include/wlan_bssdef.h b/drivers/staging/r8188eu/include/wlan_bssdef.h
> index 831c465df500..33177de194eb 100644
> --- a/drivers/staging/r8188eu/include/wlan_bssdef.h
> +++ b/drivers/staging/r8188eu/include/wlan_bssdef.h
> @@ -179,7 +179,7 @@ struct ndis_802_11_status_ind {
> 
>   struct ndis_802_11_auth_evt {
>   	struct ndis_802_11_status_ind       Status;
> -	struct ndis_802_11_auth_req  Request[1];
> +	struct ndis_802_11_auth_req  Request[];
>   };
> 

this structure seems to be unused. Better to remove it instead of 
maintaining the old code

>   struct ndis_802_11_test {
> @@ -291,7 +291,7 @@ struct pmkid_candidate {
>   struct ndis_802_11_pmkid_list {
>   	u32 Version;       /*  Version of the structure */
>   	u32 NumCandidates; /*  No. of pmkid candidates */
> -	struct pmkid_candidate CandidateList[1];
> +	struct pmkid_candidate CandidateList[];
>   };

this one as well

> 
>   struct ndis_802_11_auth_encrypt {
> @@ -304,7 +304,7 @@ struct ndis_802_11_cap {
>   	u32  Version;
>   	u32  NoOfPMKIDs;
>   	u32  NoOfAuthEncryptPairsSupported;
> -	struct ndis_802_11_auth_encrypt AuthenticationEncryptionSupported[1];
> +	struct ndis_802_11_auth_encrypt AuthenticationEncryptionSupported[];
>   };
> 
>   u8 key_2char2num(u8 hch, u8 lch);
> --
> 2.34.1
> 

and this one as well

> 
> 


With regards,
Pavel Skripkin