Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2451693rwi; Fri, 28 Oct 2022 07:15:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM76m9gE2p7UAieq4sf87mLQTH1I4p2VfX7m8X4v2ijuV/GR6zqlnRzg82zAzvjBWfTvffw/ X-Received: by 2002:a05:6a00:88f:b0:558:8186:3ec3 with SMTP id q15-20020a056a00088f00b0055881863ec3mr52985824pfj.83.1666966535529; Fri, 28 Oct 2022 07:15:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666966535; cv=none; d=google.com; s=arc-20160816; b=z1MgT+Bi/ra4uJyoktwaFh5FPW3O86zQ6v6DgHu/+4/Bzd16jIJAV7d/LqVtQ/+5TV iAsObqrbIn6WZ1zjGsEB9Nv/ByZxqT3GiPxOWbJ1YBR4JXhrTHW0tRs5iVAnAoVbN+HX WylsUGUQp+17+XBCersUl1Y+6pqbU0/tEbCCTK5wok9ws3Vt2JpEH4J/2FsaQ0iMI3Ue UzwlFfOzrQ1VIijSSSg63BWbNRrlCE9Om9Gkfd6vGACugPPKtLiAIRyvnmPKzOGfGyV1 4mjFzx36tEI5T6lfiHCzbbD1hcXxBGL3CaYKkyVnVGO2owNB3NPXj/egfc4gJvy1oGs9 7zrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=Tj6XPZgUzW8NJ94b23+3IuXwJoGOQr4AlpD0AF0r/6w=; b=WM4/4Obp2wvLc92e39nXBS/NFS8jGFeaCsG2bWfJSaw4hTWGZYj68vNioFVDzChV2R qE64wHB4Nmc+sWTVzJou2zkE9qjN/f+Tj8ZI9W8cMJHjRh0A+iOQf5oLZyNJtT4ARHVK 0U+jCHG+X8O+CqQmxwNUtVFWSfypuDSB+cnhnVcbR96e4jvW9o66jjMQT1VxFQWfrXBK wPsL70G6u7T59tJrRYgnKI71pdMmrFgdG1rv0k+/oLmJ1k9XBFVYSbMNj+kO4rx5eUuy 3r+uzUNmYDBZsVe8tbuGEMHfXFwapgLEELJ+HG4zPmLll6dXkyL7gx08hz7qUh6OVUbN nDDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Xlu1uPNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a170902d48700b001841e5f44a6si6309353plg.37.2022.10.28.07.15.15; Fri, 28 Oct 2022 07:15:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Xlu1uPNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbiJ1NzY (ORCPT + 99 others); Fri, 28 Oct 2022 09:55:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230024AbiJ1NzM (ORCPT ); Fri, 28 Oct 2022 09:55:12 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 594AB4E42B for ; Fri, 28 Oct 2022 06:55:06 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id e19so2973961ili.4 for ; Fri, 28 Oct 2022 06:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tj6XPZgUzW8NJ94b23+3IuXwJoGOQr4AlpD0AF0r/6w=; b=Xlu1uPNMpYPUg0+TCziv/31NEm7rrpAH9J9cxIJ0HL4Ks3WBfICWa1sJYzimYnSruR MSHyU607tb/52sAo0Dlw5AN7oYNOwz1iPvMJjPNTPrxrDx9v0Cx3kCrdJrCM1p1wE9E/ ox2mCg65fPbX6FrTZEwrmGkusuDTJSOgqZIUbvSpgmv+i/VWSqD4qUB8g4YbGUK7AtmS 9ZDDk60XjREUnCoImKiS0YLPcXmv9CT3eaVKWpDre9DZrrb7KwcNMavUFRBOgCnqeFqB Pl61KwVnz141j7ZUqdwhFhQsRFqZvRtcgTmqnZ9xA2o5/DbVYm3M21fga+iYK080DQQ6 NP0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tj6XPZgUzW8NJ94b23+3IuXwJoGOQr4AlpD0AF0r/6w=; b=ZoY2nI53HIg3cisH4st5zhgYnmgqNdo/PPR0EaPNjYlPW9g739J2mUy1TB4GdTYDfh SZg0mq1JqdY9fUOvjh8ltjxEUbr9K1qqZ2daL69VG6HO85DiJdVhu1XzCQMgeoj2HFWA 8/wzh90ktMYsVWikb7RrmjkEO29F77zqUxVH/n7/K5TycytkDQkE49jFCVlHwgtl6oY0 vcJ6c6m9jGFH5xPf3a5KQYw7232qKRjoBCxLvjwIpNGP9prvXLdXj8RR3KUlKfFst3ZV tdqoVA1nEVlxUUIFsA3rwY4Cq7R6S9GAVOaHQYCaV02Y/XyYHpe9pyPMBe7HoH+CMxlo G7Cg== X-Gm-Message-State: ACrzQf18KYdeiWsbj42Im1znC9/f2DayEjVrCcL38JSSpbpzbFYRs2nl /0QJafvc4HUDnhDouqPGzR66IODYiZyWg5iL X-Received: by 2002:a05:6e02:1605:b0:2fc:405a:d04d with SMTP id t5-20020a056e02160500b002fc405ad04dmr34107225ilu.320.1666965305346; Fri, 28 Oct 2022 06:55:05 -0700 (PDT) Received: from [127.0.0.1] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id y16-20020a92d210000000b002f9f44625fbsm1616544ily.52.2022.10.28.06.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 06:55:04 -0700 (PDT) From: Jens Axboe To: John Garry Cc: linux-block@vger.kernel.org, ming.lei@redhat.com, bvanassche@acm.org, linux-kernel@vger.kernel.org, hch@lst.de In-Reply-To: <1666780513-121650-1-git-send-email-john.garry@huawei.com> References: <1666780513-121650-1-git-send-email-john.garry@huawei.com> Subject: Re: [PATCH v2] blk-mq: Properly init requests from blk_mq_alloc_request_hctx() Message-Id: <166696530392.41700.5029897700030243844.b4-ty@kernel.dk> Date: Fri, 28 Oct 2022 07:55:03 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-d9ed3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Oct 2022 18:35:13 +0800, John Garry wrote: > Function blk_mq_alloc_request_hctx() is missing zeroing/init of rq->bio, > biotail, __sector, and __data_len members, which blk_mq_alloc_request() > has, so duplicate what we do in blk_mq_alloc_request(). > > Applied, thanks! [1/1] blk-mq: Properly init requests from blk_mq_alloc_request_hctx() commit: e3c5a78cdb6237bfb9641b63cccf366325229eec Best regards, -- Jens Axboe