Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763397AbXHCO4q (ORCPT ); Fri, 3 Aug 2007 10:56:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762456AbXHCO4j (ORCPT ); Fri, 3 Aug 2007 10:56:39 -0400 Received: from aug.linbit.com ([212.69.162.22]:35479 "EHLO mail.linbit.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1762277AbXHCO4i (ORCPT ); Fri, 3 Aug 2007 10:56:38 -0400 Date: Fri, 3 Aug 2007 16:56:17 +0200 From: Lars Ellenberg To: Adrian Bunk Cc: Maurice Volaski , jheffner@psc.edu, discussion@web100.org, linux-kernel@vger.kernel.org, drbd-user@linbit.com Subject: Re: drbd 8.0.2/3 doesn't load under kernel 2.6.21 Message-ID: <20070803145617.GA8426@racke.local> Mail-Followup-To: Adrian Bunk , Maurice Volaski , jheffner@psc.edu, discussion@web100.org, linux-kernel@vger.kernel.org, drbd-user@lists.linbit.com References: <20070801223440.GS3972@stusta.de> <20070802000005.GT3972@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070802000005.GT3972@stusta.de> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2498 Lines: 65 On Thu, Aug 02, 2007 at 02:00:05AM +0200, Adrian Bunk wrote: > On Wed, Aug 01, 2007 at 07:02:14PM -0400, Maurice Volaski wrote: > > First, did you confirm this behavior? Can you please explain that? How > > could they possibly interact with one another? > > > It's obvious when looking at the source code that both modules you are > trying to use are buggy, and the sum of the bugs in both modules is the > drbd breakage you observe. > > > 30% of the guilt go to the drbd developers for doing the following: > > #ifdef NETLINK_ROUTE6 > /* pre 2.6.16 */ > err = cn_init(); > if(err) return err; > #endif > > The author wanted to check for pre-2.6.14 when the connector code was > added to the kernel, not for pre-2.6.16 as the comment implies or > pre-2.6.13 as the code does. > > Or he wanted to check whether it's a recent kernel and the connector > code is compiled into the kernel. that is what we wanted to check for. iirc, we first went to test for the kernel version, unfortunately going just for the kernel version did not exactly work out for patched vendor kernels... browsing over the available (to us at that time) kernel trees suggested that misusing the define of NETLINK_ROUTE6 might just work... > 70% of the guilt go to the web100 developers for shipping the following > to their users: > > --- linux-2.6-web100/include/linux/netlink.h 19 Jul 2007 17:49:17 -0000 1.1.1.16 > +++ linux-2.6-web100/include/linux/netlink.h 19 Jul 2007 18:11:01 -0000 1.17 > @@ -14,6 +14,7 @@ > #define NETLINK_SELINUX 7 /* SELinux event notifications */ > #define NETLINK_ISCSI 8 /* Open-iSCSI */ > #define NETLINK_AUDIT 9 /* auditing */ > +#define NETLINK_ROUTE6 11 /* af_inet6 route comm channel */ > #define NETLINK_FIB_LOOKUP 10 > #define NETLINK_CONNECTOR 11 > #define NETLINK_NETFILTER 12 /* netfilter subsystem */ > > That's not only buggy but also not used by web100. > > > cu > Adrian thank you very much for looking at this, -- : Lars Ellenberg Tel +43-1-8178292-0 : : LINBIT Information Technologies GmbH Fax +43-1-8178292-82 : : Vivenotgasse 48, A-1120 Vienna/Europe http://www.linbit.com : __ please use the "List-Reply" function of your email client. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/